TomerAberbach commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2733046088
> @TomerAberbach Maven dependency resolver should pick version 5.5 over 5.4 if both are present as transitive dependencies. (Please @michael-o correct me if I am wrong.) I wish this were true, but unfortunately Maven will pick the version closest to the root of the user's project... Gradle does the right thing and picks the higher of the two versions, but enough people use Maven that its resolution strategy is a problem for me. > If the user has explicitly pinned HttpClient to a specific version in their POM this is a general dependency management problem that the user needs to address either by pinning the version of your library to match that of HttpClient or by upgrading (or unpinning) HttpClient version. The problem with this is that the user may be on an old version and it may be onerous for them to upgrade to the latest one just so that my SDK can call this `withRandomBoundary()`. That's why I consider this PR a breaking change: 1. The contract of the class has changed. It used to not be the responsibility of the caller to ensure some fixed boundary isn't in the request body, but now it is. 2. In order to avoid the new contract, I must force all users of my library to upgrade to the new version. If they don't upgrade then their code will break because `withRandomBoundary()` will not exist at runtime. Is this not clearly a breaking change? A change to the contract of a class that also ends up requiring breaking changes to users of this library? > You may be much better off migrating to Apache Mime4J given the direction this whole thing is going. You're one of the maintainers right? I'm curious why you'd prefer users to migrate to a different library instead of using this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
