HttpCore 5.3.4 release notes

2025-03-15 Thread Oleg Kalnichevski
Folks Please review HttpCore 5.3.4 release notes and amend them as you deem necessary: https://github.com/apache/httpcomponents-core/blob/5.3.x/RELEASE_NOTES.txt Oleg - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For

Re: [PR] Fix PublicSuffixMatcherLoader#getDefault [httpcomponents-client]

2025-03-15 Thread via GitHub
ok2c commented on PR #621: URL: https://github.com/apache/httpcomponents-client/pull/621#issuecomment-2703588398 @joegallo That you for contributing this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-15 Thread via GitHub
outlandishlizard commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2727040042 Aside from the security implications, this change also violates the guidance in RFC 2048 that: > The use of a media type of "multipart" in a body part within

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-15 Thread via GitHub
peterhalicky commented on PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#issuecomment-2724491903 The initial motivation for HTTPCORE-778 was the need to put some application/x-www-form-urlencoded formatted values into the fragment part of a URI. The format is pretty m

[jira] [Resolved] (HTTPCORE-777) CloseableHttpAsyncClient.execute hangs forever upon connection reset

2025-03-15 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-777. Fix Version/s: 5.3.4 5.4-alpha1 Resolution: Fixed > Clo

[jira] [Commented] (HTTPCORE-778) Inconsistency in encoding method for query and fragment components by URIBuilder

2025-03-15 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935489#comment-17935489 ] Oleg Kalnichevski commented on HTTPCORE-778: [~peterhalicky] Here is the pr

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-15 Thread via GitHub
ok2c commented on PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#issuecomment-2724515417 @peterhalicky no matter how hard we try we just cannot make everyone happy, can we? The only way of accommodating your request would be to add support for `List fragmentPa

[PR] HTTPCORE-778: URIBuilder to not encode sub-delims in URI fragment component for consistency with query component encoding [httpcomponents-core]

2025-03-15 Thread via GitHub
ok2c opened a new pull request, #518: URL: https://github.com/apache/httpcomponents-core/pull/518 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-15 Thread via GitHub
peterhalicky commented on PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#issuecomment-2724525778 > @peterhalicky no matter how hard we try we just cannot make everyone happy, can we? > > The only way of accommodating your request would be to add support for `Li

Re: [PR] RFC 3986 conformant URI encoding policy [httpcomponents-core]

2025-03-15 Thread via GitHub
ok2c commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1996872461 ## httpcore5/src/test/java/org/apache/hc/core5/net/TestURIBuilder.java: ## @@ -472,6 +472,7 @@ void testFragmentEncoding() throws Exception { .

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-15 Thread via GitHub
outlandishlizard commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2726765179 This PR appears to fundamentally misunderstand the risks; it's not a packet injection or MITM attack, it's an in-band attack within user supplied data. The notion th

Re: HttpCore 5.3.4 release notes

2025-03-15 Thread Gary Gregory
LGTM. I fixed a minor typo and such. TY, Gary On Sat, Mar 15, 2025 at 5:18 AM Oleg Kalnichevski wrote: > > Folks > > Please review HttpCore 5.3.4 release notes and amend them as you deem > necessary: > > https://github.com/apache/httpcomponents-core/blob/5.3.x/RELEASE_NOTES.txt > > Oleg > >

Re: [PR] RFC 3986 conformant URI encoding policy [httpcomponents-core]

2025-03-15 Thread via GitHub
arturobernalg commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1997284724 ## httpcore5/src/test/java/org/apache/hc/core5/net/TestURIBuilder.java: ## @@ -617,7 +618,7 @@ void testHttpHost() throws Exception { @Test

Re: [PR] HTTPCORE-778: URIBuilder to not encode sub-delims in URI fragment component for consistency with query component encoding [httpcomponents-core]

2025-03-15 Thread via GitHub
ok2c commented on PR #518: URL: https://github.com/apache/httpcomponents-core/pull/518#issuecomment-2724397241 @arturobernalg Here's the fix for the stable 5.3.x branch. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-15 Thread via GitHub
ok2c commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1996675961 ## httpcore5/src/main/java/org/apache/hc/core5/net/PercentCodec.java: ## @@ -113,6 +113,37 @@ public class PercentCodec { RFC5987_UNRESERVED.set('~');

Re: [PR] RFC 3986 conformant URI encoding policy [httpcomponents-core]

2025-03-15 Thread via GitHub
PascalSchumacher commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1996974475 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -175,6 +203,22 @@ public URIBuilder setCharset(final Charset charset) {