ok2c commented on code in PR #517:
URL:
https://github.com/apache/httpcomponents-core/pull/517#discussion_r1996872461
##########
httpcore5/src/test/java/org/apache/hc/core5/net/TestURIBuilder.java:
##########
@@ -472,6 +472,7 @@ void testFragmentEncoding() throws Exception {
.setScheme("https")
.setHost("somehost.com")
.setFragment("some fragment with all sorts of $tuff in it!!!")
+ .setEncodingPolicy(URIBuilder.EncodingPolicy.RFC_3986)
Review Comment:
@arturobernalg I think the test should also pass with `ALL_RESERVED` default
##########
httpcore5/src/test/java/org/apache/hc/core5/net/TestURIBuilder.java:
##########
@@ -617,7 +618,7 @@ void testHttpHost() throws Exception {
@Test
void testSetHostWithReservedChars() throws Exception {
- final URIBuilder uribuilder = new URIBuilder();
+ final URIBuilder uribuilder = new
URIBuilder().setEncodingPolicy(URIBuilder.EncodingPolicy.ALL_RESERVED);
Review Comment:
@arturobernalg I think this should no longer be necessary. `ALL_RESERVED` is
default now.
##########
httpcore5/src/test/java/org/apache/hc/core5/net/TestURIBuilder.java:
##########
@@ -171,7 +171,7 @@ void testFormatQuery() {
@Test
void testHierarchicalUri() throws Exception {
final URI uri = new URI("http", "stuff", "localhost", 80, "/some
stuff", "param=stuff", "fragment");
- final URIBuilder uribuilder = new URIBuilder(uri);
+ final URIBuilder uribuilder = new
URIBuilder(uri).setEncodingPolicy(URIBuilder.EncodingPolicy.ALL_RESERVED);
Review Comment:
@arturobernalg I think this should no longer be necessary. `ALL_RESERVED` is
default now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
