arturobernalg commented on PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#issuecomment-2426943351
> @arturobernalg Looks unnecessary complex. So what if the `DATE` can be
successfully parsed but it represents a point in time when Jesus roamed
Galilea? What good that t
+1
On 2024/10/19 10:32:19 Oleg Kalnichevski wrote:
> Please vote on releasing these packages as HttpCore 5.3.1.
> The vote is open for the at least 72 hours, and only votes from
> HttpComponents PMC members are binding. The vote passes if at least
> three binding +1 votes are cast and there are mo
[x] +1 Release the packages as HttpCore 5.3.1
Oleg
On 19/10/2024 12:32, Oleg Kalnichevski wrote:
Please vote on releasing these packages as HttpCore 5.3.1.
The vote is open for the at least 72 hours, and only votes from
HttpComponents PMC members are binding. The vote passes if at least
three b
ok2c commented on PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#issuecomment-2426462442
@arturobernalg Looks unnecessary complex. So what if the `DATE` can be
successfully parsed but it represents a point in time when Jesus roamed
Galilea? What good that that make? I
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1808718309
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,149 @@
+/*
+ * ===
ok2c commented on PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#issuecomment-2427019299
@arturobernalg Yes, pretty much, but with a boolean flag (`alwaysReplace or
some such`) like you had before.
By the way `status >= HttpStatus.SC_OK` check can be removed, a
arturobernalg commented on PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#issuecomment-2427284467
> By the way `status >= HttpStatus.SC_OK` check can be removed, as 1xx
intermediate response messages never get passed to the protocol handler along
with final responses.
arturobernalg commented on PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#issuecomment-2427517243
> Hi @arturobernalg
>
> I git-hub resolved most of the comment I wrote. I think we should
consistently name ALL our new classes either with or without the "ing" w
