arturobernalg commented on PR #580: URL: https://github.com/apache/httpcomponents-client/pull/580#issuecomment-2427517243
> Hi @arturobernalg > > I git-hub resolved most of the comment I wrote. I think we should consistently name ALL our new classes either with or without the "ing" word part, either `[Compress|Decompress]Entity` or `[Compressing|Decompressing]Entity`. I think "ing" is better and in keeping with our existing other `HttpEntity` implementations like `IncomingHttpEntity` and `DecompressingEntity` (conflicting). I also think that all this new compression/decompression code should live in its own package, maybe `org.apache.hc.client5.http.entity.compress`. Please @garydgregory take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
