ok2c opened a new pull request, #494:
URL: https://github.com/apache/httpcomponents-core/pull/494
Folks
I just recently discovered
[TestContainers](https://java.testcontainers.org/) and it this framework is an
absolute marvel!
I took it as an opportunity to revise and improve
garydgregory commented on PR #494:
URL:
https://github.com/apache/httpcomponents-core/pull/494#issuecomment-2404826384
I use TextContainers elsewhere, works like champ!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ok2c commented on code in PR #494:
URL:
https://github.com/apache/httpcomponents-core/pull/494#discussion_r1795854034
##
httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java:
##
@@ -0,0 +1,94 @@
+/*
+ * =
arturobernalg commented on code in PR #494:
URL:
https://github.com/apache/httpcomponents-core/pull/494#discussion_r1795864799
##
httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java:
##
@@ -0,0 +1,94 @@
+/*
+ *
massdosage commented on code in PR #494:
URL:
https://github.com/apache/httpcomponents-core/pull/494#discussion_r1795738709
##
httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java:
##
@@ -0,0 +1,94 @@
+/*
+ * ===
I agree that "latest" doesn't sound reproducible but more importantly is
not secure, this has been an issue in other ecosystems. We pin versions of
dependencies in POMs, we should do it here as well. Good find!
Gafy
On Thu, Oct 10, 2024, 12:12 PM massdosage (via GitHub)
wrote:
>
> massdosage co
CelestiaTheDryad commented on PR #495:
URL:
https://github.com/apache/httpcomponents-core/pull/495#issuecomment-2405952333
Rebased onto master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ok2c commented on PR #495:
URL:
https://github.com/apache/httpcomponents-core/pull/495#issuecomment-2406045571
@CelestiaTheDryad This is big. I will need some time to review the changes.
Do you think there is a possibility to put together a test case to verify the
fix?
--
This is an au
