Re: [PR] HTTPCLIENT-1625 Completely overhaul GSS-API-based authentication backend [httpcomponents-client]

2024-09-10 Thread via GitHub
stoty commented on code in PR #577: URL: https://github.com/apache/httpcomponents-client/pull/577#discussion_r1751413294 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/AuthScheme.java: ## @@ -86,6 +86,10 @@ * containing the terminal authorization response, the s

Re: [PR] HTTPCLIENT-1625 Completely overhaul GSS-API-based authentication backend [httpcomponents-client]

2024-09-10 Thread via GitHub
stoty commented on code in PR #577: URL: https://github.com/apache/httpcomponents-client/pull/577#discussion_r1751455163 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/KerberosConfig.java: ## @@ -53,25 +49,28 @@ public enum Option { public static final Kerb

Re: [PR] HTTPCLIENT-1625 Completely overhaul GSS-API-based authentication backend [httpcomponents-client]

2024-09-10 Thread via GitHub
stoty commented on code in PR #577: URL: https://github.com/apache/httpcomponents-client/pull/577#discussion_r1751455873 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/DefaultAuthenticationStrategy.java: ## @@ -68,6 +68,8 @@ public class DefaultAuthenticationStrat

[jira] [Commented] (HTTPCLIENT-2338) Accept-Encoding lost on request retrying

2024-09-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880573#comment-17880573 ] ASF subversion and git services commented on HTTPCLIENT-2338:

[jira] [Commented] (HTTPCLIENT-2338) Accept-Encoding lost on request retrying

2024-09-10 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880576#comment-17880576 ] Oleg Kalnichevski commented on HTTPCLIENT-2338: --- [~michu4k] Please rev