stoty commented on code in PR #577:
URL:
https://github.com/apache/httpcomponents-client/pull/577#discussion_r1751455163
##########
httpclient5/src/main/java/org/apache/hc/client5/http/auth/KerberosConfig.java:
##########
@@ -53,25 +49,28 @@ public enum Option {
public static final KerberosConfig DEFAULT = new Builder().build();
- private final Option stripPort;
- private final Option useCanonicalHostname;
- private final Option requestDelegCreds;
+ private final Option stripPort; //Effective default is ENABLE
+ private final Option useCanonicalHostname; //Effective default is ENABLE
+ private final Option requestDelegCreds; //Effective default is DISABLE
+ private final Option requestMutualAuth; //Effective default is DISABLE
Review Comment:
I have looked at this, and the current API is really built around using the
gss library default settings.
Since we are making incompatible changes anyway, if we want to set
non-default gss options by default, (and keep them configurable), then we
should remove the default options, and use simple booleans with explicit
true/false defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
