garydgregory commented on PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2306871814
> Let's discuss on the dev mailing list to keep things in one place if
that's OK?
👍
--
This is an automated message from the Apache Git Service.
To respond to t
Hi Andrian:
Here is my output:
https://gist.github.com/garydgregory/071c34698b9b702c8c28efc98e0c526a
Gary
On 2024/08/23 06:57:18 Adrian Woodhead wrote:
> Strange, what happens if you run mvn with the "-X" flag to get debugging
> information. I see something along these lines towards the end of
OK, so it's downloaded the file successfully, in this case it's using a
copy from the plugin's local cache:
[DEBUG] Got from cache:
C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin\effective_tld_names.dat_21b8d15562229f61c11725080a5f7911
Can you confirm that you have this file:
http
Welcome to the latest OpenJDK Quality Outreach update!
Everything is on track for the General Availability of Java 23 on September
17th [1] as the JDK 23 Release Candidate builds (RC2 - builds 37) are now
available [2]. And before shifting your attention to JDK 24, make sure to check
the Heads-
massdosage opened a new pull request, #571:
URL: https://github.com/apache/httpcomponents-client/pull/571
As discussed on the dev mailing list, this should fix the failing
`TestPublicSuffixMatcher` tests on Windows.
--
This is an automated message from the Apache Git Service.
To respond t
I think this will do the trick, PTAL and let me know:
https://github.com/apache/httpcomponents-client/pull/571
On Fri, 23 Aug 2024 at 13:58, Adrian Woodhead <
adrian.woodh...@humansecurity.com> wrote:
> OK, so it's downloaded the file successfully, in this case it's using a
> copy from the plug
On 2024/08/23 11:58:54 Adrian Woodhead wrote:
> OK, so it's downloaded the file successfully, in this case it's using a
> copy from the plugin's local cache:
>
> [DEBUG] Got from cache:
> C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin\effective_tld_names.dat_21b8d15562229f61c1172508
garydgregory commented on PR #571:
URL:
https://github.com/apache/httpcomponents-client/pull/571#issuecomment-2306993341
Hello @massdosage
FWIW, `Paths.get("mozilla", "public-suffix-list.txt").toString()` would be
better here but not really needed unless `Path`s where used in the te
garydgregory commented on PR #558:
URL:
https://github.com/apache/httpcomponents-client/pull/558#issuecomment-2307002730
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876251#comment-17876251
]
ASF subversion and git services commented on HTTPCLIENT-2328:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876253#comment-17876253
]
ASF subversion and git services commented on HTTPCLIENT-2336:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876255#comment-17876255
]
ASF subversion and git services commented on HTTPCLIENT-2335:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876254#comment-17876254
]
ASF subversion and git services commented on HTTPCLIENT-2336:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876252#comment-17876252
]
ASF subversion and git services commented on HTTPCLIENT-2333:
garydgregory merged PR #558:
URL: https://github.com/apache/httpcomponents-client/pull/558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
I updated the Maven download plugin to its current version without a change in
outcome :-(
There must be something odd on my end to get this one test to fail but ... what?
TY
Gary
On 2024/08/23 12:27:43 "Gary D. Gregory" wrote:
> On 2024/08/23 11:58:54 Adrian Woodhead wrote:
> > OK, so it's dow
FYI: I disabled my VPN client and the test still fails, so it's not that.
Gary
On 2024/08/23 12:44:28 "Gary D. Gregory" wrote:
> I updated the Maven download plugin to its current version without a change
> in outcome :-(
>
> There must be something odd on my end to get this one test to fail bu
What is the exact error you are getting? Is it the NPE from that file not
being found (that's what I was assuming) or is it something completely
different?
On Fri, 23 Aug 2024 at 14:45, Gary D. Gregory wrote:
> FYI: I disabled my VPN client and the test still fails, so it's not that.
>
> Gary
>
massdosage commented on PR #571:
URL:
https://github.com/apache/httpcomponents-client/pull/571#issuecomment-2307037421
OK, the `SOURCE_FILE` code was already there before any of my changes so I
purposefully didn't touch it but the try-with-resources you suggest looks good.
Even if this PR
Problem solved: I manually deleted the folder
C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin
Our clean goal needs to do that...
Gary
On 2024/08/23 12:44:28 "Gary D. Gregory" wrote:
> I updated the Maven download plugin to its current version without a change
> in outcome :-(
>
dependabot[bot] opened a new pull request, #572:
URL: https://github.com/apache/httpcomponents-client/pull/572
Bumps [org.hamcrest:hamcrest](https://github.com/hamcrest/JavaHamcrest) from
2.2 to 3.0.
Release notes
Sourced from https://github.com/hamcrest/JavaHamcrest/releases";>org
dependabot[bot] opened a new pull request, #573:
URL: https://github.com/apache/httpcomponents-client/pull/573
Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from
5.10.2 to 5.11.0.
Release notes
Sourced from https://github.com/junit-team/junit5/releases";>org.jun
On Fri, 2024-08-23 at 13:04 +, Gary D. Gregory wrote:
> Problem solved: I manually deleted the folder
> C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin
>
> Our clean goal needs to do that...
>
Andrian,Gary
The only proper way of fixing the problem is including the file (or
sub
ok2c commented on code in PR #571:
URL:
https://github.com/apache/httpcomponents-client/pull/571#discussion_r1728960187
##
httpclient5/src/test/java/org/apache/hc/client5/http/psl/TestPublicSuffixMatcher.java:
##
@@ -40,8 +42,7 @@
class TestPublicSuffixMatcher {
private
Ah, I was wondering if the cache had an older version, good find.
Instead of fetching the latest version via mvn I could include the whole
file in git, we'd just have to update it if/when something in there changed
that impacted a test but that probably wouldn't happen too often and I'd
imagine wo
How about using true in the plugin config?
https://maven-download-plugin.github.io/maven-download-plugin/docsite/1.9.0/wget-mojo.html
That works here.
Gary
On 2024/08/23 13:16:24 Oleg Kalnichevski wrote:
> On Fri, 2024-08-23 at 13:04 +, Gary D. Gregory wrote:
> > Problem solved: I manually
massdosage commented on code in PR #571:
URL:
https://github.com/apache/httpcomponents-client/pull/571#discussion_r1728971628
##
httpclient5/src/test/java/org/apache/hc/client5/http/psl/TestPublicSuffixMatcher.java:
##
@@ -40,8 +42,7 @@
class TestPublicSuffixMatcher {
p
On 2024/08/23 13:16:24 Oleg Kalnichevski wrote:
> On Fri, 2024-08-23 at 13:04 +, Gary D. Gregory wrote:
> > Problem solved: I manually deleted the folder
> > C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin
> >
> > Our clean goal needs to do that...
> >
>
> Andrian,Gary
>
> The
massdosage commented on code in PR #571:
URL:
https://github.com/apache/httpcomponents-client/pull/571#discussion_r1729008351
##
httpclient5/src/test/java/org/apache/hc/client5/http/psl/TestPublicSuffixMatcher.java:
##
@@ -40,8 +42,7 @@
class TestPublicSuffixMatcher {
p
Agreed, how about the changes I just pushed to
https://github.com/apache/httpcomponents-client/pull/571?
On Fri, 23 Aug 2024 at 15:25, Gary D. Gregory wrote:
> On 2024/08/23 13:16:24 Oleg Kalnichevski wrote:
> > On Fri, 2024-08-23 at 13:04 +, Gary D. Gregory wrote:
> > > Problem solved: I ma
garydgregory opened a new pull request, #574:
URL: https://github.com/apache/httpcomponents-client/pull/574
Includes a copy of in https://publicsuffix.org/list/effective_tld_names.dat
in httpclient5/src/test/resources/org/publicsuffix/list/effective_tld_names.dat
--
This is an automated m
garydgregory commented on PR #571:
URL:
https://github.com/apache/httpcomponents-client/pull/571#issuecomment-2307184428
Ah, this PR looks like a partial duplicate of
https://github.com/apache/httpcomponents-client/pull/574 except that #574
preserves the ability to refresh the DAT file.
massdosage commented on PR #571:
URL:
https://github.com/apache/httpcomponents-client/pull/571#issuecomment-2307191939
Feel free to close this one and use #574 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
garydgregory merged PR #573:
URL: https://github.com/apache/httpcomponents-client/pull/573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
garydgregory commented on PR #572:
URL:
https://github.com/apache/httpcomponents-client/pull/572#issuecomment-2307486858
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
garydgregory merged PR #572:
URL: https://github.com/apache/httpcomponents-client/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876335#comment-17876335
]
ASF subversion and git services commented on HTTPCLIENT-2336:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876336#comment-17876336
]
ASF subversion and git services commented on HTTPCLIENT-2336:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876337#comment-17876337
]
ASF subversion and git services commented on HTTPCLIENT-2335:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876334#comment-17876334
]
ASF subversion and git services commented on HTTPCLIENT-2333:
garydgregory merged PR #478:
URL: https://github.com/apache/httpcomponents-core/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
[
https://issues.apache.org/jira/browse/HTTPCORE-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876338#comment-17876338
]
ASF subversion and git services commented on HTTPCORE-761:
--
Co
ok2c commented on code in PR #574:
URL:
https://github.com/apache/httpcomponents-client/pull/574#discussion_r1729322551
##
httpclient5/pom.xml:
##
@@ -123,7 +123,7 @@
https://publicsuffix.org/list/effective_tld_names.dat
-
ok2c closed pull request #571: Include Mozilla public suffix list file directly
URL: https://github.com/apache/httpcomponents-client/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
garydgregory merged PR #474:
URL: https://github.com/apache/httpcomponents-core/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
garydgregory commented on code in PR #574:
URL:
https://github.com/apache/httpcomponents-client/pull/574#discussion_r1729469107
##
httpclient5/pom.xml:
##
@@ -123,7 +123,7 @@
https://publicsuffix.org/list/effective_tld_names.dat
-
garydgregory merged PR #475:
URL: https://github.com/apache/httpcomponents-core/pull/475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
garydgregory merged PR #477:
URL: https://github.com/apache/httpcomponents-core/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
garydgregory merged PR #479:
URL: https://github.com/apache/httpcomponents-core/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
49 matches
Mail list logo
