massdosage commented on code in PR #571:
URL:
https://github.com/apache/httpcomponents-client/pull/571#discussion_r1728971628
##########
httpclient5/src/test/java/org/apache/hc/client5/http/psl/TestPublicSuffixMatcher.java:
##########
@@ -40,8 +42,7 @@
class TestPublicSuffixMatcher {
private static final String SOURCE_FILE = "suffixlistmatcher.txt";
- private static final String PUBLIC_SUFFIX_LIST_FILE =
"mozilla/public-suffix-list.txt";
Review Comment:
OK, yeah, it's been ages since I touched Windows so I wasn't sure. In much
earlier versions of Java this would have been an issue. If we instead prefer
including the mozilla file in this repo like we do with `SOURCE_FILE` I can
adjust this PR to do that instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
