Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Oleg Kalnichevski
On Wed, 2024-08-21 at 18:48 -0400, Gary Gregory wrote: > Ah, I see the comment in out GH GI file. How about marking a Windows > build > with the experimental flag? Would anyone mind that? > I doubt this issue is Windows / OS specific. Please run `mvn clean generate-resources` to ensure the lates

Re: [PR] DeflateInputStream extends FilterInputStream [httpcomponents-client]

2024-08-22 Thread via GitHub
garydgregory merged PR #569: URL: https://github.com/apache/httpcomponents-client/pull/569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Gary Gregory
Hm, running `mvn clean generate-resources`didn't help. My git repo is clean after running the command. Gary On Thu, Aug 22, 2024, 5:02 AM Oleg Kalnichevski wrote: > On Wed, 2024-08-21 at 18:48 -0400, Gary Gregory wrote: > > Ah, I see the comment in out GH GI file. How about marking a Windows >

[PR] ConsumableInputStream extends FilterInputStream [httpcomponents-client]

2024-08-22 Thread via GitHub
garydgregory opened a new pull request, #570: URL: https://github.com/apache/httpcomponents-client/pull/570 `ConsumableInputStream` extends `FilterInputStream` - Reduces boilerplace in the test fixture - Use Mockito like the rest of the updated test -- This is an automated messag

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Oleg Kalnichevski
On Thu, 2024-08-22 at 08:26 -0400, Gary Gregory wrote: > Hm, running `mvn clean generate-resources`didn't help. My git repo is > clean > after running the command. > Feel free to contact the original contributor of the test case: https://github.com/apache/httpcomponents-client/pull/566 Oleg >

Re: [PR] Update PublicSuffixMatcher to use "formal algorithm" [httpcomponents-client]

2024-08-22 Thread via GitHub
garydgregory commented on PR #566: URL: https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2304679987 Hello @massdosage This PR apparently is reference on the ML at https://lists.apache.org/thread/mwhzx1n9v3317fj6x050nkozvdkszvo9 as the breaking change for local

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Gary Gregory
On Thu, Aug 22, 2024 at 8:58 AM Oleg Kalnichevski wrote: > > On Thu, 2024-08-22 at 08:26 -0400, Gary Gregory wrote: > > Hm, running `mvn clean generate-resources`didn't help. My git repo is > > clean > > after running the command. > > > > Feel free to contact the original contributor of the test c

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Adrian Woodhead
I'll have a proper look tomorrow but I ran "mvn generate-resources" from the "httpclient5" folder, not the top-level project root and it worked for me if I then did "mvn package". Does that work for you or does it also fail? On Thu, 22 Aug 2024 at 18:52, Gary Gregory wrote: > On Thu, Aug 22, 202

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Gary D. Gregory
Hello Adrian, >From the httpclient5 directory, I ran mvn clean generate-resources && mvn package and it failed just the same :-( I wonder what's special about my setup unless it's an edge case... Gary On 2024/08/22 21:04:45 Adrian Woodhead wrote: > I'll have a proper look tomorrow but I ran "

[jira] [Commented] (HTTPCLIENT-1625) Completely overhaul GSS-API-based authentication backend

2024-08-22 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876177#comment-17876177 ] Istvan Toth commented on HTTPCLIENT-1625: - I have a somewhat working impleme

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Adrian Woodhead
Strange, what happens if you run mvn with the "-X" flag to get debugging information. I see something along these lines towards the end of the build if I've cleaned out "download-maven-plugin" cache to force a fresh download: [DEBUG] Loading mojo > com.googlecode.maven-download-plugin:download-mav

Re: [PR] Update PublicSuffixMatcher to use "formal algorithm" [httpcomponents-client]

2024-08-22 Thread via GitHub
massdosage commented on PR #566: URL: https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2306422398 Let's discuss on the dev mailing list to keep things in one place if that's OK? -- This is an automated message from the Apache Git Service. To respond to the message, p