Hello Adrian, >From the httpclient5 directory, I ran
mvn clean generate-resources && mvn package and it failed just the same :-( I wonder what's special about my setup unless it's an edge case... Gary On 2024/08/22 21:04:45 Adrian Woodhead wrote: > I'll have a proper look tomorrow but I ran "mvn generate-resources" from > the "httpclient5" folder, not the top-level project root and it worked for > me if I then did "mvn package". Does that work for you or does it also fail? > > On Thu, 22 Aug 2024 at 18:52, Gary Gregory <garydgreg...@gmail.com> wrote: > > > On Thu, Aug 22, 2024 at 8:58 AM Oleg Kalnichevski <ol...@apache.org> > > wrote: > > > > > > On Thu, 2024-08-22 at 08:26 -0400, Gary Gregory wrote: > > > > Hm, running `mvn clean generate-resources`didn't help. My git repo is > > > > clean > > > > after running the command. > > > > > > > > > > Feel free to contact the original contributor of the test case: > > > > > > https://github.com/apache/httpcomponents-client/pull/566 > > > > Thank you for the link, Oleg. I commented there. > > > > Gary > > > > > > > > Oleg > > > > > > > > > > Gary > > > > > > > > On Thu, Aug 22, 2024, 5:02 AM Oleg Kalnichevski <ol...@apache.org> > > > > wrote: > > > > > > > > > On Wed, 2024-08-21 at 18:48 -0400, Gary Gregory wrote: > > > > > > Ah, I see the comment in out GH GI file. How about marking a > > > > > > Windows > > > > > > build > > > > > > with the experimental flag? Would anyone mind that? > > > > > > > > > > > > > > > > I doubt this issue is Windows / OS specific. > > > > > > > > > > Please run `mvn clean generate-resources` to ensure the latest > > > > > public > > > > > suffix list file got downloaded from the Mozilla site and see if > > > > > that > > > > > solves the problem. > > > > > > > > > > Oleg > > > > > > > > > > > > > > > > Gary > > > > > > > > > > > > On Wed, Aug 21, 2024, 6:12 PM Gary D. Gregory > > > > > > <ggreg...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > With the HEAD of git master, I get: > > > > > > > > > > > > > > [INFO] ------------------------------------------------------- > > > > > > > [INFO] T E S T S > > > > > > > [INFO] ------------------------------------------------------- > > > > > > > [INFO] Running > > > > > > > org.apache.hc.client5.http.psl.TestPublicSuffixMatcher > > > > > > > [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time > > > > > > > elapsed: > > > > > > > 0.944 s <<< FAILURE! - in > > > > > > > org.apache.hc.client5.http.psl.TestPublicSuffixMatcher > > > > > > > [ERROR] > > > > > > > org.apache.hc.client5.http.psl.TestPublicSuffixMatcher.testGetD > > > > > > > omai > > > > > > > nRootPublicSuffixList > > > > > > > Time elapsed: 0.019 s <<< FAILURE! > > > > > > > org.opentest4j.AssertionFailedError: expected: <null> but was: > > > > > > > <uk.com> > > > > > > > at > > > > > > > org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFa > > > > > > > ilur > > > > > > > eBuilder.java:151) > > > > > > > at > > > > > > > org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(Ass > > > > > > > erti > > > > > > > onFailureBuilder.java:132) > > > > > > > at > > > > > > > org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.ja > > > > > > > va:1 > > > > > > > 97) > > > > > > > at > > > > > > > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.ja > > > > > > > va:1 > > > > > > > 82) > > > > > > > at > > > > > > > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.ja > > > > > > > va:1 > > > > > > > 77) > > > > > > > at > > > > > > > org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1 > > > > > > > 145) > > > > > > > at > > > > > > > org.apache.hc.client5.http.psl.TestPublicSuffixMatcher.checkPub > > > > > > > licS > > > > > > > uffix(TestPublicSuffixMatcher.java:171) > > > > > > > at > > > > > > > org.apache.hc.client5.http.psl.TestPublicSuffixMatcher.testGetD > > > > > > > omai > > > > > > > nRootPublicSuffixList(TestPublicSuffixMatcher.java:208) > > > > > > > at java.lang.reflect.Method.invoke(Method.java:498) > > > > > > > at java.util.ArrayList.forEach(ArrayList.java:1259) > > > > > > > at java.util.ArrayList.forEach(ArrayList.java:1259) > > > > > > > > > > > > > > Running on: > > > > > > > > > > > > > > Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256) > > > > > > > Maven home: C:\java\apache-maven-3.9.8 > > > > > > > Java version: 17.0.12, vendor: Eclipse Adoptium, runtime: > > > > > > > C:\Program > > > > > > > Files\Eclipse Adoptium\jdk-17.0.12.7-hotspot > > > > > > > Default locale: en_US, platform encoding: Cp1252 > > > > > > > OS name: "windows 10", version: "10.0", arch: "amd64", family: > > > > > > > "windows" > > > > > > > > > > > > > > What do you think about adding a Windows build to GitHub CI. > > > > > > > > > > > > > > Gary > > > > > > > > > > > > > > --------------------------------------------------------------- > > > > > > > ---- > > > > > > > -- > > > > > > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > > > > > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------- > > > > > -- > > > > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > > > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
