Re: [PR] Input streams returned by DecompressingEntity.getContent() should support mark(int) and reset() [httpcomponents-client]

2024-08-17 Thread via GitHub
ok2c commented on code in PR #567: URL: https://github.com/apache/httpcomponents-client/pull/567#discussion_r1720742876 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/LazyDecompressingInputStream.java: ## @@ -83,19 +83,29 @@ public boolean markSupported() {

Re: [PR] Update PublicSuffixMatcher to use "formal algorithm" [httpcomponents-client]

2024-08-17 Thread via GitHub
ok2c commented on PR #566: URL: https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2294806545 @massdosage These are the additional changes that I have made on top of your pull request: ok2c/httpcomponents-client@77aefb63901e242e28681172423bae462380d5f7. Please take a lo

Re: [PR] Input streams returned by DecompressingEntity.getContent() should support mark(int) and reset() [httpcomponents-client]

2024-08-17 Thread via GitHub
garydgregory commented on code in PR #567: URL: https://github.com/apache/httpcomponents-client/pull/567#discussion_r1720766623 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/LazyDecompressingInputStream.java: ## @@ -83,19 +83,29 @@ public boolean markSupported(

Re: [PR] Input streams returned by DecompressingEntity.getContent() should support mark(int) and reset() [httpcomponents-client]

2024-08-17 Thread via GitHub
garydgregory commented on code in PR #567: URL: https://github.com/apache/httpcomponents-client/pull/567#discussion_r1720769799 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/LazyDecompressingInputStream.java: ## @@ -83,19 +83,29 @@ public boolean markSupported(

Re: [PR] Input streams returned by DecompressingEntity.getContent() should support mark(int) and reset() [httpcomponents-client]

2024-08-17 Thread via GitHub
ok2c commented on code in PR #567: URL: https://github.com/apache/httpcomponents-client/pull/567#discussion_r1720782617 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/LazyDecompressingInputStream.java: ## @@ -83,19 +83,29 @@ public boolean markSupported() {

[jira] [Commented] (HTTPCLIENT-1625) Completely overhaul GSS-API-based authentication backend

2024-08-17 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874512#comment-17874512 ] Istvan Toth commented on HTTPCLIENT-1625: - Hi [~olegk] [~michael-o]. I am w

Re: [PR] Input streams returned by DecompressingEntity.getContent() should support mark(int) and reset() [httpcomponents-client]

2024-08-17 Thread via GitHub
garydgregory merged PR #567: URL: https://github.com/apache/httpcomponents-client/pull/567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

Re: [PR] Input streams returned by DecompressingEntity.getContent() should support mark(int) and reset() [httpcomponents-client]

2024-08-17 Thread via GitHub
garydgregory commented on code in PR #567: URL: https://github.com/apache/httpcomponents-client/pull/567#discussion_r1720782879 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/LazyDecompressingInputStream.java: ## @@ -83,19 +83,29 @@ public boolean markSupported(

[jira] [Commented] (HTTPCLIENT-1625) Completely overhaul GSS-API-based authentication backend

2024-08-17 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874514#comment-17874514 ] Oleg Kalnichevski commented on HTTPCLIENT-1625: --- > As already noted, t

[PR] Reimplement LoggingInputStream as a FilterInputStream [httpcomponents-client]

2024-08-17 Thread via GitHub
garydgregory opened a new pull request, #568: URL: https://github.com/apache/httpcomponents-client/pull/568 - No need to track delegate, it's in super - Constructor shouldn't be public since the class is package-private - Normalize message in `available()` to match other methods - In