garydgregory commented on code in PR #567:
URL:
https://github.com/apache/httpcomponents-client/pull/567#discussion_r1720766623
##########
httpclient5/src/main/java/org/apache/hc/client5/http/entity/LazyDecompressingInputStream.java:
##########
@@ -83,19 +83,29 @@ public boolean markSupported() {
@Override
public int available() throws IOException {
- initWrapper();
- return wrapperStream.available();
+ return initWrapper().available();
}
@Override
public void close() throws IOException {
try {
- if (wrapperStream != null) {
- wrapperStream.close();
- }
+ Closer.close(wrapperStream);
} finally {
- wrappedStream.close();
+ super.close();
+ }
+ }
+
+ @Override
+ public synchronized void mark(final int readlimit) {
Review Comment:
Hm, I guess the whole class isn't thread-safe to start with due to
`initWrapper()`. I'll rework the PR.
These `synchronized` come from the Java 8, 11, and 17 contracts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
