Re: [PR] HTTPCORE-766: redesign of server-side request routing [httpcomponents-core]

2024-06-02 Thread via GitHub
erik-wramner commented on PR #467: URL: https://github.com/apache/httpcomponents-core/pull/467#issuecomment-2143943997 Overall this looks fine, though it was a much larger change than I had anticipated. I only have one question. The code uses `UriPatternType.URI_PATTERN` and the other type

Re: [PR] HTTPCORE-766: redesign of server-side request routing [httpcomponents-core]

2024-06-02 Thread via GitHub
ok2c commented on PR #467: URL: https://github.com/apache/httpcomponents-core/pull/467#issuecomment-2144011481 > Overall this looks fine, though it was a much larger change than I had anticipated. @erik-wramner True. I ended up rewriting the entire request routing layer as a result