ok2c commented on PR #467: URL: https://github.com/apache/httpcomponents-core/pull/467#issuecomment-2144011481
> Overall this looks fine, though it was a much larger change than I had anticipated. @erik-wramner True. I ended up rewriting the entire request routing layer as a result. > I only have one question. The code uses `UriPatternType.URI_PATTERN` and the other types have been deprecated. I don't quite follow the reasoning there? It won't affect our code, but I don't get why that was changed. That is not the case. All existing `UriPatternType` are not deprecated but their matcher implementations have been made internal. They should have never been made public in the first place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
