[jira] [Commented] (HTTPCLIENT-2306) What is different in PoolingHttpClientConnectionManager from MultiThreadedHttpConnectionManager?

2023-11-21 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788350#comment-17788350 ] Oleg Kalnichevski commented on HTTPCLIENT-2306: --- I _suspect_ the probl

[jira] [Resolved] (HTTPCLIENT-2306) What is different in PoolingHttpClientConnectionManager from MultiThreadedHttpConnectionManager?

2023-11-21 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2306. --- Resolution: Invalid > What is different in PoolingHttpClientConnectionMa

Re: [PR] Enforce UTF-8 Encoding in BasicSchemeFactory for RFC 7617 Compliance [httpcomponents-client]

2023-11-21 Thread via GitHub
arturobernalg merged PR #506: URL: https://github.com/apache/httpcomponents-client/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [PR] Enforce UTF-8 Encoding in BasicSchemeFactory for RFC 7617 Compliance [httpcomponents-client]

2023-11-21 Thread via GitHub
reschke commented on PR #506: URL: https://github.com/apache/httpcomponents-client/pull/506#issuecomment-1821378316 FWIW, RFC 7617 does *not* require UTF-8, because back when it was written, that was considered a breaking change, as many UAs defaulted to ISO-8859. That said, UAs have

Re: [PR] Enforce UTF-8 Encoding in BasicSchemeFactory for RFC 7617 Compliance [httpcomponents-client]

2023-11-21 Thread via GitHub
arturobernalg commented on PR #506: URL: https://github.com/apache/httpcomponents-client/pull/506#issuecomment-1821420699 > FWIW, RFC 7617 does _not_ require UTF-8, because back when it was written, that was considered a breaking change, as many UAs defaulted to ISO-8859. > > That sa

Re: [PR] Enforce UTF-8 Encoding in BasicSchemeFactory for RFC 7617 Compliance [httpcomponents-client]

2023-11-21 Thread via GitHub
reschke commented on PR #506: URL: https://github.com/apache/httpcomponents-client/pull/506#issuecomment-1821438554 I may be missing something, but my understandig was that the "charset" parameter wasn't supported in the first place. (Note that it was *introduced* in RFC 7617, and never wa

Re: [PR] Enforce UTF-8 Encoding in BasicSchemeFactory for RFC 7617 Compliance [httpcomponents-client]

2023-11-21 Thread via GitHub
stanio commented on PR #506: URL: https://github.com/apache/httpcomponents-client/pull/506#issuecomment-1821459427 > This PR's changes to the charset field adhere to RFC 7617, specifically section [2.1](https://datatracker.ietf.org/doc/html/rfc7617#section-2.1) ensuring compliance with '

Re: [PR] Enforce UTF-8 Encoding in BasicSchemeFactory for RFC 7617 Compliance [httpcomponents-client]

2023-11-21 Thread via GitHub
arturobernalg commented on PR #506: URL: https://github.com/apache/httpcomponents-client/pull/506#issuecomment-1821616141 > I may be missing something, but my understanding was that the "charset" parameter wasn't supported in the first place. (Note that it was _introduced_ in RFC 7617, and

Re: [PR] Enforce UTF-8 Encoding in BasicSchemeFactory for RFC 7617 Compliance [httpcomponents-client]

2023-11-21 Thread via GitHub
reschke commented on PR #506: URL: https://github.com/apache/httpcomponents-client/pull/506#issuecomment-1822202879 Ok, interesting. FWIW, the code back then allows charsets other than UTF-8; it should have ignored those. That said, have you ever seen a server send that? -- This i