arturobernalg commented on PR #506: URL: https://github.com/apache/httpcomponents-client/pull/506#issuecomment-1821616141
> I may be missing something, but my understanding was that the "charset" parameter wasn't supported in the first place. (Note that it was _introduced_ in RFC 7617, and never was allowed to specify anything but UTF-8). > > RFC 7617's revision will likely deprecate or remove this parameter, because a) it was never widely implemented and b) it doesn't appear to be needed anymore. @reschke our implementation actively uses the `charset` parameter in line with RFC 7617, defaulting to `UTF-8` for encoding credentials, demonstrating its practical utility despite limited widespread adoption. Please take a look https://github.com/apache/httpcomponents-client/blob/5.4.x/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicScheme.java#L225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
