rschmitt merged PR #637:
URL: https://github.com/apache/httpcomponents-client/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@h
t;);
+return Implementation.JDK;
+} catch (final ClassNotFoundException e2) {
+LOG.debug("No Unix Domain Socket implementation found");
+return Implementation.NONE;
+ }
+}
+}
+
+/**
+ * Checks if Unix Domain S
t;);
+return Implementation.JDK;
+} catch (final ClassNotFoundException e2) {
+LOG.debug("No Unix Domain Socket implementation found");
+return Implementation.NONE;
+ }
+}
+}
+
+/**
+ * Checks if Unix
rschmitt commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2124663608
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/extension/sync/UnixDomainProxyServer.java:
##
@@ -0,0 +1,136 @@
+/*
+ * ===
michael-o commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2124557880
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/extension/sync/UnixDomainProxyServer.java:
##
@@ -0,0 +1,136 @@
+/*
+ * ==
michael-o commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2124545577
##
pom.xml:
##
@@ -163,6 +164,12 @@
${rxjava.version}
test
+
+com.kohlschutter.junixsocket
+junixsocket-c
rschmitt commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2124336385
##
httpclient5/src/test/java/org/apache/hc/client5/http/TestHttpRoute.java:
##
@@ -454,4 +458,44 @@ void testImmutable() throws CloneNotSupportedException
rschmitt commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2124344698
##
pom.xml:
##
@@ -163,6 +164,12 @@
${rxjava.version}
test
+
+com.kohlschutter.junixsocket
+junixsocket-co
rschmitt commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2124339540
##
httpclient5/src/test/java/org/apache/hc/client5/http/examples/UnixDomainSocket.java:
##
@@ -0,0 +1,75 @@
+/*
+ * ==
rschmitt commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2124324022
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/extension/sync/UnixDomainProxyServer.java:
##
@@ -0,0 +1,136 @@
+/*
+ * ===
nd addresses.
+private static SocketAddress createUnixSocketAddress(final Path
socketPath) {
+try {
+final Class addressClass =
Class.forName("java.net.UnixDomainSocketAddress");
+final Method ofMethod = addressClass.getMethod("of", Path.class);
+
michael-o commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2120898415
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/extension/sync/UnixDomainProxyServer.java:
##
@@ -0,0 +1,136 @@
+/*
+ * ==
ok2c commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2118948098
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java:
##
@@ -104,7 +107,15 @@ public Future connect(
OK, I'll do it.
On Fri, May 30, 2025 at 2:27 AM Oleg Kalnichevski wrote:
>
> On Thu, 2025-05-29 at 15:44 -0700, Ryan Schmitt wrote:
> > Do we have any existing integration test coverage for socket and
> > connection timeouts? I only see mock-based unit tests.
> >
>
> We do not. Timeouts are quite
rschmitt commented on PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#issuecomment-2923274326
I suggest reading the diff from the bottom up. It just flows more logically
that way: example code, connection changes, routing changes, integration test
changes.
--
This
ok2c commented on PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#issuecomment-2921803037
@rschmitt It is a big one. Please allow me a few days to get around to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
On Thu, 2025-05-29 at 15:44 -0700, Ryan Schmitt wrote:
> Do we have any existing integration test coverage for socket and
> connection timeouts? I only see mock-based unit tests.
>
We do not. Timeouts are quite difficult to test reliably and up to now
no one stepped forth to put efforts into buil
Do we have any existing integration test coverage for socket and
connection timeouts? I only see mock-based unit tests.
On Fri, Apr 25, 2025 at 1:04 PM Oleg Kalnichevski wrote:
>
> On Thu, 2025-04-24 at 13:04 -0700, Ryan Schmitt wrote:
> > > UDS looks like a route / connection property, not a req
rschmitt opened a new pull request, #637:
URL: https://github.com/apache/httpcomponents-client/pull/637
This change adds Unix domain socket support. The sync client uses
JUnixSocket, which provides synchronous UDS support through the legacy
`java.net.Socket` API; the async client uses the
On Thu, 2025-04-24 at 13:04 -0700, Ryan Schmitt wrote:
> > UDS looks like a route / connection property, not a request one. So
> > RequestConfig would likely be a bad choice. ConnectionConfig would
> > make
> > a better choice in my option. Better yet, it could be a method, say
> > #useUnixSocket,
On 2025/04/21 17:40:01 Ryan Schmitt wrote:
> I've got Apache client 5.4.3 working with a custom connection operator
> that implements UDS support. I want to upstream this as a proper
> feature, since it's significantly more efficient than localhost. I
> want to discuss the design of this feature a
> UDS looks like a route / connection property, not a request one. So
> RequestConfig would likely be a bad choice. ConnectionConfig would make
> a better choice in my option. Better yet, it could be a method, say
> #useUnixSocket, in the `PoolingHttpClientConnectionManagerBuilder` that
> would mak
On Mon, 2025-04-21 at 10:40 -0700, Ryan Schmitt wrote:
> I've got Apache client 5.4.3 working with a custom connection
> operator
> that implements UDS support. I want to upstream this as a proper
> feature, since it's significantly more efficient than localhost. I
> want to discuss the design of t
UDS = Unix Domain Socket
On Tue, Apr 22, 2025 at 2:07 PM Gary Gregory wrote:
>
> Hi all,
>
> I'm not sure how to ask this question, so I'll be straightforward: If
> UDS is https://en.wikipedia.org/wiki/Unified_Diagnostic_Services, why
> should it be in an HTTP-focused project?
>
> I might have mi
Hi all,
I'm not sure how to ask this question, so I'll be straightforward: If
UDS is https://en.wikipedia.org/wiki/Unified_Diagnostic_Services, why
should it be in an HTTP-focused project?
I might have missed some context in a previous message of course.
Gary
On Mon, Apr 21, 2025 at 1:40 PM Rya
I've got Apache client 5.4.3 working with a custom connection operator
that implements UDS support. I want to upstream this as a proper
feature, since it's significantly more efficient than localhost. I
want to discuss the design of this feature a bit; since it's a non-TCP
transport layer, we have
26 matches
Mail list logo
