ok2c commented on code in PR #637:
URL:
https://github.com/apache/httpcomponents-client/pull/637#discussion_r2118948098
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java:
##########
@@ -104,7 +107,15 @@ public Future<ManagedAsyncClientConnection> connect(
Args.notNull(endpointHost, "Host");
final ComplexFuture<ManagedAsyncClientConnection> future = new
ComplexFuture<>(callback);
final HttpHost remoteEndpoint = RoutingSupport.normalize(endpointHost,
schemePortResolver);
- final InetAddress remoteAddress = endpointHost.getAddress();
+ final Path unixDomainSocket = ((HttpClientContext)
context).getRequestConfigOrDefault().getUnixDomainSocket();
Review Comment:
@rschmitt This is quite ugly. Can we introduce a new default `#connect`
method here the same way as with `HttpClientConnectionOperator`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
