Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Adrian Woodhead
Agreed, how about the changes I just pushed to https://github.com/apache/httpcomponents-client/pull/571? On Fri, 23 Aug 2024 at 15:25, Gary D. Gregory wrote: > On 2024/08/23 13:16:24 Oleg Kalnichevski wrote: > > On Fri, 2024-08-23 at 13:04 +, Gary D. Gregory wrote: > > > Problem solved: I ma

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Gary D. Gregory
On 2024/08/23 13:16:24 Oleg Kalnichevski wrote: > On Fri, 2024-08-23 at 13:04 +, Gary D. Gregory wrote: > > Problem solved: I manually deleted the folder > > C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin > > > > Our clean goal needs to do that... > > > > Andrian,Gary > > The

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Gary D. Gregory
How about using true in the plugin config? https://maven-download-plugin.github.io/maven-download-plugin/docsite/1.9.0/wget-mojo.html That works here. Gary On 2024/08/23 13:16:24 Oleg Kalnichevski wrote: > On Fri, 2024-08-23 at 13:04 +, Gary D. Gregory wrote: > > Problem solved: I manually

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Adrian Woodhead
Ah, I was wondering if the cache had an older version, good find. Instead of fetching the latest version via mvn I could include the whole file in git, we'd just have to update it if/when something in there changed that impacted a test but that probably wouldn't happen too often and I'd imagine wo

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Oleg Kalnichevski
On Fri, 2024-08-23 at 13:04 +, Gary D. Gregory wrote: > Problem solved: I manually deleted the folder > C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin > > Our clean goal needs to do that... > Andrian,Gary The only proper way of fixing the problem is including the file (or sub

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Gary D. Gregory
Problem solved: I manually deleted the folder C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin Our clean goal needs to do that... Gary On 2024/08/23 12:44:28 "Gary D. Gregory" wrote: > I updated the Maven download plugin to its current version without a change > in outcome :-( >

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Adrian Woodhead
What is the exact error you are getting? Is it the NPE from that file not being found (that's what I was assuming) or is it something completely different? On Fri, 23 Aug 2024 at 14:45, Gary D. Gregory wrote: > FYI: I disabled my VPN client and the test still fails, so it's not that. > > Gary >

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Gary D. Gregory
FYI: I disabled my VPN client and the test still fails, so it's not that. Gary On 2024/08/23 12:44:28 "Gary D. Gregory" wrote: > I updated the Maven download plugin to its current version without a change > in outcome :-( > > There must be something odd on my end to get this one test to fail bu

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Gary D. Gregory
I updated the Maven download plugin to its current version without a change in outcome :-( There must be something odd on my end to get this one test to fail but ... what? TY Gary On 2024/08/23 12:27:43 "Gary D. Gregory" wrote: > On 2024/08/23 11:58:54 Adrian Woodhead wrote: > > OK, so it's dow

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Gary D. Gregory
On 2024/08/23 11:58:54 Adrian Woodhead wrote: > OK, so it's downloaded the file successfully, in this case it's using a > copy from the plugin's local cache: > > [DEBUG] Got from cache: > C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin\effective_tld_names.dat_21b8d15562229f61c1172508

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Adrian Woodhead
I think this will do the trick, PTAL and let me know: https://github.com/apache/httpcomponents-client/pull/571 On Fri, 23 Aug 2024 at 13:58, Adrian Woodhead < adrian.woodh...@humansecurity.com> wrote: > OK, so it's downloaded the file successfully, in this case it's using a > copy from the plug

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Adrian Woodhead
OK, so it's downloaded the file successfully, in this case it's using a copy from the plugin's local cache: [DEBUG] Got from cache: C:\Users\ggregory\.m2\repository\.cache\download-maven-plugin\effective_tld_names.dat_21b8d15562229f61c11725080a5f7911 Can you confirm that you have this file: http

Re: TestPublicSuffixMatcher failing locally

2024-08-23 Thread Gary D. Gregory
Hi Andrian: Here is my output: https://gist.github.com/garydgregory/071c34698b9b702c8c28efc98e0c526a Gary On 2024/08/23 06:57:18 Adrian Woodhead wrote: > Strange, what happens if you run mvn with the "-X" flag to get debugging > information. I see something along these lines towards the end of

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Adrian Woodhead
Strange, what happens if you run mvn with the "-X" flag to get debugging information. I see something along these lines towards the end of the build if I've cleaned out "download-maven-plugin" cache to force a fresh download: [DEBUG] Loading mojo > com.googlecode.maven-download-plugin:download-mav

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Gary D. Gregory
Hello Adrian, >From the httpclient5 directory, I ran mvn clean generate-resources && mvn package and it failed just the same :-( I wonder what's special about my setup unless it's an edge case... Gary On 2024/08/22 21:04:45 Adrian Woodhead wrote: > I'll have a proper look tomorrow but I ran "

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Adrian Woodhead
I'll have a proper look tomorrow but I ran "mvn generate-resources" from the "httpclient5" folder, not the top-level project root and it worked for me if I then did "mvn package". Does that work for you or does it also fail? On Thu, 22 Aug 2024 at 18:52, Gary Gregory wrote: > On Thu, Aug 22, 202

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Gary Gregory
On Thu, Aug 22, 2024 at 8:58 AM Oleg Kalnichevski wrote: > > On Thu, 2024-08-22 at 08:26 -0400, Gary Gregory wrote: > > Hm, running `mvn clean generate-resources`didn't help. My git repo is > > clean > > after running the command. > > > > Feel free to contact the original contributor of the test c

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Oleg Kalnichevski
On Thu, 2024-08-22 at 08:26 -0400, Gary Gregory wrote: > Hm, running `mvn clean generate-resources`didn't help. My git repo is > clean > after running the command. > Feel free to contact the original contributor of the test case: https://github.com/apache/httpcomponents-client/pull/566 Oleg >

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Gary Gregory
Hm, running `mvn clean generate-resources`didn't help. My git repo is clean after running the command. Gary On Thu, Aug 22, 2024, 5:02 AM Oleg Kalnichevski wrote: > On Wed, 2024-08-21 at 18:48 -0400, Gary Gregory wrote: > > Ah, I see the comment in out GH GI file. How about marking a Windows >

Re: TestPublicSuffixMatcher failing locally

2024-08-22 Thread Oleg Kalnichevski
On Wed, 2024-08-21 at 18:48 -0400, Gary Gregory wrote: > Ah, I see the comment in out GH GI file. How about marking a Windows > build > with the experimental flag? Would anyone mind that? > I doubt this issue is Windows / OS specific. Please run `mvn clean generate-resources` to ensure the lates

Re: TestPublicSuffixMatcher failing locally

2024-08-21 Thread Gary Gregory
Ah, I see the comment in out GH GI file. How about marking a Windows build with the experimental flag? Would anyone mind that? Gary On Wed, Aug 21, 2024, 6:12 PM Gary D. Gregory wrote: > With the HEAD of git master, I get: > > [INFO] --- > [IN

TestPublicSuffixMatcher failing locally

2024-08-21 Thread Gary D. Gregory
With the HEAD of git master, I get: [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hc.client5.http.psl.TestPublicSuffixMatcher [ERROR] Tests run: 6, Failures: 1, Errors: 0, Sk