arturobernalg merged PR #517:
URL: https://github.com/apache/httpcomponents-core/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
arturobernalg commented on code in PR #517:
URL:
https://github.com/apache/httpcomponents-core/pull/517#discussion_r1997284724
##
httpcore5/src/test/java/org/apache/hc/core5/net/TestURIBuilder.java:
##
@@ -617,7 +618,7 @@ void testHttpHost() throws Exception {
@Test
PascalSchumacher commented on code in PR #517:
URL:
https://github.com/apache/httpcomponents-core/pull/517#discussion_r1996974475
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -175,6 +203,22 @@ public URIBuilder setCharset(final Charset charset) {
ok2c commented on code in PR #517:
URL:
https://github.com/apache/httpcomponents-core/pull/517#discussion_r1996872461
##
httpcore5/src/test/java/org/apache/hc/core5/net/TestURIBuilder.java:
##
@@ -472,6 +472,7 @@ void testFragmentEncoding() throws Exception {
.