Re: [PR] Avoid unnecessary volatile reads [httpcomponents-core]

2024-04-11 Thread via GitHub
ok2c commented on PR #463: URL: https://github.com/apache/httpcomponents-core/pull/463#issuecomment-2049173346 Superseded by 45b6138676a568b3c357c0ee5c802dbc964cff75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Avoid unnecessary volatile reads [httpcomponents-core]

2024-04-11 Thread via GitHub
ok2c closed pull request #463: Avoid unnecessary volatile reads URL: https://github.com/apache/httpcomponents-core/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Avoid unnecessary volatile reads [httpcomponents-core]

2024-03-30 Thread via GitHub
ok2c commented on PR #463: URL: https://github.com/apache/httpcomponents-core/pull/463#issuecomment-2028019357 @rhernandez35 Could you please correct style check violations and ideally split the change-set into two separate commits? Looks good otherwise. -- This is an automated message f

[PR] Avoid unnecessary volatile reads [httpcomponents-core]

2024-03-29 Thread via GitHub
rhernandez35 opened a new pull request, #463: URL: https://github.com/apache/httpcomponents-core/pull/463 This commit avoids repeatedly reading volatile instance fields in ClientH2PrefaceHandler and AbstractCharDataConsumer. This is important for both performance and correctness, especially