rhernandez35 opened a new pull request, #463: URL: https://github.com/apache/httpcomponents-core/pull/463
This commit avoids repeatedly reading volatile instance fields in ClientH2PrefaceHandler and AbstractCharDataConsumer. This is important for both performance and correctness, especially in the latter class. If a caller called `setCharset` while `getCharsetDecoder()` was being called on another thread, the second thread could see NullPointerExceptions after the `charsetDecoder` instance was unexpectedly nulled out between the null check and the return of `this.charsetDecoder` in `getCharsetDecoder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
