Preview Release of the AWS SDK Java 2.x HTTP Client built on Apache HttpClient 5.5.x

2025-07-23 Thread Ryan Schmitt
I saw that this was just announced: https://aws.amazon.com/blogs/developer/preview-release-of-theaws-sdk-java-2-x-http-client-built-on-apache-httpclient-5-5-x/ Currently, both versions of the AWS Java SDK still default to HttpClient 4.x, except for async clients in V2 which default to Netty. It l

Re: HttpCore 5.4-alpha1 soon?

2025-07-18 Thread Ryan Schmitt
I have no further plans at the moment, but I'm also behind on releasing the changes. I've had to roll back the 5.4 client twice now, mostly for spurious reasons (except for the validateAfterInactivity bug, which was rough). I'd like to get client 5.4.4 and then 5.5 released and listen for further b

Re: [DISCUSS] Migrate from Jira to GitHub for issue tracking?

2025-07-09 Thread Ryan Schmitt
I think it's a good idea. Why create additional friction for bug reports? On Sat, Jul 5, 2025 at 9:08 AM Oleg Kalnichevski wrote: > > Folks > > How would feel about the idea of migrating off Jira to GitHub for > project issue tracking? > > We do not use any of Jira's advanced project management f

Re: setValidateAfterInactivity and PoolingAsyncClientConnectionManager

2025-07-09 Thread Ryan Schmitt
nting with higher values. On Fri, Jul 4, 2025 at 10:43 AM Oleg Kalnichevski wrote: > > On 2025-07-04 18:59, Ryan Schmitt wrote: > > > Evidently my JEP380 SocketChannel->Socket adapter is broken on > > Windows. If I revert 97703d901 the tests run fine on my Windows > &g

Re: setValidateAfterInactivity and PoolingAsyncClientConnectionManager

2025-07-04 Thread Ryan Schmitt
025 at 3:07 AM Oleg Kalnichevski wrote: > > On 2025-07-02 20:55, Ryan Schmitt wrote: > > > "Stale" means that the remote peer closed the connection but we don't > > know it until we try to reuse the connection, right? > > Correct. However, this can happen

Re: setValidateAfterInactivity and PoolingAsyncClientConnectionManager

2025-07-02 Thread Ryan Schmitt
handling of the sync and async clients on all the LTS versions of Java. (One reason I also want to cover the sync client is that JEP 353 might have subtly changed some behaviors on Java 13+.) On Tue, Jul 1, 2025 at 2:48 PM Oleg Kalnichevski wrote: > > On Tue, 2025-07-01 at 11:26 -0700, Ryan Sch

setValidateAfterInactivity and PoolingAsyncClientConnectionManager

2025-07-01 Thread Ryan Schmitt
What is the intended behavior of `setValidateAfterInactivity` on the async client with HTTP/1.1 connections? The current implementation is: if (poolEntry.hasConnection()) { final ManagedAsyncClientConnection connection = poolEntry.getConnection(); final TimeValue timeValue = connectionConf

Re: Socket timeout test failure

2025-06-19 Thread Ryan Schmitt
is be a clock granularity issue? > > Gary > > On Thu, Jun 19, 2025, 11:17 Ryan Schmitt wrote: >> >> There's something weird going on that's only affecting (macos-latest, >> 11). I can't reproduce it locally, even using the same JRE (Temurin >>

Re: Socket timeout test failure

2025-06-19 Thread Ryan Schmitt
Correction: the issue is in TestSocketTimeout, and we want to ensure that all three ways of setting the socket timeout take effect. The test expects a `SocketTimeoutException`, so we'll know if it stops working. On Thu, Jun 19, 2025 at 8:16 AM Ryan Schmitt wrote: > > There's

Re: Socket timeout test failure

2025-06-19 Thread Ryan Schmitt
There's something weird going on that's only affecting (macos-latest, 11). I can't reproduce it locally, even using the same JRE (Temurin 11.0.27+6) and architecture, although the environment macOS is an older version (14.7.6). The fact that the timeout is taking twice as long as it ought to on JDK

[jira] [Commented] (HTTPCORE-783) ContentType should implement equals() and hashCode()

2025-06-06 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956674#comment-17956674 ] Ryan Schmitt commented on HTTPCORE-783: --- This doesn't seem like a

Re: Change in GC behavior since 5.2.1?

2025-06-05 Thread Ryan Schmitt
tively we could add > #finalize to managed connection classes > > https://github.com/ok2c/httpcomponents-client/commit/9cd760ee282f284824a6ce86621427babf6331fc > > Oleg > > > > On Wed, 2025-06-04 at 10:52 -0700, Ryan Schmitt wrote: > > I've updated the reproducer

Use of PublicSuffixMatcher in DefaultHostnameVerifier

2025-06-04 Thread Ryan Schmitt
Why does the default hostname verifier, as returned by HttpsSupport.getDefaultHostnameVerifier(), check DNS names against the public suffix list? I don't think I've seen this behavior elsewhere, and publicsuffix.org doesn't list this as a use case: https://publicsuffix.org/learn/

Re: Change in GC behavior since 5.2.1?

2025-06-04 Thread Ryan Schmitt
rio you are trying to > test? > > Oleg > > > On Tue, 2025-06-03 at 14:15 -0700, Ryan Schmitt wrote: > > Furthermore, I can confirm that reverting ee0a10210 fixes the issue. > > No httpcore5 changes are required. > > > > On Tue, Jun 3, 2025 at 2:10 PM Ryan

Re: Change in GC behavior since 5.2.1?

2025-06-03 Thread Ryan Schmitt
Furthermore, I can confirm that reverting ee0a10210 fixes the issue. No httpcore5 changes are required. On Tue, Jun 3, 2025 at 2:10 PM Ryan Schmitt wrote: > > Here's a reproducer: > > https://github.com/rschmitt/httpcomponents-client/tree/gc-repro > > The bug is exhibited

Re: Change in GC behavior since 5.2.1?

2025-06-03 Thread Ryan Schmitt
no sockets should be listed Tue Jun 3 14:06:30 PDT 2025: Tue Jun 3 14:06:31 PDT 2025: I tested this on both macOS and Linux. On Fri, May 30, 2025 at 5:14 AM Oleg Kalnichevski wrote: > > On Fri, 2025-05-30 at 11:30 +0200, Oleg Kalnichevski wrote: > > On Thu, 2025-05-29 at

Re: Unix domain socket support

2025-05-30 Thread Ryan Schmitt
OK, I'll do it. On Fri, May 30, 2025 at 2:27 AM Oleg Kalnichevski wrote: > > On Thu, 2025-05-29 at 15:44 -0700, Ryan Schmitt wrote: > > Do we have any existing integration test coverage for socket and > > connection timeouts? I only see mock-based unit tests. > >

Re: Change in GC behavior since 5.2.1?

2025-05-29 Thread Ryan Schmitt
42182c On Thu, May 29, 2025 at 6:08 PM Ryan Schmitt wrote: > > I've been debugging a load test regression, which turned out to be > caused by a client instance leak. The test started failing on 5.4.4 > due to running out of file descriptors. What I realized is that leaked > c

Change in GC behavior since 5.2.1?

2025-05-29 Thread Ryan Schmitt
I've been debugging a load test regression, which turned out to be caused by a client instance leak. The test started failing on 5.4.4 due to running out of file descriptors. What I realized is that leaked connection pools are eventually cleaned up by garbage collection, which causes the sockets' f

Re: Unix domain socket support

2025-05-29 Thread Ryan Schmitt
Do we have any existing integration test coverage for socket and connection timeouts? I only see mock-based unit tests. On Fri, Apr 25, 2025 at 1:04 PM Oleg Kalnichevski wrote: > > On Thu, 2025-04-24 at 13:04 -0700, Ryan Schmitt wrote: > > > UDS looks like a route / connection

Re: HttpClient 5.5 GA soon (skipping BETA)?

2025-05-21 Thread Ryan Schmitt
Sorry I missed this, I've actually still been busy releasing the 5.4 upgrade internally. I have a working implementation of Unix domain socket support for the classic client and will do the async client next. I was hoping for a series of 5.5 beta releases to give me some time to put these features

Re: Unix domain socket support

2025-04-24 Thread Ryan Schmitt
> UDS looks like a route / connection property, not a request one. So > RequestConfig would likely be a bad choice. ConnectionConfig would make > a better choice in my option. Better yet, it could be a method, say > #useUnixSocket, in the `PoolingHttpClientConnectionManagerBuilder` that > would mak

Re: Unix domain socket support

2025-04-22 Thread Ryan Schmitt
ed project? > > I might have missed some context in a previous message of course. > > Gary > > On Mon, Apr 21, 2025 at 1:40 PM Ryan Schmitt wrote: > > > > I've got Apache client 5.4.3 working with a custom connection operator > > that implements UDS

Re: [VOTE] Release HttpClient 5.4.4 based on RC1

2025-04-21 Thread Ryan Schmitt
+1. Ran our internal integration tests and they all seem to pass. On Mon, Apr 21, 2025 at 12:39 PM Oleg Kalnichevski wrote: > > Please vote on releasing these packages as HttpClient 5.4.4. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding.

Re: HttpClient 5.4.4 release notes

2025-04-21 Thread Ryan Schmitt
LGTM On Sat, Apr 12, 2025 at 2:13 AM Oleg Kalnichevski wrote: > > Folks > > Please review the HttpClient 5.4.4 release notes and amend them as you > deem necessary. > > https://github.com/apache/httpcomponents-client/blob/5.4.x/RELEASE_NOTES.txt > > Oleg > > --

Unix domain socket support

2025-04-21 Thread Ryan Schmitt
I've got Apache client 5.4.3 working with a custom connection operator that implements UDS support. I want to upstream this as a proper feature, since it's significantly more efficient than localhost. I want to discuss the design of this feature a bit; since it's a non-TCP transport layer, we have

Re: Replacement for ConnectionSocketFactory

2025-04-11 Thread Ryan Schmitt
DefaultHttpClientConnectionOperator is marked @Internal, as is the associated connection manager constructor that takes an instance of it. I'll take a look at your other suggestions. On Fri, Apr 11, 2025 at 4:34 AM Oleg Kalnichevski wrote: > > On Thu, 2025-04-10 at 19:02 -0700, R

Re: Replacement for ConnectionSocketFactory

2025-04-11 Thread Ryan Schmitt
Marking incubating interfaces as @Internal as fair. I sometimes use @Deprecated, since the call sites generate warnings that way, but the @Internal convention is good to know. On Fri, Apr 11, 2025 at 3:00 PM Ryan Schmitt wrote: > > DefaultHttpClientConnectionOperator is marked @Internal,

Re: Gradle migration

2025-04-11 Thread Ryan Schmitt
Heh, I didn't think so. On Fri, Apr 11, 2025 at 9:32 AM Gary Gregory wrote: > > Please PLEASE no. > > Gary > > On Fri, Apr 11, 2025, 12:30 Ryan Schmitt wrote: > > > Are we fine with staying on Maven, or would there be any interest in > > moving to Gradle?

Gradle migration

2025-04-11 Thread Ryan Schmitt
Are we fine with staying on Maven, or would there be any interest in moving to Gradle? Please note that I am _not_ trying to start a debate about which build tool is better, or in persuading anyone that a migration is worthwhile. I'm just offering to do the work of migrating to Gradle if that's som

Re: Regression in HTTP/2 cleartext

2025-04-11 Thread Ryan Schmitt
ary > > On Tue, Apr 8, 2025, 16:49 Ryan Schmitt wrote: > > > Hi Oleg, > > > > I figured it out. The TlsConfig option indeed does work if you set it > > on a custom connection manager that you then supply to > > HttpAsyncClients::createMinimal. The way the depr

Replacement for ConnectionSocketFactory

2025-04-10 Thread Ryan Schmitt
I'm working on a long-overdue upgrade of HttpClient5 from the 5.2 series to 5.4.3. I've noticed that ConnectionSocketFactory has been deprecated. This interface was previously responsible for both creating sockets, as well as upgrading existing sockets to TLS; the latter functionality was exposed t

Re: Regression in HTTP/2 cleartext

2025-04-08 Thread Ryan Schmitt
patibility contract between different versions of httpcore and httpclient. - Ryan On Tue, Apr 8, 2025 at 1:02 PM Oleg Kalnichevski wrote: > > On Tue, 2025-04-08 at 12:44 -0700, Ryan Schmitt wrote: > > I noticed that there's a regression in httpclient 5.4's support fo

Regression in HTTP/2 cleartext

2025-04-08 Thread Ryan Schmitt
I noticed that there's a regression in httpclient 5.4's support for H2C (HTTP/2 over cleartext). Previously, you could create a minimal async client with an HttpVersionPolicy of FORCE_HTTP_2, and this option would take effect even over non-TLS connections. In 5.4, it looks like this option got move

Re: [VOTE] Release HttpCore 5.2.5 based on RC1

2024-06-27 Thread Ryan Schmitt
+1 On Thu, Jun 27, 2024 at 1:25 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.2.5. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and t

Re: HttpCore 5.3 / HttpClient 5.4 GA soon?

2024-05-22 Thread Ryan Schmitt
We've also seen some integration test failures with the latest releases, but I'm struggling to find the time to investigate. If it comes down to it, I won't vote against a release unless I have decent evidence of a regression. On Mon, May 20, 2024 at 12:42 PM Gary D. Gregory wrote: > Hi All, > >

Re: Development plans beyond HC 5.4

2024-03-13 Thread Ryan Schmitt
The way I look at it is that Apache HttpComponents is a pure Java library that implements HTTP semantics as completely and correctly as possible. The feature-richness is what distinguishes us from HttpURLConnection, and the simplicity and WORA-ness of pure Java (with a tiny dependency closure) is w

Re: [VOTE] Release HttpCore 5.3-alpha2 based on RC1

2024-02-10 Thread Ryan Schmitt
+1 On Sat, Feb 10, 2024 at 6:37 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.3-alpha2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast

Re: [VOTE] Release HttpClient 5.4-alpha1 based on RC1

2023-12-28 Thread Ryan Schmitt
+1 On Tue, Dec 26, 2023 at 6:42 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.4-alpha1. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cas

Re: [VOTE] Release HttpCore 5.3-alpha1 based on RC2

2023-12-21 Thread Ryan Schmitt
+1 On Wed, Dec 20, 2023 at 10:01 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.3-alpha1. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast

Re: [VOTE] Release HttpCore 5.3-alpha1 based on RC1

2023-12-15 Thread Ryan Schmitt
+1 On Fri, Dec 15, 2023 at 5:39 AM Oleg Kalnichevski wrote: > > Please vote on releasing these packages as HttpCore 5.3-alpha1. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cas

Re: [VOTE] Release HttpClient 5.3 based on RC1

2023-12-03 Thread Ryan Schmitt
+1 On Sun, Dec 3, 2023 at 1:43 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.3. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and th

Re: [VOTE] Release HttpCore 5.2.4 based on RC1

2023-11-24 Thread Ryan Schmitt
+1 On Fri, Nov 24, 2023 at 11:12 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.2.4. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and

[jira] [Commented] (HTTPCLIENT-2303) a shaded version of apache http client

2023-10-12 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774637#comment-17774637 ] Ryan Schmitt commented on HTTPCLIENT-2303: -- It's a particularly

Re: [VOTE] Release HttpClient 5.3-alpha1 based on RC1

2023-08-16 Thread Ryan Schmitt
[x] +1 Release the packages as HttpClient 5.3-alpha1 On Tue, Aug 15, 2023 at 2:39 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.3-alpha1. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote p

org.brotli.dec 0.1.2 dependency in httpcomponents-client

2023-02-13 Thread Ryan Schmitt
I'm sending this along on behalf of a colleague who is having trouble getting through to the distribution list. Hi Apache client developers, It looks like the org.brotli.dec dependency was updated upstream for three years after the final version was published in Maven Central [1], including

Re: [VOTE] Release HttpClient 4.5.14 based on RC1

2022-12-01 Thread Ryan Schmitt
+1 On Wed, Nov 30, 2022 at 10:48 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 4.5.14. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast a

Re: [VOTE] Release HttpCore 4.4.16 based on RC1

2022-11-27 Thread Ryan Schmitt
+1 On Sat, Nov 26, 2022 at 1:51 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 4.4.16. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and

Re: [VOTE] Release HttpCore 5.1.5 based on RC1

2022-11-09 Thread Ryan Schmitt
+1 On Wed, Nov 9, 2022 at 10:23 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.1.5. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and t

Re: [VOTE] Release HttpClient 5.2 based on RC1

2022-11-08 Thread Ryan Schmitt
+1 On Sun, Nov 6, 2022 at 2:08 PM Oleg Kalnichevski wrote: > > Please vote on releasing these packages as HttpClient 5.2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and

Re: [VOTE] Release HttpClient 5.2 based on RC1

2022-11-06 Thread Ryan Schmitt
+1 On Sun, Nov 6, 2022 at 2:08 PM Oleg Kalnichevski wrote: > > Please vote on releasing these packages as HttpClient 5.2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Ryan Schmitt
If you'd like, I could run `git-bisect` to figure out where the tests broke; I'll just need to know which tests broke and how to run them. On Sat, Oct 22, 2022 at 8:14 AM Oleg Kalnichevski wrote: > The JUnit 5 upgrade was a cluster. > > The original contributor ported some of the easy test case

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Ryan Schmitt
assertThrows is available in JUnit 4.13. On Sun, Oct 23, 2022 at 4:11 AM Gary Gregory wrote: > Version 5 has some drawbacks but on the positive side, APIs like > assertThrows are very useful. > > Gary > > On Sun, Oct 23, 2022, 04:31 Michael Osipov wrote: > > > Am 2022-10-22 um 17:14 schrieb Ole

Re: HttpCore 5.1.4 release soon?

2022-06-30 Thread Ryan Schmitt
I'll be around. On Wed, Jun 29, 2022 at 6:10 AM Oleg Kalnichevski wrote: > Folks > > Will there be enough of us online to cut a new HttpCore 5.1 release > this week? > > Oleg > > - > To unsubscribe, e-mail: dev-unsubscr...@hc.ap

Re: [VOTE] Release HttpClient 5.2-beta1 based on RC1

2022-06-06 Thread Ryan Schmitt
+1 On Fri, Jun 3, 2022 at 3:18 PM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.2-beta1. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast

Re: [VOTE] Release HttpCore 5.2-beta2 based on RC1

2022-05-28 Thread Ryan Schmitt
+1 On Sat, May 28, 2022 at 7:27 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.2-beta2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast a

[jira] [Commented] (HTTPCORE-710) Async client hangs if remote peer closes connection during TLS handshake

2022-04-06 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518523#comment-17518523 ] Ryan Schmitt commented on HTTPCORE-710: --- [~olegk] The patch looks good on my

[jira] [Commented] (HTTPCORE-710) Async client hangs if remote peer closes connection during TLS handshake

2022-04-01 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516036#comment-17516036 ] Ryan Schmitt commented on HTTPCORE-710: --- [~olegk] I also thought the {{SSLEn

[jira] [Commented] (HTTPCORE-710) Async client hangs if remote peer closes connection during TLS handshake

2022-03-28 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513783#comment-17513783 ] Ryan Schmitt commented on HTTPCORE-710: --- [~olegk] Reproducer is here: h

Re: [jira] [Commented] (HTTPCLIENT-2210) HttpClient Log4j examples refer to non-existing `Console` appender

2022-03-27 Thread Ryan Schmitt
$ rg -l -e Console -e STDOUT httpclient5-cache/src/test/resources/log4j2.xml httpclient5-win/src/test/resources/log4j2.xml httpclient5-testing/src/test/resources/log4j2.xml httpclient5-testing/src/test/resources/log4j2-debug.xml.template httpclient5/src/test/resources/log4j2.xml httpclient5/src/tes

[jira] [Comment Edited] (HTTPCORE-710) Async client hangs if remote peer closes connection during TLS handshake

2022-03-24 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512101#comment-17512101 ] Ryan Schmitt edited comment on HTTPCORE-710 at 3/24/22, 9:5

[jira] [Commented] (HTTPCORE-710) Async client hangs if remote peer closes connection during TLS handshake

2022-03-24 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512101#comment-17512101 ] Ryan Schmitt commented on HTTPCORE-710: --- @olegk Not immediately. I'll n

[jira] [Created] (HTTPCORE-710) Async client hangs if remote peer closes connection during TLS handshake

2022-03-23 Thread Ryan Schmitt (Jira)
Ryan Schmitt created HTTPCORE-710: - Summary: Async client hangs if remote peer closes connection during TLS handshake Key: HTTPCORE-710 URL: https://issues.apache.org/jira/browse/HTTPCORE-710 Project

[jira] [Commented] (HTTPCORE-692) H2 should throw illegal header exception when use Host header as Connection header

2022-03-23 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511453#comment-17511453 ] Ryan Schmitt commented on HTTPCORE-692: --- [~olegk] I've decided to take

[jira] [Commented] (HTTPCORE-692) H2 should throw illegal header exception when use Host header as Connection header

2022-03-22 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510951#comment-17510951 ] Ryan Schmitt commented on HTTPCORE-692: --- Is this really the right behavior

[jira] [Commented] (HTTPCLIENT-2205) Ability to set SSL Context and hence Keystore for every request

2022-02-18 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494778#comment-17494778 ] Ryan Schmitt commented on HTTPCLIENT-2205: -- We also have a use case

Re: [VOTE] Release HttpClient 5.1.3 based on RC1

2022-01-30 Thread Ryan Schmitt
+1 On Thu, Jan 27, 2022 at 4:59 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.1.3. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and

Re: [VOTE] Release HttpCore 5.1.3 based on RC1

2021-12-19 Thread Ryan Schmitt
+1 On Sun, Dec 19, 2021 at 12:19 PM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.1.3. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and

Re: HttpCore 5.1.3 release over Christmas?

2021-12-17 Thread Ryan Schmitt
I am On Fri, Dec 17, 2021 at 8:34 AM Oleg Kalnichevski wrote: > Folks > > I would like to release HttpCore 5.1.3 soon as there has been a number > of bug fixes since the last release. > > Would there be at least 2 more PMCs online during this holiday period > to help me with the release? > > Ole

Re: Contribruting.

2021-12-03 Thread Ryan Schmitt
Oleg's not wrong about the value of tests, but here's a functional improvement I've proposed for dual-stack connections: https://issues.apache.org/jira/browse/HTTPCLIENT-2178 On Fri, Dec 3, 2021 at 1:33 PM Arturo Bernal wrote: > HI Oleg, > > > I haven't a specific area of interest, i find it fa

Re: [VOTE] Release HttpCore 4.4.15 based on RC1

2021-12-03 Thread Ryan Schmitt
+1 On Fri, Dec 3, 2021 at 12:44 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 4.4.15. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and

Re: [VOTE] Release HttpClient 5.1.2 based on RC1

2021-11-13 Thread Ryan Schmitt
+1 On Sat, Nov 13, 2021 at 10:34 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.1.2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast an

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-10-02 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423618#comment-17423618 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- {quote} Beside the hands

Re: [VOTE] Release HttpCore 5.1.2 based on RC1

2021-09-29 Thread Ryan Schmitt
[x] +1 Release the packages as HttpCore 5.1.2 On Sun, Sep 26, 2021 at 1:47 PM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.1.2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at le

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-20 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417741#comment-17417741 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- Looks great now, all tests

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-17 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416914#comment-17416914 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- Good point, I'm sti

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-17 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416869#comment-17416869 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- The connection retries

[jira] [Comment Edited] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-17 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416869#comment-17416869 ] Ryan Schmitt edited comment on HTTPCLIENT-2135 at 9/17/21, 6:5

[jira] [Created] (HTTPCLIENT-2178) Implement Happy Eyeballs V2 (RFC 8305)

2021-09-16 Thread Ryan Schmitt (Jira)
Ryan Schmitt created HTTPCLIENT-2178: Summary: Implement Happy Eyeballs V2 (RFC 8305) Key: HTTPCLIENT-2178 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2178 Project: HttpComponents

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-16 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416295#comment-17416295 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- The problem appears to be

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-16 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416291#comment-17416291 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- bq. The multi-home con

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-15 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415741#comment-17415741 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- {{ConnectionConfig}} l

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-15 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415653#comment-17415653 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- Makes sense, I'l

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-14 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415184#comment-17415184 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- I captured some log

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-14 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415170#comment-17415170 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- {quote} I do not see a re

[jira] [Comment Edited] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-13 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414602#comment-17414602 ] Ryan Schmitt edited comment on HTTPCLIENT-2135 at 9/13/21, 9:4

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-13 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414602#comment-17414602 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- [~olegk] The intention i

[jira] [Commented] (HTTPCLIENT-2135) TLS handshake timeouts cannot be controlled through RequestConfig

2021-09-13 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414481#comment-17414481 ] Ryan Schmitt commented on HTTPCLIENT-2135: -- [~olegk] I'll ta

Re: [VOTE] Release HttpCore 5.2-alpha1 based on RC1

2021-09-07 Thread Ryan Schmitt
+1 On Mon, Sep 6, 2021 at 2:00 AM Oleg Kalnichevski wrote: > > Please vote on releasing these packages as HttpCore 5.2-alpha1.The vote > is open for the at least 72 hours, and only votes fromHttpComponents > PMC members are binding. The vote passes if at leastthree binding +1 > votes are cast and

Re: New race condition confirmed

2021-06-19 Thread Ryan Schmitt
essions or changes in behavior. On Sat, Jun 19, 2021 at 4:46 AM Oleg Kalnichevski wrote: > > Hi Ryan > > Do you want to look into it or do you have a fix in mind? > > Olegg > > On 6/19/2021 12:49 AM, Ryan Schmitt wrote: > > I've finally found the race co

New race condition confirmed

2021-06-18 Thread Ryan Schmitt
I've finally found the race condition I've been looking for. Here's the reproducer: https://github.com/rschmitt/httpclient-benchmark/commit/master - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e

Re: Java 11 for HC 5.2?

2021-05-26 Thread Ryan Schmitt
I'm not sure there's any precedent for it. On Wed, May 26, 2021 at 11:24 AM Oleg Kalnichevski wrote: > On Wed, 2021-05-26 at 10:49 -0700, Ryan Schmitt wrote: > > -1. I think staying on JDK8 is for the best. Adoption of JDK11 has > > been > > quite poor, due to a

Re: Java 11 for HC 5.2?

2021-05-26 Thread Ryan Schmitt
-1. I think staying on JDK8 is for the best. Adoption of JDK11 has been quite poor, due to a lack of compelling new language features that would make upgrading worthwhile, and even ALPN and TLSv1.3 (the most relevant JDK11 features for our purposes) have now been backported to JDK8. I'd rather skip

Re: HTTP/2 question

2021-05-07 Thread Ryan Schmitt
ski wrote: > On Thu, 2021-05-06 at 16:18 -0700, Ryan Schmitt wrote: > > Is there a way to configure the client to _not_ include a Host header > > in > > HTTP/2 requests? Currently, my client is sending a Host header in > > addition > > to the relevant HTTP/2 pseudo-

Re: [VOTE] Release HttpClient 5.1 based on RC2

2021-05-07 Thread Ryan Schmitt
+1 On Fri, May 7, 2021 at 10:32 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.1. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and t

Re: [VOTE] Release HttpClient 5.0.4 based on RC1

2021-05-07 Thread Ryan Schmitt
+1 On Fri, May 7, 2021 at 10:12 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.0.4. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and

HTTP/2 question

2021-05-06 Thread Ryan Schmitt
Is there a way to configure the client to _not_ include a Host header in HTTP/2 requests? Currently, my client is sending a Host header in addition to the relevant HTTP/2 pseudo-headers (i.e. :scheme and :authority), and it seems to be screwing up AWS request signing.

Re: [VOTE] Release HttpCore 5.1.1 based on RC1

2021-05-03 Thread Ryan Schmitt
+1 On Sun, May 2, 2021 at 2:11 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.1.1. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and th

Re: [VOTE] Release HttpCore 5.0.4 based on RC1

2021-05-03 Thread Ryan Schmitt
+1 On Sun, May 2, 2021 at 1:44 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.0.4. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and th

Re: Another connection leak?

2021-04-30 Thread Ryan Schmitt
Early indications are that the proposed patch isn't helping. Either way, I don't think it should affect the proposed release schedule, since we have so many bugfixes queued up. On Wed, Apr 28, 2021 at 12:17 AM Ryan Schmitt wrote: > OK. I'll let you know what happens with the

  1   2   3   4   >