[ 
https://issues.apache.org/jira/browse/HTTPCORE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956674#comment-17956674
 ] 

Ryan Schmitt commented on HTTPCORE-783:
---------------------------------------

This doesn't seem like a good idea, given the ambiguities Oleg is pointing out. 
Even without considering parameters, we have cases like:
{code:java}
application/gzip
application/x-gzip{code}
Or this case you just ran into:
{code:java}
application/zip
application/x-zip-compressed
{code}
Our abstractions shouldn't write checks we can't cash.

> ContentType should implement equals() and hashCode()
> ----------------------------------------------------
>
>                 Key: HTTPCORE-783
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-783
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore
>            Reporter: Gary D. Gregory
>            Priority: Major
>
> I find it confusing that {{ContentType}} doesn't implement {{equals()}} and 
> {{hashCode()}}.
> Instead it implement a method called {{isSameMimeType(contentType))}} which 
> is documented to ... well, there's zero Javadoc.
> I think we should implement {{equals()}} and {{hashCode()}} to either:
> - Call {{super}} and Javadoc why
> - Provide a "proper" implementation which could (initially) ignore parameters 
> (or not).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to