Re: [PR] Replace the old InputStreamFactory registries with the new Decoder / Encoder pipeline [httpcomponents-client]

2025-07-03 Thread via GitHub
arturobernalg commented on code in PR #660: URL: https://github.com/apache/httpcomponents-client/pull/660#discussion_r2184536793 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/compress/Decoder.java: ## @@ -0,0 +1,60 @@ +/* + * ===

[PR] Fix `validateAfterActivity` on the async client [httpcomponents-client]

2025-07-03 Thread via GitHub
rschmitt opened a new pull request, #667: URL: https://github.com/apache/httpcomponents-client/pull/667 `validateAfterActivity` is primarily a synchronous client feature, since it is necessary to attempt to read from the underlying socket in order to discover that the connection has been cl

[jira] [Comment Edited] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17993400#comment-17993400 ] yhzdys edited comment on HTTPCLIENT-2379 at 7/4/25 3:38 AM: --

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17993400#comment-17993400 ] yhzdys commented on HTTPCLIENT-2379: if (perRoutePool != null && perRoutePool.ge

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17993128#comment-17993128 ] Arturo Bernal commented on HTTPCLIENT-2379: --- [~olegk]  The counter logic

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17993123#comment-17993123 ] yhzdys commented on HTTPCLIENT-2379: I believe this is a serious issue, because

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17993121#comment-17993121 ] yhzdys commented on HTTPCLIENT-2379: [~olegk] This is the scenario where I encou

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17993102#comment-17993102 ] Oleg Kalnichevski commented on HTTPCLIENT-2379: --- [~yhzdys] Many thanks

Re: [PR] HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool [httpcomponents-client]

2025-07-03 Thread via GitHub
arturobernalg commented on PR #663: URL: https://github.com/apache/httpcomponents-client/pull/663#issuecomment-3031760926 > I am afraid this change-set fixes a side-effect and simply hides the underlying problem. As far as I remember (i am still reviewing my code) there should be no un-tra

[jira] [Commented] (HTTPCLIENT-2380) DefaultAsyncClientConnectionOperator has a package-private constructor

2025-07-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17993038#comment-17993038 ] ASF subversion and git services commented on HTTPCLIENT-2380:

Re: [PR] HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool [httpcomponents-client]

2025-07-03 Thread via GitHub
ok2c commented on PR #663: URL: https://github.com/apache/httpcomponents-client/pull/663#issuecomment-3031695163 @arturobernalg I am afraid this change-set fixes a side-effect and simply hides the underlying problem. As far as I remember (i am still reviewing my code) there should be no un

Re: setValidateAfterInactivity and PoolingAsyncClientConnectionManager

2025-07-03 Thread Oleg Kalnichevski
On 2025-07-02 20:55, Ryan Schmitt wrote: "Stale" means that the remote peer closed the connection but we don't know it until we try to reuse the connection, right? Correct. However, this can happen to blocking connections only because due to the classic i/o inherent design limitations they ca

[jira] [Reopened] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal reopened HTTPCLIENT-2379: --- > Multiple removal of same PoolEntry causes IllegalStateException in > H2SharingCon

Re: [PR] HTTPCLIENT-2380 – make DefaultAsyncClientConnectionOperator extensible [httpcomponents-client]

2025-07-03 Thread via GitHub
ok2c commented on PR #666: URL: https://github.com/apache/httpcomponents-client/pull/666#issuecomment-3031662483 @arturobernalg The commit message is bad. The issue is wrong and there is version 5.6 in the message. Please correct the message and force-push the commit. -- This is an auto

[jira] [Closed] (HTTPCLIENT-2380) DefaultAsyncClientConnectionOperator has a package-private constructor

2025-07-03 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed HTTPCLIENT-2380. - > DefaultAsyncClientConnectionOperator has a package-private constructor > -

[jira] [Resolved] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved HTTPCLIENT-2379. --- Resolution: Fixed > Multiple removal of same PoolEntry causes IllegalStateExcept

[jira] [Closed] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed HTTPCLIENT-2379. - > Multiple removal of same PoolEntry causes IllegalStateException in > H2SharingConnPoo

[jira] [Resolved] (HTTPCLIENT-2380) DefaultAsyncClientConnectionOperator has a package-private constructor

2025-07-03 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved HTTPCLIENT-2380. --- Resolution: Fixed > DefaultAsyncClientConnectionOperator has a package-private c

Re: [PR] HTTPCLIENT-2380 – make DefaultAsyncClientConnectionOperator extensible [httpcomponents-client]

2025-07-03 Thread via GitHub
arturobernalg commented on PR #666: URL: https://github.com/apache/httpcomponents-client/pull/666#issuecomment-3031646754 @ok2c cherry picket to `5.5.x` [7d87256](https://github.com/apache/httpcomponents-client/commit/7d872566c892a66234861748c89d424a0c0e43a0) -- This is an automated me

Re: [PR] HTTPCLIENT-2380 – make DefaultAsyncClientConnectionOperator extensible [httpcomponents-client]

2025-07-03 Thread via GitHub
arturobernalg merged PR #666: URL: https://github.com/apache/httpcomponents-client/pull/666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [PR] HTTPCLIENT-2380 – make DefaultAsyncClientConnectionOperator extensible [httpcomponents-client]

2025-07-03 Thread via GitHub
ok2c commented on code in PR #666: URL: https://github.com/apache/httpcomponents-client/pull/666#discussion_r2182307885 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java: ## @@ -71,7 +71,17 @@ public class DefaultAsyncCli

[PR] HTTPCLIENT-2380 – make DefaultAsyncClientConnectionOperator extensible [httpcomponents-client]

2025-07-03 Thread via GitHub
arturobernalg opened a new pull request, #666: URL: https://github.com/apache/httpcomponents-client/pull/666 This PR fixes [HTTPCLIENT-2380](https://issues.apache.org/jira/browse/HTTPASYNC-173) by changing the constructor of `DefaultAsyncClientConnectionOperator` to protected, allowing ext

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17992856#comment-17992856 ] ASF subversion and git services commented on HTTPCLIENT-2379:

Re: [PR] HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of same PoolEntry [httpcomponents-client]

2025-07-03 Thread via GitHub
arturobernalg commented on PR #665: URL: https://github.com/apache/httpcomponents-client/pull/665#issuecomment-3031510080 > @arturobernalg Could you please cherry-pick this change-set to `5.5.x` as well? @ok2c done -- This is an automated message from the Apache Git Service. To r

[jira] [Updated] (HTTPCLIENT-2380) DefaultAsyncClientConnectionOperator has a package-private constructor

2025-07-03 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCLIENT-2380: -- Component/s: HttpClient (async) Fix Version/s: 5.5.1

[jira] [Moved] (HTTPCLIENT-2380) DefaultAsyncClientConnectionOperator has a package-private constructor

2025-07-03 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski moved HTTPASYNC-173 to HTTPCLIENT-2380: - Key: HTTPCLIENT-2380 (was: HTTPASYNC-1

Re: [PR] HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of same PoolEntry [httpcomponents-client]

2025-07-03 Thread via GitHub
ok2c commented on PR #665: URL: https://github.com/apache/httpcomponents-client/pull/665#issuecomment-3031301343 @arturobernalg Could you please cherry-pick this change-set to `5.5.x` as well? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (HTTPASYNC-173) DefaultAsyncClientConnectionOperator has a package-private constructor

2025-07-03 Thread James Bradlee (Jira)
James Bradlee created HTTPASYNC-173: --- Summary: DefaultAsyncClientConnectionOperator has a package-private constructor Key: HTTPASYNC-173 URL: https://issues.apache.org/jira/browse/HTTPASYNC-173 Proj