ok2c commented on code in PR #666:
URL:
https://github.com/apache/httpcomponents-client/pull/666#discussion_r2182307885
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java:
##########
@@ -71,7 +71,17 @@ public class DefaultAsyncClientConnectionOperator implements
AsyncClientConnecti
private final MultihomeIOSessionRequester sessionRequester;
private final Lookup<TlsStrategy> tlsStrategyLookup;
- DefaultAsyncClientConnectionOperator(
+ /**
+ * Constructs a new {@code DefaultAsyncClientConnectionOperator}.
+ *
+ * <p><strong>Note:</strong> this class is marked {@code @Internal}; rely
on it
+ * only if you are prepared for incompatible changes in a future major
+ * release. Typical client code should use the high-level builders in
+ * {@code HttpAsyncClients} instead.</p>
+ *
+ * @since 5.6
Review Comment:
@arturobernalg This change should also be cherry-picked to `5.5.x` so I
would just omit the version here or change it to `@since 5.5`. It is non-public
class. We can change it in the stable branch as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
