arturobernalg opened a new pull request, #609:
URL: https://github.com/apache/httpcomponents-client/pull/609
Fix HTTPCLIENT-2354 by updating `ResponseCachingPolicy` to handle caching of
responses with `must-revalidate, max-age=0` in shared caches. Updated
`isExplicitlyCacheable` to account
+1 Release the packages as HttpCore 5.3.2.
Thank you
Arturo
On Mon, Jan 6, 2025 at 6:55 PM Oleg Kalnichevski wrote:
> Please vote on releasing these packages as HttpCore 5.3.2.
> The vote is open for the at least 72 hours, and only votes from
> HttpComponents PMC members are binding. The v
Please vote on releasing these packages as HttpCore 5.3.2.
The vote is open for the at least 72 hours, and only votes from
HttpComponents PMC members are binding. The vote passes if at least
three binding +1 votes are cast and there are more +1 than -1 votes.
Release notes:
https://dist.apache.o
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skylar Sutton updated HTTPCLIENT-2354:
--
Description:
Using httpclient5-cache:5.4.1, backed by an EH Cache with the followi
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skylar Sutton updated HTTPCLIENT-2354:
--
Description:
Using httpclient5-cache:5.4.1, backed by an EH Cache with the followi
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skylar Sutton updated HTTPCLIENT-2354:
--
Description:
Using httpclient5-cache:5.4.1, backed by an EH Cache with the followi
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skylar Sutton updated HTTPCLIENT-2354:
--
Description:
Using httpclient5-cache:5.4.1, backed by an EH Cache with the followi
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910325#comment-17910325
]
Skylar Sutton commented on HTTPCLIENT-2354:
---
RFC 9111 does state exactly t
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910314#comment-17910314
]
Oleg Kalnichevski commented on HTTPCLIENT-2354:
---
> Per this documentat
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skylar Sutton updated HTTPCLIENT-2354:
--
Description:
Using httpclient5-cache:5.4.1, backed by an EH Cache with the followi
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skylar Sutton updated HTTPCLIENT-2354:
--
Description:
Using httpclient5-cache:5.4.1, backed by an EH Cache with the followi
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skylar Sutton updated HTTPCLIENT-2354:
--
Description:
Using httpclient5-cache:5.4.1, backed by an EH Cache with the followi
Skylar Sutton created HTTPCLIENT-2354:
-
Summary: ResponseCachingPolicy::isExplicitlyCacheable does not
account for "must-revalidate"
Key: HTTPCLIENT-2354
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2
arturobernalg commented on PR #608:
URL:
https://github.com/apache/httpcomponents-client/pull/608#issuecomment-2573193117
> @arturobernalg Please cherry-pick to `5.4.x`
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ok2c commented on PR #608:
URL:
https://github.com/apache/httpcomponents-client/pull/608#issuecomment-2573139724
@arturobernalg Please cherry-pick to `5.4.x`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
arturobernalg merged PR #608:
URL: https://github.com/apache/httpcomponents-client/pull/608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
arturobernalg commented on code in PR #608:
URL:
https://github.com/apache/httpcomponents-client/pull/608#discussion_r1904161891
##
httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java:
##
@@ -44,8 +45,9 @@ public class SystemDefaultDnsResolver imp
ok2c commented on code in PR #608:
URL:
https://github.com/apache/httpcomponents-client/pull/608#discussion_r1904123873
##
httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java:
##
@@ -44,8 +45,9 @@ public class SystemDefaultDnsResolver implements D
arturobernalg commented on code in PR #608:
URL:
https://github.com/apache/httpcomponents-client/pull/608#discussion_r1904121648
##
httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java:
##
@@ -44,8 +45,9 @@ public class SystemDefaultDnsResolver imp
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Kalnichevski updated HTTPCLIENT-2353:
--
Fix Version/s: 5.4.2
> Incorrect IDN-hostname validation from TLS-certific
arturobernalg commented on PR #608:
URL:
https://github.com/apache/httpcomponents-client/pull/608#issuecomment-2572737248
> @arturobernalg Just a question. Why not having this normalization logic in
`SystemDefaultDnsResolver`? It already has some extra logic for resolution of
IPv6 names in
arturobernalg commented on PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#issuecomment-2572729570
> > @arturobernalg Looks good to me
>
> @ok2c on it
Cherry-picked to `5.4.x`
--
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910072#comment-17910072
]
ASF subversion and git services commented on HTTPCLIENT-2353:
arturobernalg commented on PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#issuecomment-2572653836
> @arturobernalg Looks good to me
@ok2c on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
ok2c commented on PR #608:
URL:
https://github.com/apache/httpcomponents-client/pull/608#issuecomment-2572653161
@arturobernalg Just a question. Why not having this normalization logic in
`SystemDefaultDnsResolver`? It already has some extra logic for resolution of
IPv6 names in it.
--
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated HTTPCLIENT-2353:
--
Fix Version/s: 5.5-alpha1
> Incorrect IDN-hostname validation from TLS-certificate
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal resolved HTTPCLIENT-2353.
---
Resolution: Fixed
> Incorrect IDN-hostname validation from TLS-certificates
> --
ok2c commented on PR #607:
URL:
https://github.com/apache/httpcomponents-client/pull/607#issuecomment-2572647287
@arturobernalg Please also cherry-pick this commit to `5.4.x`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910065#comment-17910065
]
ASF subversion and git services commented on HTTPCLIENT-2353:
arturobernalg merged PR #607:
URL: https://github.com/apache/httpcomponents-client/pull/607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
30 matches
Mail list logo