ok2c commented on code in PR #608:
URL:
https://github.com/apache/httpcomponents-client/pull/608#discussion_r1904123873
##########
httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java:
##########
@@ -44,8 +45,9 @@ public class SystemDefaultDnsResolver implements DnsResolver {
@Override
public InetAddress[] resolve(final String host) throws
UnknownHostException {
try {
+ final String normalizedHost = IDN.toASCII(host);
Review Comment:
@arturobernalg Do you have any objections to doing the test
`TextUtils#isAllASCII` prior to doing `IDN.toASCII`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
