Re: Antlr4-based Groovy parser status update

vance Daniel.Sun -- View this message in context: http://groovy.329449.n5.nabble.com/Antlr4-based-Groovy-parser-status-update-tp5731370p5731890.html Sent from the Groovy Dev mailing list archive at Nabble.com.

Re: More Antlr4-based Groovy parser status update

+1 👏 Sent from my iPad > On 11 Mar 2016, at 11:11, Guillaume Laforge wrote: > > By the way, I had a question (unrelated to the below thread, but related to > the grammar) :-) > > Do you keep the comment information? > It's something we've always said we should support, and it would tremendous

Re: More Antlr4-based Groovy parser status update

Yup, that would be great as metadata! On Fri, Mar 11, 2016 at 11:26 AM, Jesper Steen Møller wrote: > Hi Guillaume > > This is not covered by the current code, but it can be added. I guess this > could be set as “metadata” on types, package, properties, methods, and > fields? > > -Jesper > > On 1

Re: More Antlr4-based Groovy parser status update

Hi Guillaume This is not covered by the current code, but it can be added. I guess this could be set as “metadata” on types, package, properties, methods, and fields? -Jesper > On 11. mar. 2016, at 11.11, Guillaume Laforge wrote: > > By the way, I had a question (unrelated to the below thread

Re: More Antlr4-based Groovy parser status update

By the way, I had a question (unrelated to the below thread, but related to the grammar) :-) Do you keep the comment information? It's something we've always said we should support, and it would tremendously help making a less hackish groovydoc tool. Having AST nodes for JavaDoc comments would rea

Re: More Antlr4-based Groovy parser status update

Hi Jochen > On 29. feb. 2016, at 11.39, Jochen Theodorou wrote: > > On 28.02.2016 12:55, Jesper Steen Møller wrote: > [...] >> * Memory: Is this an issue I should be focusing on — and is there a >>test to baseline against? > > no test you can baseline against imho. The current approach is k

Re: More Antlr4-based Groovy parser status update

On 28.02.2016 12:55, Jesper Steen Møller wrote: [...] * Memory: Is this an issue I should be focusing on — and is there a test to baseline against? no test you can baseline against imho. The current approach is keeping everything in memory and uses that for the cst part, which is build

Aw: Re: More Antlr4-based Groovy parser status update

y.apache.org Betreff: Re: More Antlr4-based Groovy parser status update Hi Pascal,   Thank you, I’d missed that one.   Any thought on the validity of “- -1”?   -Jesper   On 28. feb. 2016, at 18.23, Pascal Schumacher <pascalschumac...@gmx.net> wrote:   Hi Jesper, thanks for the u

Re: More Antlr4-based Groovy parser status update

Hi Pascal, Thank you, I’d missed that one. Any thought on the validity of “- -1”? -Jesper > On 28. feb. 2016, at 18.23, Pascal Schumacher > wrote: > > Hi Jesper, > > thanks for the update. :) Nice to hear you are progressing. > > Concerning the ASTBuilder to

Re: More Antlr4-based Groovy parser status update

Hi Jesper, thanks for the update. :) Nice to hear you are progressing. Concerning the ASTBuilder to Java conversion, there is a pull request with this at the old repo https://github.com/groovy/groovy-core/pull/513 Cheers, Pascal Am 28.02.2016 um 12:55 schrieb Jesper Steen Møller: Hi Groovy-

Re: More Antlr4-based Groovy parser status update

Just a clarification: I wrote: > I’ve discovered a small issue with unary syntax. Currently, nested unary > expressions are not supported without parenthesis: Try e.g. - -1 or + -1. Is > this intentional, or just an artifact of the precedence-refactored Java > grammar? > By “currently”, I mea

More Antlr4-based Groovy parser status update

Hi Groovy-Dev Here’s another update on the progress on the Antlr4 parser, as maintained on https://github.com/jespersm/groovy.git (in the antlr4 branch). To play with it, try: $ git clone -b antlr4 https://jespe...@github.com/jespersm/groovy.git $ cd groovy $ gradle -PuseAntlr4=true console I’v

Re: Antlr4-based Groovy parser status update

Ah yes, I'd forgotten about that line of thinking. I still believe we should be able to set things up so that prod code isn't affected by Spock but I don't have time to investigate further right now so being extra cautious as per Cédric's comment is the way to go. Cheers, Paul. On Wed, Feb 24, 20

Re: Antlr4-based Groovy parser status update

Ah, good to know. While merging in the master changes since the antlr4 fork, I noticed that Spock was indeed in use already, so I haven’t ditched it — yet. For now, it’s only used for simple things like where-blocks, which can be done only slightly more clumsily with JUnit. -Jesper > On 24. f

Re: Antlr4-based Groovy parser status update

It is a show stopper for groovy-core. We must *not* introduce a dependency on Spock, because it would conflict with the version of Groovy that we are using, and apply global xforms on Groovy core. While it might be ok, we want to minimize the risks. 2016-02-24 12:35 GMT+01:00 Paul King : > Spock

Re: Antlr4-based Groovy parser status update

Spock for testing is by no means a show stopper! On Wed, Feb 24, 2016 at 6:46 PM, Jesper Steen Møller wrote: > > On 24. feb. 2016, at 01.21, Guillaume Laforge wrote: > > Sounds cool, Jesper, great to hear about your progress on the Antlr4 > grammar! > Is there a way we can help you? How can we t

Re: Antlr4-based Groovy parser status update

> On 24. feb. 2016, at 01.21, Guillaume Laforge wrote: > > Sounds cool, Jesper, great to hear about your progress on the Antlr4 grammar! > Is there a way we can help you? How can we test drive this? Is the build > working? The build works in that the antlr4 branch can be build and tested with

Re: Antlr4-based Groovy parser status update

Sounds cool, Jesper, great to hear about your progress on the Antlr4 grammar! Is there a way we can help you? How can we test drive this? Is the build working? Guillaume On Wed, Feb 24, 2016 at 1:14 AM, Jesper Steen Møller wrote: > Hi Groovy-dev > > I’ve found some time to work on the Antlr4 pa

Antlr4-based Groovy parser status update

Hi Groovy-dev I’ve found some time to work on the Antlr4 parser and fixed some minor tasks there: * Fix grammar for several statement sequences, where NL or semicolon was not required (added negative test cases) * Remove non-reentrant static state in ASTBuilder * Added syntax error handling to