Ah yes, I'd forgotten about that line of thinking. I still believe we should be able to set things up so that prod code isn't affected by Spock but I don't have time to investigate further right now so being extra cautious as per Cédric's comment is the way to go.
Cheers, Paul. On Wed, Feb 24, 2016 at 10:24 PM, Jesper Steen Møller <jes...@selskabet.org> wrote: > Ah, good to know. > > While merging in the master changes since the antlr4 fork, I noticed that > Spock was indeed in use already, so I haven’t ditched it — yet. For now, > it’s only used for simple things like where-blocks, which can be done only > slightly more clumsily with JUnit. > > -Jesper > > On 24. feb. 2016, at 12.41, Cédric Champeau <cedric.champ...@gmail.com> > wrote: > > It is a show stopper for groovy-core. We must *not* introduce a dependency > on Spock, because it would conflict with the version of Groovy that we are > using, and apply global xforms on Groovy core. While it might be ok, we want > to minimize the risks. > > 2016-02-24 12:35 GMT+01:00 Paul King <pa...@asert.com.au>: >> >> Spock for testing is by no means a show stopper! >> >> On Wed, Feb 24, 2016 at 6:46 PM, Jesper Steen Møller >> <jes...@selskabet.org> wrote: >> > >> > On 24. feb. 2016, at 01.21, Guillaume Laforge <glafo...@gmail.com> >> > wrote: >> > >> > Sounds cool, Jesper, great to hear about your progress on the Antlr4 >> > grammar! >> > Is there a way we can help you? How can we test drive this? Is the build >> > working? >> > >> > >> > The build works in that the antlr4 branch can be build and tested with >> > e.g. >> > “gradle -PuseAntlr4=true test”. >> > >> > However, I can’t seem to actually build a real distribution and use the >> > new >> > parser in that (there’s a dynamic switch), without getting some very >> > strange >> > errors. >> > I’ve put off chasing that problem until I know I have the missing pieces >> > of >> > the grammar and the AST building done right. >> > >> > The current tests use Spock. Is that out of the question for the main >> > Groovy >> > build? I loooove Spock, but I realise we have to keep the number of >> > dependencies down. >> > >> > -Jesper >> > >> > >> > On Wed, Feb 24, 2016 at 1:14 AM, Jesper Steen Møller >> > <jes...@selskabet.org> >> > wrote: >> >> >> >> Hi Groovy-dev >> >> >> >> I’ve found some time to work on the Antlr4 parser and fixed some minor >> >> tasks there: >> >> >> >> * Fix grammar for several statement sequences, where NL or semicolon >> >> was >> >> not required (added negative test cases) >> >> * Remove non-reentrant static state in ASTBuilder >> >> * Added syntax error handling to Antlr 4 parser >> >> * Make sure GrammarPredicates work with arbitrarily nested package >> >> hierarchies >> >> >> >> I’m pushing my changes here: >> >> https://github.com/jespersm/groovy/commits/antlr4 >> >> >> >> Next up is support for non-ID method invocation and command >> >> expressions, >> >> and then unary expressions. >> >> Also, since the GSoC is a bit dated, traits are also missing. >> >> >> >> -Jesper >> > >> > >> > >> > >> > -- >> > Guillaume Laforge >> > Apache Groovy committer & PMC Vice-President >> > Product Ninja & Advocate at Restlet >> > >> > Blog: http://glaforge.appspot.com/ >> > Social: @glaforge / Google+ >> > >> > > > >
