The vote has passed with 3 binding votes:
Paul King
Guillaume Laforge
John Wagenleitner
There was also 3 non-binding votes and additional votes cast during
earlier candidates.
I'll proceed with deploying the release.
Cheers, Paul.
On Thu, Mar 30, 2017 at 3:49 PM, Paul King wrote:
> Dear commun
+1
Cheers,
Daniel.Sun
--
View this message in context:
http://groovy.329449.n5.nabble.com/VOTE-Release-Apache-Groovy-2-5-0-alpha-1-take-3-tp5739524p5739563.html
Sent from the Groovy Dev mailing list archive at Nabble.com.
+1
Was using it during my macro methods workshop (thanks to https://jitpack.io/ ),
all went well :)
On Sat, Apr 1, 2017 at 12:37 AM John Wagenleitner <
john.wagenleit...@gmail.com> wrote:
> +1
>
> On Wed, Mar 29, 2017 at 10:49 PM, Paul King wrote:
>
> Dear community,
>
> I am happy to start the
+1
On Wed, Mar 29, 2017 at 10:49 PM, Paul King wrote:
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release!
>
> This release includes 165 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> pro
+1 !
On Thu, Mar 30, 2017 at 9:10 AM, Russel Winder wrote:
>
> > [ ] +1 Release Apache Groovy 2.5.0-alpha-1
> > [ ] 0 I don't have a strong opinion about this, but I assume it's ok
> > [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because...
>
> Vote early, vote often:
>
> +1
>
> --
> Russe
> [ ] +1 Release Apache Groovy 2.5.0-alpha-1
> [ ] 0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because...
Vote early, vote often:
+1
--
Russel.
One failed test is something we could potentially release note but it
seems just as easy to re-cut. I'll try one more time.
Paul.
On Thu, Mar 30, 2017 at 1:06 AM, Sergei Egorov wrote:
> -1
> We have 1 failing test ( "MacroTest > testNotAMacroCall" )
>
> Was caused by my recent change when I rena
Dear community,
I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release!
This release includes 165 bug fixes/improvements as outlined in the changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12338913
Tag:
https://git1-us-west.apache.org/
I said +1 before, so
+1
from me this time.
--
Russel.
=
Dr Russel Winder t: +44 20 7585 2200 voip: sip:russel.win...@ekiga.net
41 Buckmaster Roadm: +44 7770 465 077 xmpp: rus...@winder.org.uk
London SW11 1
True. But it's about "macro" method, aka "MacroGroovy". Its API also wasn't
affected, basically, I just reimplemented it as a macro method :)
FYI build is green now:
http://ci.groovy-lang.org/viewLog.html?buildId=38463&tab=buildResultsDiv&buildTypeId=Groovy_Jdk8Build_2
On Wed, Mar 29, 2017 at 5:2
We have some documentation from Mario :
https://github.com/apache/groovy/blob/master/src/spec/doc/core-metaprogramming.adoc#macros
On Wed, Mar 29, 2017 at 5:22 PM, Sergei Egorov wrote:
> Jochen,
>
> This is a good question :)
>
> I'm going to present them tomorrow on my workshop at Greach, will
Guillaume,
Yes, I fixed this test already, builds are running, locally is green as
well.
I had two long flights from 6am, please excuse me for today :)
On Wed, Mar 29, 2017 at 5:22 PM Sergei Egorov wrote:
> Jochen,
>
> This is a good question :)
>
> I'm going to present them tomorrow on my wor
Jochen,
This is a good question :)
I'm going to present them tomorrow on my workshop at Greach, will collect
some feedback and then will start writing the docs.
The only explanation you can find now is here
https://github.com/bsideup/groovy-macro-methods-proposal
There are open questions tho. W
I thought I had run the tests, but I had actually run installGroovy the
second time instead of running the tests too.
I also get the failing test:
:groovy-macro:test
org.codehaus.groovy.macro.MacroTest > testNotAMacroCall FAILED
java.lang.AssertionError: Closure
org.codehaus.groovy.macro.Ma
Indeed we need documentation.
There's some, but that's not covering the current refactored version.
Sergei, will you update it?
On Wed, Mar 29, 2017 at 5:16 PM, Jochen Theodorou wrote:
>
>
> On 29.03.2017 17:06, Sergei Egorov wrote:
>
>> -1
>> We have 1 failing test ( "MacroTest > testNotAMacroC
On 29.03.2017 17:06, Sergei Egorov wrote:
-1
We have 1 failing test ( "MacroTest > testNotAMacroCall" )
Was caused by my recent change when I renamed extension module, sorry.
I pushed a test fix. Assumption was incorrect, see the commit for an
explanation.
on a side note... where can I find
-1
We have 1 failing test ( "MacroTest > testNotAMacroCall" )
Was caused by my recent change when I renamed extension module, sorry.
I pushed a test fix. Assumption was incorrect, see the commit for an
explanation.
On Wed, Mar 29, 2017 at 4:18 PM Paul King wrote:
> Dear community,
>
> I am hap
+1 (binding)
Still builds / tests successfully, and now I don't see the error message
anymore when launching groovy or groovyConsole.
Guillaume
On Wed, Mar 29, 2017 at 4:17 PM, Paul King wrote:
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release!
>
> T
Dear community,
I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release!
This release includes 165 bug fixes/improvements as outlined in the changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12338913
Tag:
https://git1-us-west.apache.org/
The shadow gradle plugin can take care of merging resource files.
Sent from my primitive Tricorder
> On 29 Mar 2017, at 12:17, Sergei Egorov wrote:
>
> Okay, it's a leftover in build.gradle of groovy-macro.
>
> "org.codehaus.groovy.macro.runtime.MacroGroovyMethods" but should be
> "org.code
Okay, it's a leftover in build.gradle of groovy-macro.
"org.codehaus.groovy.macro.*runtime*.MacroGroovyMethods" but should be
"org.codehaus.groovy.macro.*methods*.MacroGroovyMethods"
Also, we don't merge "org.codehaus.groovy.transform.ASTTransformation"
files when doing a jarjar-ing of groovy-all
Okie dokie.
I haven't tried running a @Macro example though, so I can't confirm it
impacts the new macro stuff from within a groovy console session or not.
But that is worth a try to further debug / track this.
On Wed, Mar 29, 2017 at 10:49 AM, Paul King wrote:
> Yes, Sergei just spotted somethi
Yes, Sergei just spotted something similar. We're still tracking it
down. It may be that groovy-macro functionality might not work (fully)
in some scenarios. If we can confirm what's wrong I can cancel the
VOTE and re-start the release process, otherwise we can just release
note the limitation(s).
+1 (binding)
I built it fine, all tests passing.
I ran it as well, and things seem to work fine.
There's just one thing that I noticed, which is that when I run $ groovy or
$ groovyConsole, for example, I get those warnings:
$ groovyconsole
Mar 29, 2017 10:02:09 AM
org.codehaus.groovy.runtime.
+1
Would be nice to test macro stuff :)
On Wed, 29 Mar 2017 at 07:18, Russel Winder wrote:
>
> > [ ] +1 Release Apache Groovy 2.5.0-alpha-1
> > [ ] 0 I don't have a strong opinion about this, but I assume it's ok
> > [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because...
>
> Now that Git
> [ ] +1 Release Apache Groovy 2.5.0-alpha-1
> [ ] 0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because...
Now that Git master/HEAD is 3.0.0, I think there must be a 2.5.0
release. Given this is marked alpha, I see no reason
Dear community,
I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release!
This release includes 165 bug fixes/improvements as outlined in the changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12338913
Tag:
https://git1-us-west.apache.org/
27 matches
Mail list logo
