Okay, it's a leftover in build.gradle of groovy-macro. "org.codehaus.groovy.macro.*runtime*.MacroGroovyMethods" but should be "org.codehaus.groovy.macro.*methods*.MacroGroovyMethods"
Also, we don't merge "org.codehaus.groovy.transform.ASTTransformation" files when doing a jarjar-ing of groovy-all. It wasn't an issue before because there were no global xforms in subprojects before. In this state, it's pointless to release an alpha, so I change my vote to "-1". I'll fix a package in build.gradle of groovy-macro now. Regarding jarjar-ing: I guess we have to introduce a task to merge global xforms, the same way we do right now for extension modules. On Wed, Mar 29, 2017 at 11:08 AM Guillaume Laforge <glafo...@gmail.com> wrote: > Okie dokie. > I haven't tried running a @Macro example though, so I can't confirm it > impacts the new macro stuff from within a groovy console session or not. > But that is worth a try to further debug / track this. > > On Wed, Mar 29, 2017 at 10:49 AM, Paul King <pa...@asert.com.au> wrote: > > Yes, Sergei just spotted something similar. We're still tracking it > down. It may be that groovy-macro functionality might not work (fully) > in some scenarios. If we can confirm what's wrong I can cancel the > VOTE and re-start the release process, otherwise we can just release > note the limitation(s). > > Paul. > > On Wed, Mar 29, 2017 at 6:13 PM, Guillaume Laforge <glafo...@gmail.com> > wrote: > > +1 (binding) > > > > I built it fine, all tests passing. > > > > I ran it as well, and things seem to work fine. > > > > There's just one thing that I noticed, which is that when I run $ groovy > or > > $ groovyConsole, for example, I get those warnings: > > > > $ groovyconsole > > > > Mar 29, 2017 10:02:09 AM > > org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule newModule > > > > WARNING: Module [groovy-macro] - Unable to load extension class > > [org.codehaus.groovy.macro.runtime.MacroGroovyMethods] > > > > > > Is the groovy module missing its manifest or something? > > > > Guillaume > > > > > > On Wed, Mar 29, 2017 at 6:06 AM, Paul King <pa...@apache.org> wrote: > >> > >> Dear community, > >> > >> I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release! > >> > >> This release includes 165 bug fixes/improvements as outlined in the > >> changelog: > >> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12338913 > >> > >> Tag: > >> > https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_5_0_ALPHA_1 > >> Tag commit id: d56fc79bd942a79e51f22f03c986ac0e7f3a9c70 > >> > >> The artifacts to be voted on are located as follows (r18945). > >> Source release: > >> https://dist.apache.org/repos/dist/dev/groovy/2.5.0-alpha-1/sources > >> Convenience binaries: > >> > https://dist.apache.org/repos/dist/dev/groovy/2.5.0-alpha-1/distribution > >> > >> Release artifacts are signed with a key from the following file: > >> https://dist.apache.org/repos/dist/dev/groovy/KEYS > >> > >> Please vote on releasing this package as Apache Groovy 2.5.0-alpha-1. > >> > >> The vote is open for the next 72 hours and passes if a majority of at > >> least three +1 PMC votes are cast. > >> > >> [ ] +1 Release Apache Groovy 2.5.0-alpha-1 > >> [ ] 0 I don't have a strong opinion about this, but I assume it's ok > >> [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because... > >> > >> Here is my vote: > >> > >> +1 (binding) > > > > > > > > > > -- > > Guillaume Laforge > > Apache Groovy committer & PMC Vice-President > > Developer Advocate @ Google Cloud Platform > > > > Blog: http://glaforge.appspot.com/ > > Social: @glaforge / Google+ > > > > > -- > Guillaume Laforge > Apache Groovy committer & PMC Vice-President > Developer Advocate @ Google Cloud Platform > > Blog: http://glaforge.appspot.com/ > Social: @glaforge <http://twitter.com/glaforge> / Google+ > <https://plus.google.com/u/0/114130972232398734985/posts> >
