Re: flink-python failed on Travis

2019-07-17 Thread Zili Chen
Hi Dian Nice fix! Best, tison. Dian Fu 于2019年7月18日周四 上午9:27写道: > Hi all, > > This issue has been fixed in > https://github.com/apache/flink/commit/200a5bf9dca9d398cf07879d4d1e407a2f41d839 > < > https://github.com/apache/flink/commit/200a5bf9dca9d398cf07879d4d1e407a2f41d839>. > Thanks for @Wei

Re: [ANNOUNCE] Jiangjie (Becket) Qin has been added as a committer to the Flink project

2019-07-18 Thread Zili Chen
Congratulations Becket! Best, tison. Yun Tang 于2019年7月18日周四 下午3:53写道: > Congratulations Becket! Well deserved. > > Best > Yun Tang > > From: Robert Metzger > Sent: Thursday, July 18, 2019 15:41 > To: dev > Subject: [ANNOUNCE] Jiangjie (Becket) Qin has been ad

Re: [DISCUSS] A more restrictive JIRA workflow

2019-07-18 Thread Zili Chen
ail.com> > >>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>> Hello there, > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>

Re: [DISCUSS] A more restrictive JIRA workflow

2019-07-18 Thread Zili Chen
hepler 于2019年7月18日周四 下午6:40写道: > We haven't wiped the set of contributors yet. Not sure if there's an > easy way to remove the permissions for all of them; someone from the PMC > may have to bite the bullet and click 600 times in a row :) > > On 18/07/2019 12:32, Zili Chen

Re: 请问这些名词,在翻译 Glossary 时,有必要翻译成中文吗?

2019-07-18 Thread Zili Chen
Hi, 欢迎有 PR 后同步到这个 thread 上 :-) Best, tison. highfei2011 于2019年7月19日周五 上午8:34写道: > Hi,Zili Chen: > 早上好,你讲的没错,谢谢。另外我发现,Glossary 英文文档中没有 Slot 和 Parallelism > 的说明,建议添加。这样可以方便初学者和用户的学习和使用! > > 祝好 > > > > Original Message > Subject: Re: 请

Re: [DISCUSS] A more restrictive JIRA workflow

2019-07-18 Thread Zili Chen
n Thu, 18 Jul 2019 at 18:50, Zili Chen wrote: > > > Checking the result, as a discovery, I found that one can > > still file a JIRA with "blocker" priority. > > > > IIRC someone in this thread once mentioned that > > "Don't allow contributors t

Re: [DISCUSS] A more restrictive JIRA workflow

2019-07-18 Thread Zili Chen
before we implement automatic reply/reaction. Best, tison. Zili Chen 于2019年7月19日周五 上午11:44写道: > @Jack > > From https://flink.apache.org/contributing/contribute-code.html the > community > claims > > - Only start working on the implementation if there is consensus on the > a

[DISCUSS] Drop stale class Program

2019-07-18 Thread Zili Chen
Hi devs, Participating the thread "Flink client api enhancement"[1], I just notice that inside submission codepath of Flink we always has a branch dealing with the case that main class of user program is a subclass of o.a.f.api.common.Program, which is defined as @PublicEvolving public interface

Re: [DISCUSS] Drop stale class Program

2019-07-19 Thread Zili Chen
bandoned it in some later version. > > > > I'm not sure how big the burden is to make it compatible with the > enhanced > > client API. If it's a critical blocker, I support dropping it radically > in > > 1.10. Of course a survey is necessary. And the result of surv

Re: [DISCUSS] Drop stale class Program

2019-07-19 Thread Zili Chen
thread on dev or user list(I would regard this as a user requirement). Best, tison. Zili Chen 于2019年7月19日周五 下午5:10写道: > Hi Biao, > > Thanks for your reply. > > For the "burden" part, inside PackagedProgram and ClusterClient > we currently contains branches handli

Re: Request for permission as a contributor

2019-07-19 Thread Zili Chen
Hi, As an addition, you can checkout https://flink.apache.org/contributing/contribute-code.html to see the contribution workflow. Best, tison. Biao Liu 于2019年7月19日周五 下午5:32写道: > Hi, > > There is no need for contribution permission anymore, see [1]. > > 1. > > http://apache-flink-mailing-list-

Re: Looking for reviewer: FLINK-13127

2019-07-22 Thread Zili Chen
Hi David, Just reviewed and left several comments. Thanks for your contribution! Best, tison. David Morávek 于2019年7月22日周一 下午5:59写道: > Hi, I've prepared a small patch related to Yarn deployment. Would anyone > please have a time to take a look at it? Thanks > > https://github.com/apache/flink/

Re: [DISCUSS] Drop stale class Program

2019-07-22 Thread Zili Chen
ing it. > > > > Usually it costs some time to deprecate a public (actually it's > > > > `PublicEvolving`) API. Ideally it should be marked as `Deprecated` > > first. > > > > Then it might be abandoned it in some later version. > > > > > &

Re: [ANNOUNCE] Zhijiang Wang has been added as a committer to the Flink project

2019-07-22 Thread Zili Chen
Congratulations Zhijiang! Best, tison. Robert Metzger 于2019年7月22日周一 下午10:12写道: > Hey all, > > We've added another committer to the Flink project: Zhijiang Wang. > > Congratulations Zhijiang! > > Best, > Robert > (on behalf of the Flink PMC) >

[Requirement] CI report

2019-07-23 Thread Zili Chen
Hi, Currently, our flinkbot updates CI report on status changing. However, it updates via editing GitHub comment, which would not send a notification to pr creator once status updated. Said the "PENDING" status is not quite useful, is it possible that flinkbot updates a final status(FAILURE/SUCC

Re: [ANNOUNCE] Kete Young is now part of the Flink PMC

2019-07-23 Thread Zili Chen
Congratulations Kurt! Best, tison. JingsongLee 于2019年7月23日周二 下午5:29写道: > Congratulations Kurt! > > Best, Jingsong Lee > > > -- > From:Robert Metzger > Send Time:2019年7月23日(星期二) 17:24 > To:dev > Subject:[ANNOUNCE] Kete Young is n

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-07-23 Thread Zili Chen
another burden for downstream project integration. > > > > > > One thing I'd like to mention is flink's scala shell and sql client, > > > although they are sub-modules of flink, they could be treated as > > downstream > > > project which use flin

Re: [DISSCUSS] Tolerate temporarily suspended ZooKeeper connections

2019-07-28 Thread Zili Chen
Hi committers, Now that we have an ongoing pr[1] to this JIRA, we need a committer to push this thread forward. It would be glad to see this issue fixed in 1.9.0. Best, tison. [1] https://github.com/apache/flink/pull/9158 未来阳光 <2217232...@qq.com> 于2019年7月23日周二 下午9:28写道: > Ok, If you have any

Re: [DISSCUSS] Tolerate temporarily suspended ZooKeeper connections

2019-07-29 Thread Zili Chen
eature freeze has been passed. > We might target 1.10, though. > > Cheers, > Till > > On Mon, Jul 29, 2019 at 3:01 AM Zili Chen wrote: > > > Hi committers, > > > > Now that we have an ongoing pr[1] to this JIRA, we need a committer > > to push this th

Re: [DISCUSS] Drop stale class Program

2019-07-30 Thread Zili Chen
do to make progress? Best, tison. [1] https://lists.apache.org/thread.html/37445e43729cf7eaeb0aa09133d3980b62f891c5ee69d2c3c3e76ab5@%3Cuser.flink.apache.org%3E Zili Chen 于2019年7月22日周一 下午8:38写道: > Hi, > > I created a thread for survey in user list[1]. Please take participate in &

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-07-30 Thread Zili Chen
Hi Thomas, IIUC this "launcher" should run on client endpoint instead of dispatcher endpoint. "jar run" will extract the job graph and submit it to the dispatcher, which has mismatched semantic from your willing. Could you run it with CliFrontend? Or propose that "jar run" supports running direct

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-07-31 Thread Zili Chen
ation. > > > > > > > > One thing I'd like to mention is flink's scala shell and sql client, > > > > although they are sub-modules of flink, they could be treated as > > > downstream > > > > project which use flink's client api. Currently you will find it

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-07-31 Thread Zili Chen
I don't think the `Program` interface could solve the problem. The launcher launches the job server which creates the job graph, submits it and keeps monitoring. Even if user program implement `Program` Flink still extracts the JobGraph from `getPlan` and submits it, instead of really execute code

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-07-31 Thread Zili Chen
receives a JarRun request, it spawns a process and run the main method of the main class of that jar. Best, tison. Zili Chen 于2019年7月31日周三 下午7:10写道: > I don't think the `Program` interface could solve the problem. > > The launcher launches the job server which creates the job graph, &g

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-07-31 Thread Zili Chen
e addition also on the job manager endpoint as > well..what do you think? > > On Wed, Jul 31, 2019 at 12:42 PM Zili Chen wrote: > > > Hi all, > > > > Here is a document[1] on client api enhancement from our perspective. > > We have investigated current implementa

Re: Jira issue assignment privs

2019-08-01 Thread Zili Chen
Hi Mans, There has been an announcement by the community[1] which apply a restrictive JIRA workflow. Briefly now it only allow committers and PMC members to assign somebody to a JIRA ticket. This is what you meet. You could send a request for assigning you to the ticket on dev list and hopefully

[Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-01 Thread Zili Chen
Hi devs, I found that these two classes are quite similar except SingleLeaderElectionService has a pre-config leader id. However, I don't see use points of that leader id. Also a random UUID would work as a DEFAULT_LEADER_ID(0). I consider whether we could replace SingleLeaderElectionService with

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread Zili Chen
Hi Jark, Follow your opinion, for class field, we can make use of @Nullable/@Nonnull annotation or Flink's SerializableOptional. It would be sufficient. Best, tison. Jark Wu 于2019年8月2日周五 下午4:57写道: > Hi Andrey, > > I have some concern on point (3) "even class fields as e.g. optional config > o

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Zili Chen
nner class of EmbeddedLeaderService > and calls methods of this class. Why do you wanna change anything there? > > Cheers, > Till > > On Fri, Aug 2, 2019 at 6:33 AM Zili Chen wrote: > > > Hi devs, > > > > I found that these two classes are quite similar except &

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Zili Chen
. I'm not sure when proceeding FLINK-10333 whether implement such a in memory leader election service or let MiniCluster use the standalone one is preferred. Best, tison. Zili Chen 于2019年8月5日周一 下午4:39写道: > Hi Till, > > SingleLeaderElectionService is an effective

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-08-05 Thread Zili Chen
rver > job server uses RemoteEnvironment to submit real job > main "returns job id" > REST handler returns job id > > Thomas > > > On Wed, Jul 31, 2019 at 4:33 AM Zili Chen wrote: > > > By the way, currently Dispatcher implements RestfulGateway > >

[Request For Review] Refactoring Client API

2019-08-05 Thread Zili Chen
Hi devs, Last week I drafted a design document on refactoring Flink's Client API [1] following the discussion in this thread[2]. Jeff(@zjffdu) and Thomas(@tweise) shared their insights and commented in the doc. Given that client apis are public user-facing interfaces, in order to serve a series o

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Zili Chen
ndy > to have. > > Cheers, > Till > > On Mon, Aug 5, 2019 at 10:43 AM Zili Chen wrote: > > > Investigated the usage of EmbeddedLeaderService, as > > you said, it is mainly used in MiniCluster. > > > > The difference between EmbeddedLeaderService and >

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-05 Thread Zili Chen
; Cheers, > Till > > On Mon, Aug 5, 2019 at 1:52 PM Zili Chen wrote: > > > Yes I can understand the idea. > > > > One more question, as you mentioned, the EmbeddedLeaderService > > is not needed. However, from our current codebase, if we configure > > rest.bi

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-08-05 Thread Zili Chen
tionEnvironment to build it)? > > > On Mon, Aug 5, 2019 at 2:10 AM Zili Chen wrote: > > > Hi Thomas, > > > > If REST handler calls main(), the behavior inside main() is > > unpredictable. > > > > Now the jar run handler extract the job graph and su

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-06 Thread Zili Chen
Thanks for your explanation :) Best, tison. Till Rohrmann 于2019年8月6日周二 下午3:42写道: > If you use the StandaloneHaServices, then you have to define the > `rest.bind-port` upfront. Hence, picking a random port, won't work. > > Cheers, > Till > > On Tue, Aug 6, 2019 a

Re: [ANNOUNCE] Hequn becomes a Flink committer

2019-08-07 Thread Zili Chen
Congrats Hequn! Best, tison. Jeff Zhang 于2019年8月7日周三 下午5:14写道: > Congrats Hequn! > > Paul Lam 于2019年8月7日周三 下午5:08写道: > >> Congrats Hequn! Well deserved! >> >> Best, >> Paul Lam >> >> 在 2019年8月7日,16:28,jincheng sun 写道: >> >> Hi everyone, >> >> I'm very happy to announce that Hequn accepted th

Re: subscripe

2019-08-08 Thread Zili Chen
Hi, To subscribe dev list, you should mail to dev-subscr...@flink.apache.org instead of dev@flink.apache.org. An automatic reply would be sent and you just reply it to subscribe dev list. Best, tison. 疯琴 <35023...@qq.com> 于2019年8月9日周五 上午7:51写道: > I didn't receive any message from you for more

Re: [VOTE] Apache Flink Release 1.9.0, release candidate #2

2019-08-12 Thread Zili Chen
Hi, I just noticed that a few hours ago there were two new issues filed and marked as blockers to 1.9.0[1][2]. Now [1] is closed as duplication but still marked as a blocker to 1.9.0, while [2] is downgrade to "Major" priority but still target to be fixed in 1.9.0. It would be worth to have atte

Re: [VOTE] Apache Flink Release 1.9.0, release candidate #2

2019-08-12 Thread Zili Chen
a, the > issue was just a testing problem, should not be blocker of 1.9.0 release. > However, > we will still merge it into 1.9 branch. > > Best, > Kurt > > > On Mon, Aug 12, 2019 at 5:38 PM Zili Chen wrote: > > > Hi, > > > > I just noticed that

Re: Start contribution

2019-08-12 Thread Zili Chen
Hi Rishindra, It would be helpful to checkout [1] and [2]. For your specific case, it's nice that you speak out your willing to contribute in dev list. It is hopeful other Flink developers participant the discussion about the issue and with consensus one of our committers could assign the ticket

Re: [Discuss] What should the "Data Source" be translated into Chinese

2019-08-13 Thread Zili Chen
Source 和 Sink 的通译是 源 和 汇,data source 和 data sink 因此分别对应 数据源 和 数据汇。出处可参见中国计算机协会的《计算机科学技术名词》,线上检索在这里[1] 但是具体到 FLINK 的情况,实际上我建议所有 FLINK 专有名词都不要翻译,翻译反而增加理解难度。 Best, tison. [1] http://www.termonline.cn/index.htm hsw 于2019年8月13日周二 下午6:46写道: > 赞同,想了半天没想到合适的中文翻译data sink > > > > -

Re: [DISCUSS] Drop stale class Program

2019-08-14 Thread Zili Chen
t; > I am totally up for removing the unused Program interface, as this > will > > > > simplify a lot of other code paths in the ClusterClient and > elsewhere. > > > > > > > > Also about the easier integration of Flink with other frameworks, > there > &g

Re: [DISCUSS] FLIP-52: Remove legacy Program interface.

2019-08-14 Thread Zili Chen
+1 It could be regarded as part of Flink client api refactor. Removal of stale code paths helps reason refactor. There is one thing worth attention that in this thread[1] Thomas suggests an interface with a method return JobGraph based on the fact that REST API and in per job mode actually extrac

Re: [ANNOUNCE] Andrey Zagrebin becomes a Flink committer

2019-08-14 Thread Zili Chen
Congratulations Andrey! Best, tison. Till Rohrmann 于2019年8月14日周三 下午9:26写道: > Hi everyone, > > I'm very happy to announce that Andrey Zagrebin accepted the offer of the > Flink PMC to become a committer of the Flink project. > > Andrey has been an active community member for more than 15 months

Re: [DISCUSS] FLIP-54: Evolve ConfigOption and Configuration

2019-08-16 Thread Zili Chen
Hi Timo, It looks interesting. Thanks for preparing this FLIP! Client API enhancement benefit from this evolution which hopefully provides a better view of configuration of Flink. In client API enhancement, we likely make the deployment of cluster and submission of job totally defined by configur

Re: [VOTE] Apache Flink Release 1.9.0, release candidate #2

2019-08-18 Thread Zili Chen
> > > > > > >>>>>> create > > > > > > > > > > > >>>>>>> the > > > > > > > > > > > >>>>>>>>> source and sinks. looks good. > > > > > > > &

Re: [DISCUSS] FLIP-56: Dynamic Slot Allocation

2019-08-19 Thread Zili Chen
We suddenly skipped FLIP-55 lol. Xintong Song 于2019年8月19日周一 下午10:23写道: > Hi everyone, > > We would like to start a discussion thread on "FLIP-56: Dynamic Slot > Allocation" [1]. This is originally part of the discussion thread for > "FLIP-53: Fine Grained Resource Management" [2]. As Till sugge

Re: [VOTE] Apache Flink 1.9.0, release candidate #3

2019-08-19 Thread Zili Chen
+1 (non-binding) - build from source: OK(8u212) - check local setup tutorial works as expected Best, tison. Yu Li 于2019年8月20日周二 上午8:24写道: > +1 (non-binding) > > - checked release notes: OK > - checked sums and signatures: OK > - repository appears to contain all expected artifacts > - source

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-08-19 Thread Zili Chen
sting things that we need to consider. > > Best, > Aljoscha > > [1] > https://docs.google.com/document/d/1E-8UjOLz4QPUTxetGWbU23OlsIH9VIdodpTsxwoQTs0/edit#heading=h.na7k0ad88tix > < > https://docs.google.com/document/d/1E-8UjOLz4QPUTxetGWbU23OlsIH9VIdodpTsxwoQTs0/edit#heading=

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-08-20 Thread Zili Chen
ment. Zili Chen 于2019年8月20日周二 下午12:37写道: > Hi Aljoscha, > > Thanks for your reply and participance. The Google Doc you linked to > requires > permission and I think you could use a share link instead. > > I agree with that we almost reach a consensus that JobClient is necessar

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-08-20 Thread Zili Chen
path). > > > In the YARN, Mesos and Kubernetes scenarios you have the jar but you > > could > > > start a cluster that has the jar on the Job Manager as well (but this > is > > > the only case where I think you can assume that the client has the jar > on > >

Re: [DISCUSS][CODE STYLE] Breaking long function argument lists and chained method calls

2019-08-20 Thread Zili Chen
Implement question: how to apply the line length rules? If we just turn on checkstyle rule "LineLength" then a huge effort is required to break lines those break the rule. If we use an auto-formatter here then it possibly break line "just at the position" awfully. Is it possible we require only t

[SURVEY] How do you use high-availability services in Flink?

2019-08-21 Thread Zili Chen
Hi guys, We want to have an accurate idea of how users actually use high-availability services in Flink, especially how you customize high-availability services by HighAvailabilityServicesFactory. Basically there are standalone impl., zookeeper impl., embedded impl. used in MiniCluster, YARN impl

Re: [SURVEY] How do you use high-availability services in Flink?

2019-08-21 Thread Zili Chen
In addition, FLINK-13750[1] also likely introduce breaking change on high-availability services. So it is highly encouraged you who might be affected by the change share your cases :-) Best, tison. [1] https://issues.apache.org/jira/browse/FLINK-13750 Zili Chen 于2019年8月21日周三 下午3:32写道: >

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-21 Thread Zili Chen
; > >>>>>>>>> > > >>>>>>>>> It is often the case that domain objects hang about in memory > > >> for a > > >>>>>> fair > > >>>>>>>>> while, as processing in the app

Re: [DISCUSS][CODE STYLE] Breaking long function argument lists and chained method calls

2019-08-21 Thread Zili Chen
> I suggest we spawn separate discussion threads (can do as a follow-up) > about: > >- the hard line length limit in Java, possibly to confirm it also for >Scala (cc @Tison) >- indentation rules for the broken list of a declared function arguments > > If there ar

Re: CiBot Update

2019-08-21 Thread Zili Chen
Thanks for your announcement. Nice work! Best, tison. vino yang 于2019年8月22日周四 上午8:14写道: > +1 for "@flinkbot run travis", it is very convenient. > > Chesnay Schepler 于2019年8月21日周三 下午9:12写道: > > > Hi everyone, > > > > this is an update on recent changes to the CI bot. > > > > > > The bot now ca

Re: [DISCUSS][CODE STYLE] Breaking long function argument lists and chained method calls

2019-08-22 Thread Zili Chen
because parentheses are aligned in a similar way, as well as the border between declaration and function body is clear. Zili Chen 于2019年8月22日周四 上午9:53写道: > Thanks Andrey for driving the discussion. Just for clarification, > what we conclude here are several guidelines without automatic >

Re: [ANNOUNCE] Apache Flink 1.9.0 released

2019-08-22 Thread Zili Chen
Congratulations! Thanks Gordon and Kurt for being the release manager. Thanks all the contributors who have made this release possible. Best, tison. Jark Wu 于2019年8月22日周四 下午8:11写道: > Congratulations! > > Thanks Gordon and Kurt for being the release manager and thanks a lot to > all the contr

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-08-22 Thread Zili Chen
loaded by user class loader > > to avoid class conflict with framework. > > > > Anyway, both of the two submission modes are useful. > > We just need to clarify the concepts. > > > > > Best, > > Yang > > Zili Chen 于2019年8月20日周二 下午5:58写道: > >

Re: [ANNOUNCE] Apache Flink 1.9.0 released

2019-08-23 Thread Zili Chen
Hi Gavin, I also find a problem in shell if the directory contain whitespace then the final command to run is incorrect. Could you check the final command to be executed? FYI, here is the ticket[1]. Best, tison. [1] https://issues.apache.org/jira/browse/FLINK-13827 Gavin Lee 于2019年8月23日周五 下午

Re: [ANNOUNCE] Apache Flink 1.9.0 released

2019-08-23 Thread Zili Chen
ectory under root folder of flink distribution. > > > On Fri, Aug 23, 2019 at 4:10 PM Zili Chen wrote: > >> Hi Gavin, >> >> I also find a problem in shell if the directory contain whitespace >> then the final command to run is incorrect. Could you check the >>

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-08-23 Thread Zili Chen
ication to his running job. > > > > On the topic of not hijacking the "env.execute()" in order to get the > > Plan, I definitely agree but > > for the proposal of having a "compile()" method in the env, I would > > like to have a better look at >

Re: [ANNOUNCE] Apache Flink 1.9.0 released

2019-08-23 Thread Zili Chen
ss was removed in flink-dist_2.12-1.9 >> jar >> file. >> Seems broken here for scala 2.12, right? >> >> [1] >> >> http://mirror.bit.edu.cn/apache/flink/flink-1.9.0/flink-1.9.0-bin-scala_2.12.tgz >> >> On Fri, Aug 23, 2019 at 4:37 PM Zili Chen

Re: [DISCUSS] Use Java's Duration instead of Flink's Time

2019-08-23 Thread Zili Chen
Hi Stephan, I like the idea unify usage of time/duration api. We actually use at least five different classes for this purposes(see below). One thing I'd like to pick up is that duration configuration in Flink is almost in pattern as "60 s" that fits in the pattern parsed by scala.concurrent.dura

Re: [DISCUSS] Use Java's Duration instead of Flink's Time

2019-08-23 Thread Zili Chen
with the Duration class in Java. Java and Scala have > different types of systems. Currently, Duration (scala) and FineDuration > (scala) work well. In addition, this work brings additional complexity and > cost compared to the gains obtained. > > Best, > Vino > > Zili Chen 于201

Re: [DISSCUSS] Tolerate temporarily suspended ZooKeeper connections

2019-08-25 Thread Zili Chen
Hi Till, I'd like to revive this thread since 1.9.0 has been released. IMHO we already reached a consensus on JIRA and if you can review the pull request we hopefully address the issue in next release. Best, tison. Zili Chen 于2019年7月29日周一 下午11:05写道: > Hi Till, > > T

Re: [ANNOUNCE] Apache Flink 1.9.0 released

2019-08-26 Thread Zili Chen
Hi Oytun, I think it intents to publish flink-queryable-state-client-java without scala suffix since it is scala-free. An artifact without scala suffix has been published [2]. See also [1]. Best, tison. [1] https://issues.apache.org/jira/browse/FLINK-12602 [2] https://mvnrepository.com/artifact

[DISCUSS] Builder dedicated for testing

2019-08-26 Thread Zili Chen
Hi devs, I'd like to share an observation that we have too many @VisibleForTesting constructors that only used in test scope such as ExecutionGraph and RestClusterClient. It would be helpful if we introduce Builders in test scope for build such instance and remain the production code only necessa

Re: [VOTE] FLIP-54: Evolve ConfigOption and Configuration

2019-08-28 Thread Zili Chen
The design looks good to me. +1 go ahead! Best, tison. Jark Wu 于2019年8月28日周三 下午6:08写道: > Hi Timo, > > The new changes looks good to me. > > +1 to the FLIP. > > > Cheers, > Jark > > On Wed, 28 Aug 2019 at 16:02, Timo Walther wrote: > > > Hi everyone, > > > > after some last minute changes yes

Re: [DISCUSS] FLIP-50: Spill-able Heap Keyed State Backend

2019-08-29 Thread Zili Chen
Hi Yu, Notice that the wiki is still marked as "*Under Discussion*" state. I think you can update it correspondingly. Best, tison. Yu Li 于2019年8月20日周二 下午10:28写道: > Sorry for the lag but since we've got a consensus days ago, I started a > vote thread which will have a result by EOD, thus I'm

[PROPOSAL] Force rebase on master before merge

2019-08-29 Thread Zili Chen
Hi devs, GitHub provides a mechanism which is able to require branches to be up to date before merged[1](point 6). I can see several advantages enabling it. Thus propose our project to turn on this switch. Below are my concerns. Looking forward to your insights. 1. Avoid CI failures in pr which f

Re: [PROPOSAL] Force rebase on master before merge

2019-08-29 Thread Zili Chen
ntee the testing time. > > To summarize: I think this should be decided by the committer who is > merging the PR, > but not be forced. > > Best, > Kurt > > > On Thu, Aug 29, 2019 at 11:07 PM Zili Chen wrote: > > > Hi devs, > > > > GitHub provide

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-08-30 Thread Zili Chen
link run -d -p 5 -ynm perjob-cluster1 -m yarn-cluster > > > examples/streaming/WindowJoin.jar > > > *session cluster* > > > ./bin/flink run -p 5 -ynm session-cluster1 -m yarn-cluster > > > examples/streaming/WindowJoin.jar > > > > > > What will it look like

Re: [PROPOSAL] Force rebase on master before merge

2019-09-01 Thread Zili Chen
mistakes out of the equation. > >> > >> Do you know how these status checks work concretely? Will Github reject > >> commits for which there is no passed Travis run? How would hotfix > commits > >> being distinguished from PR commits for which a Travis run s

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-09-04 Thread Zili Chen
that we join forces of our community. Best, tison. Zili Chen 于2019年8月31日周六 下午12:52写道: > Great Kostas! Looking forward to your POC! > > Best, > tison. > > > Jeff Zhang 于2019年8月30日周五 下午11:07写道: > >> Awesome, @Kostas Looking forward your POC. >> >> Kost

Re: [VOTE] FLIP-61 Simplify Flink's cluster level RestartStrategy configuration

2019-09-04 Thread Zili Chen
+1 zhijiang 于2019年9月5日周四 上午12:36写道: > +1 > -- > From:Till Rohrmann > Send Time:2019年9月4日(星期三) 13:39 > To:dev > Cc:Zhu Zhu > Subject:Re: [VOTE] FLIP-61 Simplify Flink's cluster level RestartStrategy > configuration > > +1 (bindin

Re: [ANNOUNCE] Kostas Kloudas joins the Flink PMC

2019-09-06 Thread Zili Chen
Congrats Klou! Best, tison. Till Rohrmann 于2019年9月6日周五 下午9:23写道: > Congrats Klou! > > Cheers, > Till > > On Fri, Sep 6, 2019 at 3:00 PM Dian Fu wrote: > >> Congratulations Kostas! >> >> Regards, >> Dian >> >> > 在 2019年9月6日,下午8:58,Wesley Peng 写道: >> > >> > On 2019/9/6 8:55 下午, Fabian Hueske w

[DISCUSS] Retrieval services in non-high-availability scenario

2019-09-09 Thread Zili Chen
Hi devs, I'd like to start a discussion thread on the topic how we provide retrieval services in non-high-availability scenario. To clarify terminology, non-high-availability scenario refers to StandaloneHaServices and EmbeddedHaServices. ***The problem*** We notice that retrieval services of cu

Re: [DISCUSS] Retrieval services in non-high-availability scenario

2019-09-10 Thread Zili Chen
HAServices is actually orthogonal to > introducing the LeaderServer HAServices implementation and could also be > done for the existing HAServices. > > 4. Clean up of HAServices implementations: > > You are right that some of the existing HAServices implementations are > "d

Re: [DISCUSS] Retrieval services in non-high-availability scenario

2019-09-10 Thread Zili Chen
converges to be stable. Best, tison. Till Rohrmann 于2019年9月10日周二 下午6:06写道: > Hi Tison, > > thanks for the detailed response. I put some comments inline: > > On Tue, Sep 10, 2019 at 10:51 AM Zili Chen wrote: > > > Hi Till, > > > > Thanks for your reply. I agree poin

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-09-11 Thread Zili Chen
think? >> >> P.S. Committers/PMCs should should be able to login with their apache ID. >> >> Best, >> Aljoscha >> >> > On 6. Sep 2019, at 14:24, Zili Chen wrote: >> > >> > Hi Aljoscha, >> > >> > I'd like to gather

Re: Interested in contributing and looking for good first issues

2019-09-12 Thread Zili Chen
Hi Anoop, Welcome to the Flick community. Although we don't maintain a list of starter issues so far, it would be helpful if you provide more information about which topic you are interested in. Flink servers stateful computations over data streams based on a series of layered concepts, such as S

Re: [DISCUSS] Use Java's Duration instead of Flink's Time

2019-09-12 Thread Zili Chen
I Xiaogang > > > > > wrote: > > > > > > > > > +1 to replace Flink's time with Java's Duration. > > > > > > > > > > Besides, i also suggest to use Java's Instant for "point-in-time". > > >

Re: [ANNOUNCE] Zili Chen becomes a Flink committer

2019-09-12 Thread Zili Chen
Thanks a lot everyone for the warm welcome. Happy Mid-autumn Festival! Best, tison. Leonard Xu 于2019年9月12日周四 上午11:05写道: > Congratulations Zili Chen ! ! > > Best, > Leonard Xu > > On 2019年9月12日, at 上午11:02, Yun Tang wrote: > > > > Congratulations

[PROPOSAL] Merge NewClusterClient into ClusterClient

2019-09-17 Thread Zili Chen
Hi devs, FLINK-14096[1] was created yesterday. It is aimed at merge the bridge class NewClusterClient into ClusterClient because with the effort under FLINK-10392 this bridge class is no longer necessary. Technically in current codebase all implementation of interface NewClusterClient is subclass

Re: [PROPOSAL] Merge NewClusterClient into ClusterClient

2019-09-17 Thread Zili Chen
tice there're many implementation details in > ClusterClient. I think we should just expose a thin interface, so maybe we > can create interface ClusterClient which includes as less methods as > possible, and move all the implementation to AbstractClusterClient. > > > > &

Re: [PROPOSAL] Merge NewClusterClient into ClusterClient

2019-09-18 Thread Zili Chen
lity for > > non-well-designed api, otherwise it will bring lots of unnecessary > > overhead. > > > > 2. Another concern is that I notice there're many implementation details > in > > ClusterClient. I think we should just expose a thin interface, so maybe >

Re: [VOTE] Release flink-connector-pulsar 3.0.1, release candidate #1

2023-05-31 Thread Zili Chen
+1 I verified + LICENSE and NOTICE present + Checksum and GPG sign matches + No unexpected binaries in the source release + Build from source and run unit tests with JDK 17 on macOS M1 On 2023/05/25 16:18:51 Leonard Xu wrote: > Hey all, > > Please review and vote on the release candidate #1 for

Confluence permission for FLIP creation

2019-09-19 Thread Zili Chen
Hi devs, I'd like to create a page about the ongoing JobClient FLIP. Could you grant me Confluence permission for FLIP creation? My Confluence ID is tison. Best, tison.

Re: Confluence permission for FLIP creation

2019-09-19 Thread Zili Chen
Thanks! Best, tison. Till Rohrmann 于2019年9月19日周四 下午5:34写道: > Granted. You should now be able to create pages Tison. > > Cheers, > Till > > On Thu, Sep 19, 2019 at 11:01 AM Zili Chen wrote: > > > Hi devs, > > > > I'd like to create a page about the

Re: [PROPOSAL] Merge NewClusterClient into ClusterClient

2019-09-19 Thread Zili Chen
what Till (cc’ed) says, maybe he has an opinion on why > > the separation should be kept. > > > > Best, > > Aljoscha > > > > > On 18. Sep 2019, at 11:54, Zili Chen wrote: > > > > > > Hi Xiaogang, > > > > > > Thanks for your rep

Re: How to prevent from launching 2 jobs at the same time

2019-09-22 Thread Zili Chen
The situation is as Dian said. Flink identifies jobs by job id instead of job name. However, I think it is still a valid question if it is an alternative Flink identifies jobs by job name and leaves the work to distinguish jobs by name to users. The advantages in this way includes a readable displ

Re: [DISCUSS] FLIP-73: Introducing Executors for job submission

2019-09-24 Thread Zili Chen
Hi Thomas, >Should the new Executor execute method be defined as asynchronous? It could >return a job handle to interact with the job and the legacy environments >can still block to retain their semantics. During our discussion there will be a method executeAsync(...): CompletableFuture where J

Re: [DISCUSS] FLIP-73: Introducing Executors for job submission

2019-09-24 Thread Zili Chen
eise 于2019年9月25日周三 上午2:39写道: > Since Exceutor is a new interface, why is backward compatibility a concern? > > I could see that become an issue later when replacing Executor execute with > executeAsync. Or are both targeted for 1.10? > > > On Tue, Sep 24, 2019 at 10

[DISCUSS] Expose multiple level clients

2019-09-25 Thread Zili Chen
Hi all, While drafting FLIP-74 I notice that a job level client(called JobClient) is always retrieved from a Flink application cluster level client(called ClusterClient), which is then always retrieved from a extern cluster(YARN, mesos, k8s, etc.) level client(called ClusterDescriptor). A Flink j

[DISCUSS] FLIP-74: Flink JobClient API

2019-09-25 Thread Zili Chen
Hi all, Summary from the discussion about introducing Flink JobClient API[1] we draft FLIP-74[2] to gather thoughts and towards a standard public user-facing interfaces. This discussion thread aims at standardizing job level client API. But I'd like to emphasize that how to retrieve JobClient pos

Re: CiBot Update

2019-09-25 Thread Zili Chen
t; Zhu Zhu > > >>>>>>>> > > >>>>>>>> zhijiang > wangzhijiang...@aliyun.com.invalid>> 于2019年8月22日周四 下午4:18写道: > > >>>>>>>> > > >>>>>>>>> It is really very convenient no

[DISCUSS] Remove uncompleted YARNHighAvailabilityService

2019-09-26 Thread Zili Chen
Hi devs, Noticed that there are several stale & uncompleted high-availability services implementations, I start this thread in order to see whether or not we can remove them for a clean codebase work on the ongoing high-availability refactor effort[1]. Below are all of classes I noticed. - YarnH

  1   2   3   >