Re: [Re-DISCUSS] FLIP-202: Introduce ClickHouse Connector

2023-08-24 Thread Sergey Nuyanzin
Hi Conrad, Thanks for driving it. In general I'm +1 however I have a couple of questions 1. From FLIP's description it is not clear whether this connector will support Async sink [1] or not, could you please clarify it? 2. Also may be a bit more details in FLIP's page would helpful why a new co

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-24 Thread Jark Wu
Hi Becket, I think it is the second case, that a FieldReferenceExpression is constructed by the framework and passed to the connector (interfaces listed by Venkata[1] and Catalog#listPartitionsByFilter). Besides, understanding the nested field is optional for users/connectors (just treat it as an

[jira] [Created] (FLINK-32951) VertexFlameGraphFactoryTest.testLambdaClassNamesCleanUp failed on AZP

2023-08-24 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32951: --- Summary: VertexFlameGraphFactoryTest.testLambdaClassNamesCleanUp failed on AZP Key: FLINK-32951 URL: https://issues.apache.org/jira/browse/FLINK-32951 Project:

[jira] [Created] (FLINK-32952) Source reuse with readable metadata and watermark push down will get wrong watermark

2023-08-24 Thread Yunhong Zheng (Jira)
Yunhong Zheng created FLINK-32952: - Summary: Source reuse with readable metadata and watermark push down will get wrong watermark Key: FLINK-32952 URL: https://issues.apache.org/jira/browse/FLINK-32952

[jira] [Created] (FLINK-32953) [State TTL]resolve data correctness problem after ttl was changed

2023-08-24 Thread Jinzhong Li (Jira)
Jinzhong Li created FLINK-32953: --- Summary: [State TTL]resolve data correctness problem after ttl was changed Key: FLINK-32953 URL: https://issues.apache.org/jira/browse/FLINK-32953 Project: Flink

Propose a release of flink-connector-opensearch

2023-08-24 Thread Ilyevsky, Leonid
Hi everybody, I would like to propose a release of https://github.com/apache/flink-connector-opensearch which includes the latest enhancements and fixes. I believe the latest commit https://github.com/apache/flink-connector-opensearch/commi

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-24 Thread Venkatakrishnan Sowrirajan
Jark, How about having a separate NestedFieldReferenceExpression, and > abstracting a common base class "ReferenceExpression" for > NestedFieldReferenceExpression and FieldReferenceExpression? This makes > unifying expressions in > "SupportsProjectionPushdown#applyProjections(List > ...)" > possib

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-24 Thread Venkatakrishnan Sowrirajan
To keep it backwards compatible, introduce another API *applyAggregates *with *List *when nested field support is added and deprecate the current API. This will by default throw an exception. In flink planner, *applyAggregates *with nested fields and if it throws exception then *applyAggregates* wi

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-24 Thread yh z
Hi, Venkat, Thanks for the FLIP, it sounds good to support nested fields filter pushdown. Based on the design of flip and the above options, I would like to make a few suggestions: 1. At present, introducing NestedFieldReferenceExpression looks like a better solution, which can fully meet our re

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-24 Thread Becket Qin
Hi Jark, How about having a separate NestedFieldReferenceExpression, and > abstracting a common base class "ReferenceExpression" for > NestedFieldReferenceExpression and FieldReferenceExpression? This makes > unifying expressions in > "SupportsProjectionPushdown#applyProjections(List > ...)" > pos

[jira] [Created] (FLINK-32954) Metrics expose number of heap timer

2023-08-24 Thread Rui Xia (Jira)
Rui Xia created FLINK-32954: --- Summary: Metrics expose number of heap timer Key: FLINK-32954 URL: https://issues.apache.org/jira/browse/FLINK-32954 Project: Flink Issue Type: Improvement C

[jira] [Created] (FLINK-32955) Support state compatibility between enabling TTL and disabling TTL

2023-08-24 Thread Jinzhong Li (Jira)
Jinzhong Li created FLINK-32955: --- Summary: Support state compatibility between enabling TTL and disabling TTL Key: FLINK-32955 URL: https://issues.apache.org/jira/browse/FLINK-32955 Project: Flink

Re: [Discuss] FLIP-355: Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-08-24 Thread Venkatakrishnan Sowrirajan
Thanks Yang Wang. In that case, whenever you get a chance could you please review the PR? On Wed, Aug 23, 2023, 8:15 PM Yang Wang wrote: > +1 for this FLIP > > Maybe a FLIP is an overkill for this enhancement. > > > Best, > Yang > > Venkatakrishnan Sowrirajan 于2023年8月23日周三 01:44写道: > > > Than