Re: [ANNOUNCE] Performance Daily Monitoring Moved from Ververica to Apache Flink Slack Channel

2023-06-26 Thread 柳尘
Thanks, Yanfei, to drive this and make the performance monitoring publicly available. I'd like to join as a maintainer. Looking forward to the workflow. Best xingyuan yanfei lei 于2022年10月26日周三 11:33写道: > Hi everyone, > > As discussed earlier, we plan to create a benchmark channel in Apache

[jira] [Created] (FLINK-32435) Merge testing implementations of LeaderContender

2023-06-26 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32435: - Summary: Merge testing implementations of LeaderContender Key: FLINK-32435 URL: https://issues.apache.org/jira/browse/FLINK-32435 Project: Flink Issue Type

[jira] [Created] (FLINK-32436) Remove obsolete LeaderContender.getDescription method

2023-06-26 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32436: - Summary: Remove obsolete LeaderContender.getDescription method Key: FLINK-32436 URL: https://issues.apache.org/jira/browse/FLINK-32436 Project: Flink Issue

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-06-26 Thread Leonard Xu
Thanks Dong for driving this FLIP forward! Introducing `backlog status` concept for flink job makes sense to me as following reasons: From concept/API design perspective, it’s more general and natural than above proposals as it can be used in HybridSource for bounded records, CDC Source for h

[jira] [Created] (FLINK-32437) Determine and set correct maxParallelism for operator chains

2023-06-26 Thread Stefan Richter (Jira)
Stefan Richter created FLINK-32437: -- Summary: Determine and set correct maxParallelism for operator chains Key: FLINK-32437 URL: https://issues.apache.org/jira/browse/FLINK-32437 Project: Flink

Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-26 Thread Dunn Bangui
Hi yuxia, Thank you for reviewing the code. Specifically, when users set *'sink.partition-commit.policy.class.parameters=''*, the 'parameters' will not be null but will be an empty list. In this case, it may still invoke the constructor with empty arguments. To address this, maybe we can use the

Re: [DISCUSS] Graduate the FileSink to @PublicEvolving

2023-06-26 Thread Jing Ge
Hi, @Galen @Yuxia Your points are valid. Speaking of removing deprecated API, I have the same concern. As a matter of fact, I have been raising it in the discussion thread of API deprecation process[1]. This is another example that we should care about more factors than the migration period, than

Re: [DISCUSS] FLIP-321: Introduce an API deprecation process

2023-06-26 Thread Jing Ge
Hi all, Just want to make sure we are on the same page. There is another example[1] I was aware of recently that shows why more factors need to be taken care of than just the migration period. Thanks Galen for your hint. To put it simply, the concern about API deprecation is not that deprecated A

Re: [DISCUSS] Release 2.0 Work Items

2023-06-26 Thread Chesnay Schepler
by-and-large I'm quite happy with the list of items. I'm curious as to why the "Disaggregated State Management" item is marked as a must-have; will it require changes that break something? What prevents it from being added in 2.1? We may want to update the Java 17 item to "Make Java 17 the de

[jira] [Created] (FLINK-32438) Merge AbstractZooKeeperHaServices and ZooKeeperMultipleComponentLeaderElectionHaServices

2023-06-26 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32438: - Summary: Merge AbstractZooKeeperHaServices and ZooKeeperMultipleComponentLeaderElectionHaServices Key: FLINK-32438 URL: https://issues.apache.org/jira/browse/FLINK-32438

Re: [DISCUSS] FLIP-316: Introduce SQL Driver

2023-06-26 Thread Paul Lam
Hi Shengkai, > * How can we ship the json plan to the JobManager? The Flink K8s module should be responsible for file distribution. We could introduce an option like `kubernetes.storage.dir`. For each flink cluster, there would be a dedicated subdirectory, with the pattern like `${kubernetes

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #2

2023-06-26 Thread Leonard Xu
+1 (binding) - built from source code succeeded - verified signatures - verified hashsums - checked release notes - checked the contents contains jar and pom files in apache repo - reviewed the web PR Best, Leonard > On Jun 19, 2023, at 6:57 PM, Danny Cranmer wrote: > > Thanks for driving t

[jira] [Created] (FLINK-32439) Kubernetes operator is silently overwriting the "execution.savepoint.path" config

2023-06-26 Thread Robert Metzger (Jira)
Robert Metzger created FLINK-32439: -- Summary: Kubernetes operator is silently overwriting the "execution.savepoint.path" config Key: FLINK-32439 URL: https://issues.apache.org/jira/browse/FLINK-32439

[VOTE] Apache Flink ML Release 2.3.0, release candidate #1

2023-06-26 Thread Dong Lin
Hi everyone, We would like to start voting for the Flink ML 2.3.0 release. This release primarily provides the ability to run Flink ML on Flink 1.15, 1.16 and 1.17. Please review and vote on the release candidate #1 for version 2.3.0 of Apache Flink ML as follows. [ ] +1, Approve the release [ ]

Re: [DISCUSS] FLIP-321: Introduce an API deprecation process

2023-06-26 Thread Xintong Song
> > Considering DataStream API is the most fundamental and complex API of > Flink, I think it is worth a longer time than the general process for the > deprecation period to wait for the new API be mature. > This inspires me. In this specific case, compared to how long should DataStream API be rem

Re: [DISCUSS] Flink REST API improvements

2023-06-26 Thread David Morávek
Hi Hong, Thanks for starting the discussion. seems to be using the cached version of the entire Execution graph (stale > data), when it could just use the CheckpointStatsCache directly CheckpointStatsCache is also populated using the "cached execution graph," so there is nothing to gain from th

Re: [DISCUSS] Release 2.0 Work Items

2023-06-26 Thread Xintong Song
> > The ProcessFunction API item is giving me the most headaches because it's > very unclear what it actually entails; like is it an entirely separate API > to DataStream (sounds like it is!) or an extension of DataStream. How much > will it share the internals with DataStream etc.; how does it rel

[jira] [Created] (FLINK-32440) Introduce file merging configuration

2023-06-26 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-32440: -- Summary: Introduce file merging configuration Key: FLINK-32440 URL: https://issues.apache.org/jira/browse/FLINK-32440 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] Flink REST API improvements

2023-06-26 Thread Hong Teoh
Thanks David for the feedback! > CheckpointStatsCache is also populated using the "cached execution graph," > so there is nothing to gain from the "staleness" pov; see > AbstractCheckpointHandler for more details. You are right about the CheckpointStatisticsCache. Sorry I was referring to the “

Re: [DISCUSS] Persistent SQL Gateway

2023-06-26 Thread Ferenc Csaky
Hi Jark, Thank you for pointing out FLIP-295 abouth catalog persistence, I was not aware the current state. Although as far as I see, that persistent catalogs are necessary, but not sufficient achieving a "persistent gateway". The current implementation ties the job lifecycle to the SQL gateway

[jira] [Created] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-26 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32441: --- Summary: DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP Key: FLINK-32441 URL: https://issues.apache.org/jira/browse/FLINK-32441

[jira] [Created] (FLINK-32442) DownloadPipelineArtifact fails on AZP

2023-06-26 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32442: --- Summary: DownloadPipelineArtifact fails on AZP Key: FLINK-32442 URL: https://issues.apache.org/jira/browse/FLINK-32442 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-316: Introduce SQL Driver

2023-06-26 Thread Jing Ge
Hi Paul, Thanks for driving it and thank you all for the informative discussion! The FLIP is in good shape now. As described in the FLIP, SQL Driver will be mainly used to run Flink SQLs in two scenarios: 1. SQL client/gateway in application mode and 2. external system integration. Would you like

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #2

2023-06-26 Thread Sergey Nuyanzin
+1 (non-binding) - verified hashes - verified signatures - built from sources - checked release notes - review web pr Non-blocking finding: it seems the release date in web PR should be changed On Mon, Jun 26, 2023 at 1:34 PM Leonard Xu wrote: > +1 (binding) > > - built from source code succ

Re: [DISCUSS] FLIP-321: Introduce an API deprecation process

2023-06-26 Thread Becket Qin
Hi Xintong, Jark and Jing, Thanks for the reply. Yes, we can only mark the DataStream API as @Deprecated after the ProcessFunction API is fully functional and mature. It is a fair point that the condition of marking a @Public API as deprecated should also be a part of this FLIP. I just added that

Re: [DISCUSS] Persistent SQL Gateway

2023-06-26 Thread Jark Wu
Hi Ferenc, But the job lifecycle doesn't tie to the SQL Gateway session. Even if the session is closed, all the running jobs are not affected. Best, Jark On Tue, 27 Jun 2023 at 04:14, Ferenc Csaky wrote: > Hi Jark, > > Thank you for pointing out FLIP-295 abouth catalog persistence, I was no

Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-26 Thread yuxia
I have another round of review and left comment in your pr. But please let's keep discuss about adding the Custom Commit Policy with Parameter itself in this thread instead of talk about the pr. Best regards, Yuxia - 原始邮件 - 发件人: "Dunn Bangui" 收件人: "dev" 发送时间: 星期一, 2023年 6 月 26日 下午 5:3

Re:Re: [DISCUSS] FLIP-303: Support REPLACE TABLE AS SELECT statement

2023-06-26 Thread Mang Zhang
Hi yuxia, +1 for this new feature. In particular, the CREATE OR REPLACE TABLE syntax is more usable and faster for users. -- Best regards, Mang Zhang At 2023-06-26 09:46:40, "yuxia" wrote: >Hi, folks. >To save the time of reviewers, I would like to summary the main changes of >this F

[jira] [Created] (FLINK-32443) Translate "State Processor API" page into Chinese

2023-06-26 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-32443: -- Summary: Translate "State Processor API" page into Chinese Key: FLINK-32443 URL: https://issues.apache.org/jira/browse/FLINK-32443 Project: Flink Issue Type: Imp

[jira] [Created] (FLINK-32444) Enable object reuse for Flink SQL jobs by default

2023-06-26 Thread Jark Wu (Jira)
Jark Wu created FLINK-32444: --- Summary: Enable object reuse for Flink SQL jobs by default Key: FLINK-32444 URL: https://issues.apache.org/jira/browse/FLINK-32444 Project: Flink Issue Type: New Featu

Re: [DISCUSS] FLIP-303: Support REPLACE TABLE AS SELECT statement

2023-06-26 Thread yuxia
Hi, all. Thanks for the feedback. If there are no other questions or concerns for the FLIP[1], I'd like to start the vote tomorrow (6.28). [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-303%3A+Support+REPLACE+TABLE+AS+SELECT+statement Best regards, Yuxia 发件人: "zhangmang1"

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-06-26 Thread Dong Lin
Thank you Leonard for the review! Hi Piotr, do you have any comments on the latest proposal? I am wondering if it is OK to start the voting thread this week. On Mon, Jun 26, 2023 at 4:10 PM Leonard Xu wrote: > Thanks Dong for driving this FLIP forward! > > Introducing `backlog status` concept