+1 (non-binding) - verified hashes - verified signatures - built from sources - checked release notes - review web pr
Non-blocking finding: it seems the release date in web PR should be changed On Mon, Jun 26, 2023 at 1:34 PM Leonard Xu <xbjt...@gmail.com> wrote: > +1 (binding) > > - built from source code succeeded > - verified signatures > - verified hashsums > - checked release notes > - checked the contents contains jar and pom files in apache repo > - reviewed the web PR > > Best, > Leonard > > > On Jun 19, 2023, at 6:57 PM, Danny Cranmer <dannycran...@apache.org> > wrote: > > > > Thanks for driving this Martijn. > > > > +1 (binding) > > > > - Reviewed web PR > > - Jira release notes look good > > - Tag exists in Github > > - Source archive signature/checksum looks good > > - Binary (from Maven) signature/checksum looks good > > - No binaries in the source archive > > - Source archive builds from source and tests pass > > - CI passes [1] > > > > Non blocking findings: > > - NOTICE files year is 2022 and needs to be updated to 2023 > > - pom.xml is referencing Flink 1.17.0 and can be updated to 1.17.1 > > - Some unit tests (notably OracleExactlyOnceSinkE2eTest) appear to be > > integration/e2e and are run in the unit test suite > > > > Thanks, > > Danny > > > > [1] > https://github.com/apache/flink-connector-jdbc/actions/runs/5278297177 > > > > On Thu, Jun 15, 2023 at 12:40 PM Martijn Visser < > martijnvis...@apache.org> > > wrote: > > > >> Hi everyone, > >> Please review and vote on the release candidate #2 for the version > 3.1.1, > >> as follows: > >> [ ] +1, Approve the release > >> [ ] -1, Do not approve the release (please provide specific comments) > >> > >> > >> The complete staging area is available for your review, which includes: > >> * JIRA release notes [1], > >> * the official Apache source release to be deployed to dist.apache.org > >> [2], > >> which are signed with the key with fingerprint > >> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > >> * all artifacts to be deployed to the Maven Central Repository [4], > >> * source code tag v3.1.1-rc2 [5], > >> * website pull request listing the new release [6]. > >> > >> The vote will be open for at least 72 hours. It is adopted by majority > >> approval, with at least 3 PMC affirmative votes. > >> > >> Thanks, > >> Release Manager > >> > >> [1] > >> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353281 > >> [2] > >> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc2 > >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >> [4] > https://repository.apache.org/content/repositories/orgapacheflink-1642 > >> [5] https://github.com/apache/flink-connector- > >> <connector>/releases/tag/v3.1.1-rc2 > >> [6] https://github.com/apache/flink-web/pull/654 > >> > > -- Best regards, Sergey
