Re: [DISCUSS] FLIP-294: Support Customized Job Meta Data Listener

2023-06-06 Thread Panagiotis Garefalakis
Hey Shammon, Thanks for the FLIP and the discussion! Pretty useful stuff -- also looking forward to the lineage feature! Just my 2 cents: if we want to enable users to perform heavy async operations, should we pass an ioExecutor to the listeners? Also, would it make sense to provide a default imp

Re: [DISCUSS] FLIP-294: Support Customized Job Meta Data Listener

2023-06-06 Thread Leonard Xu
Thanks Shammon for driving this FLIP forward, I’ve several comments about the updated FLIP. 1. CatalogModificationContext is introduced as a class instead of an interface, is it a typo? 2. The FLIP defined multiple Map config(); methods in some Context classes, Could we use Configuration ge

Re: [DISCUSS] FLIP-294: Support Customized Job Meta Data Listener

2023-06-06 Thread David Morávek
Hi, Thanks for the FLIP! Data lineage is an important problem to tackle. Can you please expand on how this is planned to be wired into the JobManager? As I understand, the listeners will be configured globally (per cluster), so this won't introduce a new code path for running per-job / per-sessio

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-06 Thread Martijn Visser
Hi Yuxia, Thanks for the clarification. I would be +0 overall, because I think without actually allowing creation/customization of stored procedures, the value for the majority of Flink users will be minimal. Best regards, Martijn On Tue, Jun 6, 2023 at 3:52 AM yuxia wrote: > Hi, Martijn. > T

Re: [VOTE] Release flink-connector-pulsar 3.0.1, release candidate #1

2023-06-06 Thread Jark Wu
+1 (binding) - Build and compile the source code locally: *OK* - Verified signatures and hashes: *OK* - Checked no missing artifacts in the staging area: *OK* - Reviewed the website release PR: *OK* Best, Jark On Thu, 1 Jun 2023 at 07:30, Jing Ge wrote: > +1(non-binding) > > - verified sign >

Re: [DISCUSS] FLIP-294: Support Customized Job Meta Data Listener

2023-06-06 Thread Shammon FY
Hi, Thanks for all the feedback. For @Jing Ge, I forget to update the demo code in the FLIP, the method is `onEvent(CatalogModificationEvent, CatalogModificationContext)` and there is no `onEvent(CatalogModificationEvent)`. I have updated the code. Context contains some additional information tha

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-06 Thread Chesnay Schepler
I'm a bit concerned that the last 4 CI runs haven't succeeded in the 3.1 branch. Has anyone looked into the failing oracle test (both 1.17/1.18)? https://github.com/apache/flink-connector-jdbc/actions/runs/5058372107/jobs/9078398092 Why is a vote being opened when there's still a blocker ticket

Re: [DISCUSS] FLIP-294: Support Customized Job Meta Data Listener

2023-06-06 Thread Leonard Xu
Thanks Shammon for the timely update, the updated FLIP looks good to me. Hope to see the vote thread and following FLIP-314 discussion thread. Best, Leonard > On Jun 6, 2023, at 5:04 PM, Shammon FY wrote: > > Hi, > > Thanks for all the feedback. > > For @Jing Ge, > I forget to update the dem

Re: [DISCUSS] Status of Statefun Project

2023-06-06 Thread Chesnay Schepler
If you were to fork it /and want to redistribute it/ then the short version is that 1. you have to adhere to the Apache licensing requirements 2. you have to make it clear that your fork does not belong to the Apache Flink project. (Trademarks and all that) Neither should be significant hurd

Re: [DISCUSS] FLIP-294: Support Customized Job Meta Data Listener

2023-06-06 Thread Jing Ge
Hi Shammon, Thanks for the clarification. Just out of curiosity, if the context is not part of the event, why should it be the input parameter of each onEvent call? Best regards, Jing On Tue, Jun 6, 2023 at 11:58 AM Leonard Xu wrote: > Thanks Shammon for the timely update, the updated FLIP loo

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-06 Thread Feng Jin
Hi everyone, Thank you everyone for your valuable input. If there are no further questions or concerns about the FLIP[1], I would like to start voting tomorrow (6/7). [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-295%3A+Support+lazy+initialization+of+catalogs+and+persistence+of+cata

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-06 Thread liu ron
Hi dev Thanks for all the feedback, it seems that here are no more comments, I will start a vote on FLIP-315 [1] later. Thanks again. [1]: https://cwiki.apache.org/confluence/display/FLINK/FLIP-315+Support+Operator+Fusion+Codegen+for+Flink+SQL Best, Ron liu ron 于2023年6月5日周一 16:01写道: > Hi, Yun

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-06 Thread Leonard Xu
Hi, Feng Sorry for reply late, but I’ve some comments about the FLIP 1. The introduced Public class CatalogDescriptor seems missed some necessary component a) How to construct a CatalogDescriptor ? b) How to visit the fields ? Could we use Configuration instead of Map ? c) Could we offer

[DISCUSS] FLIP-314: Support Customized Job Lineage Listener

2023-06-06 Thread Shammon FY
Hi devs, I would like to start a discussion on FLIP-314: Support Customized Job Lineage Listener[1] which is the next stage of FLIP-294 [2]. Flink streaming and batch jobs create lineage dependency between source and sink, users can manage their data and jobs according to this lineage information.

Re: [DISCUSS] FLIP-308: Support Time Travel In Batch Mode

2023-06-06 Thread Leonard Xu
Hi, Feng Thanks for driving this FLIP, very impressive feature that users want, I’ve some quick questions here. 1.Unification SQL: The snapshot concept exists both in Batch mode and Streaming mode, could we consider a unified proposal? I think users won’t another SQL syntax named Ti

[jira] [Created] (FLINK-32267) Update testcontainers dependency to v1.18.3

2023-06-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32267: --- Summary: Update testcontainers dependency to v1.18.3 Key: FLINK-32267 URL: https://issues.apache.org/jira/browse/FLINK-32267 Project: Flink Issue Type:

[jira] [Created] (FLINK-32268) KafkaTableITCase.testKafkaSourceSinkWithBoundedTimestamp failed to create topic

2023-06-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32268: --- Summary: KafkaTableITCase.testKafkaSourceSinkWithBoundedTimestamp failed to create topic Key: FLINK-32268 URL: https://issues.apache.org/jira/browse/FLINK-32268

Re: [DISCUSS] FLIP-308: Support Time Travel In Batch Mode

2023-06-06 Thread Feng Jin
Hi Leonard, Thanks for your reply. > 1. a How to construct a CatalogDescriptor ? I think it would be helpful to add a method for constructing a CatalogDescriptor, as you mentioned in 1.c. I will update the documentation later. > 1.b How to visit the fields ? Could we use Configuration instead

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-06 Thread Feng Jin
Hi Leonard, Thanks for your reply. > 1. a How to construct a CatalogDescriptor ? I think it would be helpful to add a method for constructing a CatalogDescriptor, as you mentioned in 1.c. I will update the documentation later. > 1.b How to visit the fields ? Could we use Configuration instead

Re: [DISCUSS] Status of Statefun Project

2023-06-06 Thread Galen Warren
Thanks for the information. On Tue, Jun 6, 2023, 6:07 AM Chesnay Schepler wrote: > If you were to fork it /and want to redistribute it/ then the short > version is that > > 1. you have to adhere to the Apache licensing requirements > 2. you have to make it clear that your fork does not belong

Re: [DISCUSS] FLIP-308: Support Time Travel In Batch Mode

2023-06-06 Thread Feng Jin
Sorry I replied to the wrong mail. Please ignore the last email. Hi Leonard > 1. Unification SQL I agree that it is crucial for us to support both batch and streaming processing. The current design allows for the support of both batch and streaming processing. I'll update the FLIP later. >

Re: [DISCUSS] FLIP-308: Support Time Travel In Batch Mode

2023-06-06 Thread Feng Jin
Hi everyone Thanks everyone for your input. @Yun > I think you could add descriptions of how to align backfill time travel with querying the latest data. And I think you should also update the "Discussion thread" in the original FLIP. Thank you for the suggestion, I will update it in the docu

[jira] [Created] (FLINK-32269) CreateTableAsITCase.testCreateTableAsInStatementSet fails on AZP

2023-06-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32269: --- Summary: CreateTableAsITCase.testCreateTableAsInStatementSet fails on AZP Key: FLINK-32269 URL: https://issues.apache.org/jira/browse/FLINK-32269 Project: Flink

[jira] [Created] (FLINK-32270) Heartbeat timeout in AggregateReduceGroupingITCase.testAggOnLeftJoin on AZP

2023-06-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32270: --- Summary: Heartbeat timeout in AggregateReduceGroupingITCase.testAggOnLeftJoin on AZP Key: FLINK-32270 URL: https://issues.apache.org/jira/browse/FLINK-32270 Pro

[jira] [Created] (FLINK-32271) Report RECOMMENDED_PARALLELISM as an autoscaler metric

2023-06-06 Thread Matyas Orhidi (Jira)
Matyas Orhidi created FLINK-32271: - Summary: Report RECOMMENDED_PARALLELISM as an autoscaler metric Key: FLINK-32271 URL: https://issues.apache.org/jira/browse/FLINK-32271 Project: Flink Issu

Re: [DISCUSS] FLIP-307: Flink connector Redshift

2023-06-06 Thread Samrat Deb
Hi Martijn, > If I understand this correctly, the Redshift sink would not be able to support exactly-once, is that correct? As I delve deeper into the study of Redshift's capabilities, I have discovered that it does support "merge into" operations [1] and some merge into examples [2]. This opens

Re: [DISCUSS] FLIP-307: Flink connector Redshift

2023-06-06 Thread Samrat Deb
Hi Jing, > I would suggest adding that information into the FLIP. Updated now, please review the new version of flip whenever time. > +1 Looking forward to your PR :-) I will request for your review once m ready with PR :-) Bests, Samrat On Tue, Jun 6, 2023 at 11:43 PM Samrat Deb wrote: > H

Re: [DISCUSS] FLIP-246: Multi Cluster Kafka Source

2023-06-06 Thread Jing Ge
Hi Mason, It is a very practical feature that many users are keen to use. Thanks to the previous discussion, the FLIP now looks informative. Thanks for your proposal. One small suggestion is that the attached images are quite small to read if we don't click and enlarge them. Besides that, It is di

[jira] [Created] (FLINK-32272) Expose LOAD_MAX as autoscaler metric

2023-06-06 Thread Matyas Orhidi (Jira)
Matyas Orhidi created FLINK-32272: - Summary: Expose LOAD_MAX as autoscaler metric Key: FLINK-32272 URL: https://issues.apache.org/jira/browse/FLINK-32272 Project: Flink Issue Type: New Featur

[jira] [Created] (FLINK-32273) What is org.apache.flink.avro.generated.record_json?

2023-06-06 Thread Tan Kim (Jira)
Tan Kim created FLINK-32273: --- Summary: What is org.apache.flink.avro.generated.record_json? Key: FLINK-32273 URL: https://issues.apache.org/jira/browse/FLINK-32273 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-316: Introduce SQL Driver

2023-06-06 Thread Paul Lam
Hi Mason, Thanks for your input! > +1 for init containers or a more generalized way of obtaining arbitrary > files. File fetching isn't specific to just SQL--it also matters for Java > applications if the user doesn't want to rebuild a Flink image and just > wants to modify the user application f

Re: [VOTE] Release flink-connector-pulsar 3.0.1, release candidate #1

2023-06-06 Thread Jingsong Li
+1 (binding) - checked NOTICE and LICENSE - Verified signatures and hashes - Build and compile the source code locally - No unexpected binaries in the source release Something can be improved: - NOTICE file can be updated to 2014-2023 from 2014-2022. Best, Jingsong On Tue, Jun 6, 2023 at 3:59 

Re: [DISCUSS] FLIP-316: Introduce SQL Driver

2023-06-06 Thread Weihua Hu
Hi, Thanks for updating the FLIP. I have two cents on the distribution of SQLs and resources. 1. Should we support a common file distribution mechanism for k8s application mode? I have seen some issues and requirements on the mailing list. In our production environment, we implement the downl

Re: [DISCUSS] FLIP-308: Support Time Travel In Batch Mode

2023-06-06 Thread yuxia
Hi, Feng Jin. I think the concern of Leonard may be the inconsistency of the behavior of TIMESTAMP '2023-04-27 00:00:00' beween timetravel and other sql statement. For the normal sql: `SELECT TIMESTAMP '2023-04-27 00:00:00'`, we won't consider timezone. But for the sql for timetravl: `SELECT * FR

Re: [DISCUSS] FLIP-308: Support Time Travel In Batch Mode

2023-06-06 Thread Benchao Li
I also share the concern about the timezone problem. The type for "TIMESTAMP '2023-04-27 00:00:00'" should be "TIMESTAMP WITHOUT TIME ZONE", converting it to unix timestamp would use UTC timezone, which is not usually expected by users. If we want to keep consistent with the standard, we probably

Re: [VOTE] FLIP-312: Add Yarn ACLs to Flink Containers

2023-06-06 Thread Dong Lin
+1 (binding) Thank you Archit for driving the FLIP. Cheers, Dong On Tue, Jun 6, 2023 at 12:55 AM Archit Goyal wrote: > Hi everyone, > > Thanks for all the feedback for FLIP-312: Add Yarn ACLs to Flink > Containers< > https://cwiki.apache.org/confluence/display/FLINK/FLIP+312%3A+Add+Yarn+ACLs+t

[VOTE] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-06 Thread liu ron
Hi everyone, Thanks for all the feedback about FLIP-315: Support Operator Fusion Codegen for Flink SQL[1]. [2] is the discussion thread. I'd like to start a vote for it. The vote will be open for at least 72 hours (until June 12th, 12:00AM GMT) unless there is an objection or an insufficient numb

Re:Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-06 Thread Mang Zhang
Hi Jingsong, >I have some doubts about the `TwoPhaseCatalogTable`. Generally, our >Flink design places execution in the TableFactory or directly in the >Catalog, so introducing an executable table makes me feel a bit >strange. (Spark is this style, but Flink may not be) On this issue, we introdu

Re: [VOTE] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-06 Thread Jark Wu
+1 (binding) Best, Jark > 2023年6月7日 14:20,liu ron 写道: > > Hi everyone, > > Thanks for all the feedback about FLIP-315: Support Operator Fusion Codegen > for Flink SQL[1]. > [2] is the discussion thread. > > I'd like to start a vote for it. The vote will be open for at least 72 > hours (until

Re: [VOTE] Release flink-connector-pulsar 3.0.1, release candidate #1

2023-06-06 Thread Martijn Visser
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PRs On Wed, Jun 7, 2023 at 4:34 AM Jingsong Li wrote: > +1 (binding) > > - checked NOTICE and LICENSE > - Verified signat