Re: [DISCUSS] FLIP-264 Extract BaseCoordinatorContext

2022-10-16 Thread Hang Ruan
Hi, IMP, I agree to extract a base class for SourceCoordinatorContext. But I prefer to use the name `OperatorCoordinatorContextBase` or `CoordinatorContextBase` as the format like `SourceReaderBase`. I also agree to what Piotr said. Maybe more problems will occur when connectors start to use it.

[jira] [Created] (FLINK-29650) Printing the contents of error lines when parsing yaml file may leak sensitive configuration values

2022-10-16 Thread luyuan (Jira)
luyuan created FLINK-29650: -- Summary: Printing the contents of error lines when parsing yaml file may leak sensitive configuration values Key: FLINK-29650 URL: https://issues.apache.org/jira/browse/FLINK-29650

Re: [VOTE] Drop Gelly

2022-10-16 Thread Yu Li
+1 Thanks for the clarification Martijn and Yun. Hopefully we can document somewhere that there is a plan (maybe long term) to introduce a replacement based on the new iteration framework introduced in flink-ml (based on DataStream API) after dropping the old Gelly library, and let our users know

Re: [DISCUSS] FLIP-264 Extract BaseCoordinatorContext

2022-10-16 Thread Steven Wu
Hang, appreciate your input. Agree that `CoordinatorContextBase` is a better name considering Flink code convention. If there are any concrete concerns, we can discuss. In the jira, On Sun, Oct 16, 2022 at 12:12 AM Hang Ruan wrote: > Hi, > > IMP, I agree to extract a base class for SourceCoor

Re: [DISCUSS] FLIP-264 Extract BaseCoordinatorContext

2022-10-16 Thread Steven Wu
sorry. sent the incomplete reply by mistake. If there are any concrete concerns, we can discuss. In the FLINK-27405 [1], Avid pointed out some implications regarding checkpointing. In this small FLIP, we are not exposing/changing any checkpointing logic, we mainly need the coordinator context func

[jira] [Created] (FLINK-29651) Code gen will fail when the literal specified in user's sql hasn't be escaped

2022-10-16 Thread luoyuxia (Jira)
luoyuxia created FLINK-29651: Summary: Code gen will fail when the literal specified in user's sql hasn't be escaped Key: FLINK-29651 URL: https://issues.apache.org/jira/browse/FLINK-29651 Project: Flin

Re: [DISCUSS] FLIP-263: Improve resolving schema compatibility

2022-10-16 Thread Hangxiang Yu
Hi, Han. Both the old method and the new method can get previous and new inner information. The new serializer will decide it just like the old serializer did before. The method just specify the schema compatibility result so that other behaviours is same as before. On Fri, Oct 14, 2022 at 11:4

Re: [DISCUSS] FLIP-263: Improve resolving schema compatibility

2022-10-16 Thread Hangxiang Yu
Hi, Zakelly. Good point. +1 it makes code more straightforward. I have modified the FLIP to make the new interface call the old interface as default. On Fri, Oct 14, 2022 at 4:46 PM Zakelly Lan wrote: > Hi Hangxiang, > > I'm ok with your proposed Step 2, but I'm afraid you missed my point. > A

Re: Sink V2 interface replacement for GlobalCommitter

2022-10-16 Thread Yun Gao
Hi Liwei, From my side I think it might require case-by-case discussion. If there are missed information that blocked some scenarios, we may have dedicated issues / discussion for the scenario and and have more in-depth discussion for these scenarios. Best, Yun Gao --

Re: [VOTE] Drop Gelly

2022-10-16 Thread Yun Gao
Hi Yu, Very thanks for the suggestions and I also strongly agree with that. Perhaps we could update the Gelly documentation pages to also express the information. Best, Yun Gao -- From:Yu Li Send Time:2022 Oct. 16 (Sun.) 18:30 To:de

[jira] [Created] (FLINK-29652) get duplicate result from sql-client in BATCH mode

2022-10-16 Thread Jingqi Shi (Jira)
Jingqi Shi created FLINK-29652: -- Summary: get duplicate result from sql-client in BATCH mode Key: FLINK-29652 URL: https://issues.apache.org/jira/browse/FLINK-29652 Project: Flink Issue Type: Bu

[jira] [Created] (FLINK-29653) close DynamicResult but it was already closed

2022-10-16 Thread Jingqi Shi (Jira)
Jingqi Shi created FLINK-29653: -- Summary: close DynamicResult but it was already closed Key: FLINK-29653 URL: https://issues.apache.org/jira/browse/FLINK-29653 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-29654) Vulnerable libraries - Flink 1.15.2

2022-10-16 Thread nagasudhakar (Jira)
nagasudhakar created FLINK-29654: Summary: Vulnerable libraries - Flink 1.15.2 Key: FLINK-29654 URL: https://issues.apache.org/jira/browse/FLINK-29654 Project: Flink Issue Type: Bug

Re: [VOTE] Drop Gelly

2022-10-16 Thread Sergey Nuyanzin
+1 (non-binding) On Mon, Oct 17, 2022 at 5:50 AM Yun Gao wrote: > Hi Yu, > Very thanks for the suggestions and I also strongly > agree with that. Perhaps we could update the Gelly > documentation pages to also express the information. > Best, > Yun Gao > -