Re: Storm compatibility layer for Flink (first beta available)

2015-04-06 Thread Márton Balassi
Thanks, Matthias. Yes, please. :) On Mon, Apr 6, 2015 at 3:40 PM, Matthias J. Sax < mj...@informatik.hu-berlin.de> wrote: > Done. Shall I open a pull request? > > -Matthias > > > On 04/03/2015 09:32 PM, Robert Metzger wrote: > > As far as I understood git rebase [1], cherry-picking all changes in

Re: Storm compatibility layer for Flink (first beta available)

2015-04-06 Thread Matthias J. Sax
Done. Shall I open a pull request? -Matthias On 04/03/2015 09:32 PM, Robert Metzger wrote: > As far as I understood git rebase [1], cherry-picking all changes in order > to the current master is exactly equal to "git rebase flink/master". > The problem is that you have to resolve all conflicts a

Re: Storm compatibility layer for Flink (first beta available)

2015-04-03 Thread Robert Metzger
As far as I understood git rebase [1], cherry-picking all changes in order to the current master is exactly equal to "git rebase flink/master". The problem is that you have to resolve all conflicts again. But in this case the changes to existing code are pretty small, so that might actually work co

Re: Storm compatibility layer for Flink (first beta available)

2015-04-03 Thread Fabian Hueske
Right now, your commits in your working branch are mixed with commits which are already in pushed to the master branch. Merging this branch to the master branch in order to push it to our master might turn out into a complex merging process. Merging becomes far easier for us, if all commits that yo

Re: Storm compatibility layer for Flink (first beta available)

2015-04-02 Thread Paris Carbone
That’s pretty nice Matthias, we could use a compositional API in streaming that many people are familiar with. I can also help in some parts, I see some issues we already encountered while creating the samoa adapter (eg. dealing with circles in the topology). Thanks again for initiating this! P

Re: Storm compatibility layer for Flink (first beta available)

2015-04-02 Thread Gyula Fóra
This sounds amazing :) thanks Matthias! Tomorrow I will spend some time to look through your work and give some comments. Also I would love to help with this effort so once we merge an initial prototype let's open some Jiras and I will pick some up :) Gyula On Thursday, April 2, 2015, Márton Ba

Re: Storm compatibility layer for Flink (first beta available)

2015-04-02 Thread Márton Balassi
Hey Mathias, Thanks, this is a really nice contribution. I just scrolled through the code, but I really like it and big thanks for the the tests for the examples. The rebase Fabian suggested would help a lot when merging. On Thu, Apr 2, 2015 at 9:19 PM, Fabian Hueske wrote: > Hi Matthias, >

Re: Storm compatibility layer for Flink (first beta available)

2015-04-02 Thread Fabian Hueske
Hi Matthias, this is really cool!I especially like that you can use Storm code within a Flink streaming program :-) One thing that might be good to do rather soon is to collect all your commits and put them on top of a fresh forked Flink master branch. When merging we cannot change the history an

Re: Storm compatibility layer for Flink (first beta available)

2015-04-02 Thread Robert Metzger
Hey Henry, you can check out the files here: https://github.com/mjsax/flink/tree/flink-storm-compatibility/flink-staging/flink-streaming/flink-storm-compatibility ... so yes, they are located in the flink-streaming directory .. which is a good place for now. Once we move flink-streaming out of sta

Re: Storm compatibility layer for Flink (first beta available)

2015-04-02 Thread Henry Saputra
HI Matthias, Where do you put the code for the Storm compatibility? Under streams module directory? - Henry On Thu, Apr 2, 2015 at 10:31 AM, Matthias J. Sax wrote: > Hi @all, > > I started to work on an compatibility layer to run Storm Topologies on > Flink. I just pushed a first beta: > https:

Re: Storm compatibility layer for Flink (first beta available)

2015-04-02 Thread Robert Metzger
Hey Matthias, a Storm compatibility layer sounds really great! I'll soon take a closer look into the code, but the features you're listing sound really amazing! Since the code has already testcases included, I'm open to merging a first stable version and then continue the development of the featu

Storm compatibility layer for Flink (first beta available)

2015-04-02 Thread Matthias J. Sax
Hi @all, I started to work on an compatibility layer to run Storm Topologies on Flink. I just pushed a first beta: https://github.com/mjsax/flink/tree/flink-storm-compatibility Please check it out, and let me know how you like it. In this first version, I tried to code without changing too many t