Re: [VOTE] Release flink-connector-jdbc, release candidate #2

Thanks everyone for the feedback This RC is cancelled and a new one will be created On Thu, Feb 1, 2024 at 2:42 AM Leonard Xu wrote: > Thanks Sergey for driving this! > > -1(binding) as we discussed on the web PR[1], looking forward next RC. > > Best, > Leonard > [1] https://github.com/apache/f

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

Thanks Sergey for driving this! -1(binding) as we discussed on the web PR[1], looking forward next RC. Best, Leonard [1] https://github.com/apache/flink-web/pull/707#discussion_r1471090061 > 2024年1月30日 上午8:17，Sergey Nuyanzin 写道： > > Hi everyone, > Please review and vote on the release candida

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

Hi David, thanks for your feedback > This release introduces (I assume experimental, like Flink’s statement around Java compatibility but we have not documented this as experimental) support for Java 17. I see https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/java_compatibility/

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

Hi, [x] -1, Do not approve the release (please provide specific comments) I wanted clarifications on our thinking around the following. In the source code https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2 * This release introduces (I assume experimental, like Flink’s st

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

+1 (non-binding) - Validated checksum hash - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven and jdk11 - Verified web PR - Check that the jar is built by jdk8 Best, Hang Jiabao Sun 于2024年1月30日周二 10:52写道： > +1(non-binding) > > - Release n

RE: [VOTE] Release flink-connector-jdbc, release candidate #2

+1(non-binding) - Release notes look good - Tag is present in Github - Validated checksum hash - Verified signature - Verified web PR and left minor comments Best, Jiabao On 2024/01/30 00:17:54 Sergey Nuyanzin wrote: > Hi everyone, > Please review and vote on the release candidate #2 for the ve

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

Hi all, I'm happy to announce that we have unanimously approved this release. There are 4 approving votes, 3 of which are binding: * Sergey Nuyanzin (non-binding) * Dawid (binding) * Martijn (binding) * Danny (binding) There are no disapproving votes. Thanks everyone! Best regards, Martijn O

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

Hello, +1 (binding) - Release notes look good - Verified signatures and hashes - Verified there are no binaries in the source archive - NOTICE/Licenses look good - Built source - Tag exists in Github - Contents of Maven repo look good - Reviewed web PR Thanks, On Tue, Dec 20, 2022 at 12:04 PM M

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PR On Mon, Dec 19, 2022 at 3:53 PM Dawid Wysakowicz wrote: > +1 (binding) > >- verified signatures and checksums >

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

+1 (binding) * verified signatures and checksums * built from sources * the PR looks good * the artifacts to be published look fine * checked files diff to the 1.16.0 release tag Best, Dawid On 19/12/2022 12:17, Sergey Nuyanzin wrote: +1 (non-binding) - Validated hashes and signature -

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

+1 (non-binding) - Validated hashes and signature - Verified that no binaries exist in the source archive - Build from sources with Maven - Verified licenses one nitpick: it seems a link to the tag is broken (number 5) I guess it should be this one https://github.com/apache/flink-connector-jdbc/r