Hi David, thanks for your feedback > This release introduces (I assume experimental, like Flink’s statement around Java compatibility but we have not documented this as experimental) support for Java 17. I see https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/java_compatibility/ says that java 17 support was added at 1.18. I can’t find a backport to 1.16 or 1.17? Should JDBC java 17 support (FLINK-33787) be included in this release?
FLINK-33787 is included in release, please see JIRA release notes[1] I don't think we can backport java 17 support to 1.16, 1.17, that's why java 17 support was added only for connector running with Flink 1.18, you can see it in GHA config [2] >The Flink version in the pom is 1.17, but we are saying we support Flink 1.16. yes, that's true, it seems it is is the result of [3], as there were issues with archunit tests at the same time we still have nightly/weekly tests running against Flink 1.16 as well and latest test are green [4] @Martijn Visser may be you can provide more details [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354088 [2] https://github.com/apache/flink-connector-jdbc/blob/v3.1/.github/workflows/push_pr.yml#L27-L32 [3] https://issues.apache.org/jira/browse/FLINK-31699 [4] https://github.com/apache/flink-connector-jdbc/actions/runs/7723924144 On Wed, Jan 31, 2024 at 11:18 AM David Radley <david_rad...@uk.ibm.com> wrote: > Hi, > [x] -1, Do not approve the release (please provide specific comments) > > I wanted clarifications on our thinking around the following. > > In the source code > https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2 > > * This release introduces (I assume experimental, like Flink’s > statement around Java compatibility but we have not documented this as > experimental) support for Java 17. I see > https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/java_compatibility/ > says that java 17 support was added at 1.18. I can’t find a backport to > 1.16 or 1.17? Should JDBC java 17 support (FLINK-33787) be included in this > release? > * The Flink version in the pom is 1.17, but we are saying we support > Flink 1.16. > > > Kind regards, David. > > From: Sergey Nuyanzin <snuyan...@gmail.com> > Date: Tuesday, 30 January 2024 at 00:18 > To: dev@flink.apache.org <dev@flink.apache.org> > Subject: [EXTERNAL] [VOTE] Release flink-connector-jdbc, release candidate > #2 > Hi everyone, > Please review and vote on the release candidate #2 for the version > 3.1.2, as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x. > > The complete staging area is available for your review, which includes: > * JIRA release notes [1], > * the official Apache source release to be deployed to dist.apache.org > [2], which are signed with the key with fingerprint > 1596BBF0726835D8 [3], > * all artifacts to be deployed to the Maven Central Repository [4], > * source code tag v3.1.2-rc2 [5], > * website pull request listing the new release [6]. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Release Manager > > [1] > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354088 > [2] > https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2 > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > [4] > https://repository.apache.org/content/repositories/orgapacheflink-1704/ > [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2 > [6] https://github.com/apache/flink-web/pull/707 > > Unless otherwise stated above: > > IBM United Kingdom Limited > Registered in England and Wales with number 741598 > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU > -- Best regards, Sergey
