Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-04 Thread Hao Li
Hi Dev, Thanks all for voting. I'm closing the vote and the result will be posted in a separate email. Thanks, Hao On Wed, Apr 3, 2024 at 10:24 AM Hao Li wrote: > Thanks David Radley and David Moravek for the comments. I'll reply in the > discussion thread. > > Hao > > On Wed, Apr 3, 2024 at 5

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-03 Thread Hao Li
Thanks David Radley and David Moravek for the comments. I'll reply in the discussion thread. Hao On Wed, Apr 3, 2024 at 5:45 AM David Morávek wrote: > +1 (binding) > > My only suggestion would be to move Catalog changes into a separate > interface to allow us to begin with lower stability guara

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-03 Thread David Morávek
+1 (binding) My only suggestion would be to move Catalog changes into a separate interface to allow us to begin with lower stability guarantees. Existing Catalogs would be able to opt-in by implementing it. It's a minor thing though, overall the FLIP is solid and the direction is pretty exciting.

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-03 Thread David Radley
Hi Hao, I don’t think this counts as an objection, I have some comments. I should have put this on the discussion thread earlier but have just got to this. - I suggest we can put a model version in the model resource. Versions are notoriously difficult to add later; I don’t think we want to proli

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-03 Thread Martijn Visser
+1 (binding) On Wed, Apr 3, 2024 at 9:52 AM Leonard Xu wrote: > +1(binding) > > Best, > Leonard > > > 2024年4月3日 下午3:37，Piotr Nowojski 写道： > > > > +1 (binding) > > > > Best, > > Piotrek > > > > śr., 3 kwi 2024 o 04:29 Yu Chen napisał(a): > > > >> +1 (non-binding) > >> > >> Looking forward to th

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-03 Thread Leonard Xu
+1(binding) Best, Leonard > 2024年4月3日 下午3:37，Piotr Nowojski 写道： > > +1 (binding) > > Best, > Piotrek > > śr., 3 kwi 2024 o 04:29 Yu Chen napisał(a): > >> +1 (non-binding) >> >> Looking forward to this future. >> >> Thanks, >> Yu Chen >> >>> 2024年4月3日 10:23，Jark Wu 写道： >>> >>> +1 (bindi

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-03 Thread Piotr Nowojski
+1 (binding) Best, Piotrek śr., 3 kwi 2024 o 04:29 Yu Chen napisał(a): > +1 (non-binding) > > Looking forward to this future. > > Thanks, > Yu Chen > > > 2024年4月3日 10:23，Jark Wu 写道： > > > > +1 (binding) > > > > Best, > > Jark > > > > On Tue, 2 Apr 2024 at 15:12, Timo Walther wrote: > > > >> +

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-02 Thread Yu Chen
+1 (non-binding) Looking forward to this future. Thanks, Yu Chen > 2024年4月3日 10:23，Jark Wu 写道： > > +1 (binding) > > Best, > Jark > > On Tue, 2 Apr 2024 at 15:12, Timo Walther wrote: > >> +1 (binding) >> >> Thanks, >> Timo >> >> On 29.03.24 17:30, Hao Li wrote: >>> Hi devs, >>> >>> I'd

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-02 Thread Jark Wu
+1 (binding) Best, Jark On Tue, 2 Apr 2024 at 15:12, Timo Walther wrote: > +1 (binding) > > Thanks, > Timo > > On 29.03.24 17:30, Hao Li wrote: > > Hi devs, > > > > I'd like to start a vote on the FLIP-437: Support ML Models in Flink > > SQL [1]. The discussion thread is here [2]. > > > > The v

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-02 Thread Timo Walther
+1 (binding) Thanks, Timo On 29.03.24 17:30, Hao Li wrote: Hi devs, I'd like to start a vote on the FLIP-437: Support ML Models in Flink SQL [1]. The discussion thread is here [2]. The vote will be open for at least 72 hours unless there is an objection or insufficient votes. [1] https://cwi