Thanks David Radley and David Moravek for the comments. I'll reply in the discussion thread.
Hao On Wed, Apr 3, 2024 at 5:45 AM David Morávek <d...@apache.org> wrote: > +1 (binding) > > My only suggestion would be to move Catalog changes into a separate > interface to allow us to begin with lower stability guarantees. Existing > Catalogs would be able to opt-in by implementing it. It's a minor thing > though, overall the FLIP is solid and the direction is pretty exciting. > > Best, > D. > > On Wed, Apr 3, 2024 at 2:31 AM David Radley <david_rad...@uk.ibm.com> > wrote: > > > Hi Hao, > > I don’t think this counts as an objection, I have some comments. I should > > have put this on the discussion thread earlier but have just got to this. > > - I suggest we can put a model version in the model resource. Versions > are > > notoriously difficult to add later; I don’t think we want to proliferate > > differently named models as a model mutates. We may want to work with > > non-latest models. > > - I see that the model name is the unique identifier. I realise this > would > > move away from the Oracle syntax – so may not be feasible short term; > but I > > wonder if we can have: > > - a uuid as the main identifier and the model name as an attribute. > > or > > - a namespace (or something like a system of origin) > > to help organise models with the same name. > > - does the model have an owner? I assume that Flink model resource is the > > master of the model? I imagine in the future that a model that comes in > via > > a new connector could be kept up to date with the external model and > would > > not be allowed to be changed by anything other than the connector. > > > > Kind regards, David. > > > > From: Hao Li <h...@confluent.io.INVALID> > > Date: Friday, 29 March 2024 at 16:30 > > To: dev@flink.apache.org <dev@flink.apache.org> > > Subject: [EXTERNAL] [VOTE] FLIP-437: Support ML Models in Flink SQL > > Hi devs, > > > > I'd like to start a vote on the FLIP-437: Support ML Models in Flink > > SQL [1]. The discussion thread is here [2]. > > > > The vote will be open for at least 72 hours unless there is an objection > or > > insufficient votes. > > > > [1] > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-437%3A+Support+ML+Models+in+Flink+SQL > > > > [2] https://lists.apache.org/thread/9z94m2bv4w265xb5l2mrnh4lf9m28ccn > > > > Thanks, > > Hao > > > > Unless otherwise stated above: > > > > IBM United Kingdom Limited > > Registered in England and Wales with number 741598 > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU > > >
