Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-16 Thread jincheng sun
+1 (binding) With simple check; - Downloaded the source and built successfully - Verified the signature and checksum Best, Jincheng Zhijiang 于2020年2月16日周日 上午12:11写道: > +1 (non-binding) > > - Checked the release notes > - Downloaded the source and built successfully > - Verified the signat

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-15 Thread Zhijiang
+1 (non-binding) - Checked the release notes - Downloaded the source and built successfully - Verified the signature and checksum - Verified the artifacts in the Maven Central Repository Best, Zhijiang -- From:Robert Metzger Send

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-14 Thread Robert Metzger
+1 (binding) - Checked some artifacts in the staging repo - checked license documentation - source release is binary free On Fri, Feb 14, 2020 at 8:01 AM Dian Fu wrote: > +1 (non-binding) > > - Verified the signature and checksum > - Checked the release note that all the tickets included in th

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-13 Thread Dian Fu
+1 (non-binding) - Verified the signature and checksum - Checked the release note that all the tickets included in this release are there - Checked the website PR and it LGTM - Checked the notice file of the newly added module flink-shade-zookeeper-3 and it LGTM Regards, Dian > 在 2020年2月14日,下午

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-13 Thread Hequn Cheng
Thank you Chesnay for the release! +1 (non-binding) - The problem that exists in RC1 has been resolved. - Release notes looks good. - Built from source archive successfully. - Check commit history manually. Nothing looks weird. - Signatures and hash are correct. - All artifacts have been deployed

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-13 Thread Zhu Zhu
+1 (non-binding) - checked release notes, JIRA tickets and commit history - verified the signature and checksum - checked the maven central artifacts * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator and zookeeper classes are there and shaded - built from the source archive a

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-13 Thread Ufuk Celebi
PS: Also verified the NOTICE changes since the last RC. On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi wrote: > Hey Chensay, > > +1 (binding). > > - Verified checksum ✅ > - Verified signature ✅ > - Jira changelog looks good to me ✅ > - Website PR looks good to me ✅ > - Verified no unshaded dependen

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-13 Thread Ufuk Celebi
Hey Chensay, +1 (binding). - Verified checksum ✅ - Verified signature ✅ - Jira changelog looks good to me ✅ - Website PR looks good to me ✅ - Verified no unshaded dependencies (except the Hadoop modules which I think is expected) ✅ - Verified dependency management fix FLINK-15540 (commons-collect

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

2020-02-13 Thread Yu Li
+1 (non-binding) Checked issues listed in release notes: ok Checked sums and signatures: ok Checked the maven central artifices: ok Built from source: ok (8u101, 11.0.4) Built from source (with -Dshade-sources): ok (8u101, 11.0.4) Checked contents of zookeeper shaded jars: ok - no unshaded classes