+1 (non-binding)

- checked release notes, JIRA tickets and commit history
- verified the signature and checksum
- checked the maven central artifacts
  * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator and
zookeeper classes are there and shaded
- built from the source archive as well as the git tag
- checked the website pull request

Thanks,
Zhu Zhu

Ufuk Celebi <u...@apache.org> 于2020年2月14日周五 上午12:32写道:

> PS: Also verified the NOTICE changes since the last RC.
>
> On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <u...@apache.org> wrote:
>
> > Hey Chensay,
> >
> > +1 (binding).
> >
> > - Verified checksum ✅
> > - Verified signature ✅
> > - Jira changelog looks good to me ✅
> > - Website PR looks good to me ✅
> > - Verified no unshaded dependencies (except the Hadoop modules which I
> > think is expected) ✅
> > - Verified dependency management fix FLINK-15540
> > (commons-collections:3.2.2 as expected) ✅
> > - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except for
> > flink-shaded-force-shading and the Hadoop modules which I think is
> > expected) ✅
> >
> > – Ufuk
> >
> > On Thu, Feb 13, 2020 at 3:08 PM Yu Li <car...@gmail.com> wrote:
> > >
> > > +1 (non-binding)
> > >
> > > Checked issues listed in release notes: ok
> > > Checked sums and signatures: ok
> > > Checked the maven central artifices: ok
> > > Built from source: ok (8u101, 11.0.4)
> > > Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
> > > Checked contents of zookeeper shaded jars: ok
> > > - no unshaded classes
> > > - shading pattern is correct
> > > Checked website pull request listing the new release: ok
> > >
> > > Best Regards,
> > > Yu
> > >
> > >
> > > On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <ches...@apache.org>
> > wrote:
> > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #3 for the version
> > 10.0,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release to be deployed to
> dist.apache.org
> > > > [2], which are signed with the key with fingerprint 11D464BA [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag "release-10.0-rc3 [5],
> > > > * website pull request listing the new release [6].
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Chesnay
> > > >
> > > > [1]
> > > >
> > > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> > > > [2]
> > https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1337
> > > > [5]
> > > >
> > > >
> >
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> > > > [6] https://github.com/apache/flink-web/pull/304
> > > >
> > > >
> > > >
> > > >
> >
>

Reply via email to