Re: [VOTE] Release flink-connector-cassandra, release candidate #1

2022-11-29 Thread Ryan Skraba
Hello! +1 (non-binding) 1. Verified signature and SHA512 checksum in svn 2. Verified that the tag exists on the source git repository and is (mostly) identical to the source tar release - Some .-prefixed files like .idea/ and .gitignore in the repo under the tag that are not in the tar (but

Re: [VOTE] Release flink-connector-cassandra, release candidate #1

2022-11-29 Thread Chesnay Schepler
The usage of the artifact shortcode was somewhat intentional; the connector_artifact shortcode does not support scala suffixes, which the cassandra connector unfortunately needs On 29/11/2022 15:16, Danny Cranmer wrote: +1 (binding) - Verified signature/hashes - Build the source with Mave

Re: [VOTE] Release flink-connector-cassandra, release candidate #1

2022-11-29 Thread Danny Cranmer
+1 (binding) - Verified signature/hashes - Build the source with Maven (tests pass) - Verified NOTICE files - Verified that no binaries exist in the source archive - Verified artifacts in repository.apache.org are as expected - Verified tag exists on github - Approved web PR I noticed the incorre

Re: [VOTE] Release flink-connector-cassandra, release candidate #1

2022-11-29 Thread Martijn Visser
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PR On Tue, Nov 29, 2022 at 11:50 AM Chesnay Schepler wrote: > > the link to a tag in the initial message is wrong > > Wh

Re: [VOTE] Release flink-connector-cassandra, release candidate #1

2022-11-29 Thread Chesnay Schepler
> the link to a tag in the initial message is wrong Whoops, small bug in the message generator. > Did we ever consider having the `flink-version` always as part of the connector version? Not specifically, no. I think it makes sense though that if you take the "3.0.0" source that you get "3.0

Re: [VOTE] Release flink-connector-cassandra, release candidate #1

2022-11-29 Thread Dawid Wysakowicz
+1 (binding) - Downloaded artifacts - Checked hash and signature - No binaries in source archive found - Verified NOTICE files - Built from source code - Verified that no SNAPSHOT versions exist, all versions point to 3.0.0 in POM files - Tag is OK - Reviewed the Web PR Few notes: - the link to

Re: [VOTE] Release flink-connector-cassandra, release candidate #1

2022-11-25 Thread Etienne Chauchot
+1 (non-binding) Etienne Le 25/11/2022 à 10:31, Chesnay Schepler a écrit : Hi everyone, Please review and vote on the release candidate #1 for the version 3.0.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete stagin