The usage of the artifact shortcode was somewhat intentional; the
connector_artifact shortcode does not support scala suffixes, which the
cassandra connector unfortunately needs....
On 29/11/2022 15:16, Danny Cranmer wrote:
+1 (binding)
- Verified signature/hashes
- Build the source with Maven (tests pass)
- Verified NOTICE files
- Verified that no binaries exist in the source archive
- Verified artifacts in repository.apache.org are as expected
- Verified tag exists on github
- Approved web PR
I noticed the incorrect short code has been used in the docs [1], however
this can be addressed as a follow-up.
Thanks,
[1]
https://github.com/apache/flink-connector-cassandra/blob/main/docs/content/docs/connectors/datastream/cassandra.md
On Tue, Nov 29, 2022 at 1:48 PM Martijn Visser <martijnvis...@apache.org>
wrote:
+1 (binding)
- Validated hashes
- Verified signature
- Verified that no binaries exist in the source archive
- Build the source with Maven
- Verified licenses
- Verified web PR
On Tue, Nov 29, 2022 at 11:50 AM Chesnay Schepler <ches...@apache.org>
wrote:
> the link to a tag in the initial message is wrong
Whoops, small bug in the message generator.
> Did we ever consider having the `flink-version` always as part of the
connector version?
Not specifically, no.
I think it makes sense though that if you take the "3.0.0" source that
you get "3.0.0" artifacts (and making such a suffix work for SNAPSHOT
artifacts is a bit tricky because it's suddenly an infix).
In general the current setup is less complex.
I can see upsides though, like not having to modify the poms when
staging the jars.
But medium-term we want to get rid of these suffixes anyway.
On 29/11/2022 10:36, Dawid Wysakowicz wrote:
+1 (binding)
- Downloaded artifacts
- Checked hash and signature
- No binaries in source archive found
- Verified NOTICE files
- Built from source code
- Verified that no SNAPSHOT versions exist, all versions point to 3.0.0
in
POM files
- Tag is OK
- Reviewed the Web PR
Few notes:
- the link to a tag in the initial message is wrong. It should've been
https://github.com/apache/flink-connector-cassandra/releases/tag/v3.0.0-rc1
- I was a bit surprised that executing `mvn -DskipTests package`
produces artifacts without the Flink version suffix. Did we ever
consider having the `flink-version` always as part of the connector
version?
Best,
Dawid
On 25/11/2022 10:31, Chesnay Schepler wrote:
Hi everyone,
Please review and vote on the release candidate #1 for the version
3.0.0, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which
includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to
dist.apache.org [2], which are signed with the key with fingerprint
C2EED7B111D464BA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.0.0-1 [5],
* website pull request listing the new release [6].
The vote will be open for at least 72 hours. It is adopted by
majority approval, with at least 3 PMC affirmative votes.
This is the first externalized released of the Cassandra connector
and functionally identical to 1.16.0.
Thanks,
Chesnay
[1] https://issues.apache.org/jira/projects/FLINK/versions/12352593
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-cassandra-3.0.0-rc1
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4]
https://repository.apache.org/content/repositories/orgapacheflink-1549/
[5]
https://github.com/apache/flink-connector-cassandra/releases/tag/v3.0.0-1
[6] https://github.com/apache/flink-web/pull/587
