Re: [DISCUSS] Make SQL docs Blink only

2020-12-09 Thread Seth Wiesman
Great. Easiest discussion thread ever. https://issues.apache.org/jira/browse/FLINK-20551 On Wed, Dec 9, 2020 at 6:55 AM Wei Zhong wrote: > +1 > > This is a very good proposal. The Python Table API documentation also > contains some code that still uses the old planner. We may need to do the > s

Re: [DISCUSS] Make SQL docs Blink only

2020-12-09 Thread Wei Zhong
+1 This is a very good proposal. The Python Table API documentation also contains some code that still uses the old planner. We may need to do the same for the Python Table API documentation in the future. Best, Wei > 在 2020年12月9日,12:35,Jark Wu 写道: > > +1 > > This is a very good idea. > >

Re: [DISCUSS] Make SQL docs Blink only

2020-12-08 Thread Jark Wu
+1 This is a very good idea. Best, Jark On Wed, 9 Dec 2020 at 10:43, Xingbo Huang wrote: > +1 > > This is a very good proposal.In release-1.12, many newly added features are > only supported on the blink planner. For example, the newly added features > of PyFlnk in FLIP-137[1] and FLIP-139[2]

Re: [DISCUSS] Make SQL docs Blink only

2020-12-08 Thread Xingbo Huang
+1 This is a very good proposal.In release-1.12, many newly added features are only supported on the blink planner. For example, the newly added features of PyFlnk in FLIP-137[1] and FLIP-139[2] are only available on the blink planner. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-13

Re: [DISCUSS] Make SQL docs Blink only

2020-12-08 Thread Leonard Xu
+1 Very good proposal, blink planner has been the default planner since Flink 1.11.0, and many new features are not supported in legacy planner. Best, Leonard > 在 2020年12月9日,05:15,Arvid Heise 写道: > > +1, add a small info box about legacy planner and point to 1.11 doc > (nothing should have

Re: [DISCUSS] Make SQL docs Blink only

2020-12-08 Thread Arvid Heise
+1, add a small info box about legacy planner and point to 1.11 doc (nothing should have changed) Ideally, "legacy" and "blink" does not appear anywhere in the doc (except for that info box) On Tue, Dec 8, 2020 at 6:35 PM Marta Paes Moreira wrote: > +1, this is confusing (esp. for new users) an

Re: [DISCUSS] Make SQL docs Blink only

2020-12-08 Thread Marta Paes Moreira
+1, this is confusing (esp. for new users) and also creates more and more "annotation clutter" as new features are added. On Tue, Dec 8, 2020 at 5:30 PM Aljoscha Krettek wrote: > +1 > > Yes, please! > > On 08.12.20 16:52, David Anderson wrote: > > I agree -- I think separating out the legacy pla

Re: [DISCUSS] Make SQL docs Blink only

2020-12-08 Thread Aljoscha Krettek
+1 Yes, please! On 08.12.20 16:52, David Anderson wrote: I agree -- I think separating out the legacy planner info should make things clearer for everyone, and then some day we can simply drop it. Plus, doing it now will make it easier to make improvements to the docs going forward. David On

Re: [DISCUSS] Make SQL docs Blink only

2020-12-08 Thread David Anderson
I agree -- I think separating out the legacy planner info should make things clearer for everyone, and then some day we can simply drop it. Plus, doing it now will make it easier to make improvements to the docs going forward. David On Tue, Dec 8, 2020 at 4:38 PM Timo Walther wrote: > Hi Seth,

Re: [DISCUSS] Make SQL docs Blink only

2020-12-08 Thread Timo Walther
Hi Seth, this is a very good idea. We might not be able to remove the legacy planner immediately but at least we can make the docs easier for current and future users of the Blink planner. Making the SQL docs Blink-only with a dedicated legacy planner page sounds good to me. Regards, Timo